[Extensions] Prevent extensions script loads from across script worlds. [chromium/src : main]

0 views

Skip to first unread message

Justin Lulejian (Gerrit)

unread,

Apr 28, 2026, 12:54:47 PM (yesterday) Apr 28

to Andrea Orru, Hiroshige Hayashizaki, Takashi Nakayama, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org

Attention needed from Andrea Orru and Hiroshige Hayashizaki

Justin Lulejian voted and added 1 comment

Votes added by Justin Lulejian

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Justin Lulejian . resolved

Hi Andrea! Thought this might be an interesting (web) service worker involved fix to review. Could you review the .*extensions.* changes please?

Hi Hiroshige! This change is to address the immediate issue with extensions. There might be the possibility to expand this to be more comprehensive check that isn't specific to extensions, but wanted to get this fix in first. Could you review the .*blink.* changes please?

Open in Gerrit

Related details

Attention is currently required from:

Andrea Orru
Hiroshige Hayashizaki

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Justin Lulejian (Gerrit)

unread,

Apr 28, 2026, 2:51:10 PM (yesterday) Apr 28

Attention needed from Andrea Orru and Hiroshige Hayashizaki

Justin Lulejian voted and added 1 comment

Votes added by Justin Lulejian

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Justin Lulejian . unresolved

See https://crbug.com/507483993 for a potentially more comprehensive solution. LMK if that would be preferred and I can convert this commit to that.