components: Migrate BASE_FEATURE macros to 2-argument version [chromium/src : main]

2 views
Skip to first unread message

Xiaohan Wang (Gerrit)

unread,
Sep 13, 2025, 1:15:54 AM (5 days ago) Sep 13
to Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org

Xiaohan Wang voted and added 4 comments

Votes added by Xiaohan Wang

Commit-Queue+1

4 comments

File components/autofill/core/common/autofill_features.cc
Line 797, Patchset 3 (Parent):COMPONENT_EXPORT(AUTOFILL)
Xiaohan Wang . resolved

Unnecessary EXPORT removed. Ditto below.

File components/feedback/redaction_tool/redaction_tool.cc
Line 39, Patchset 3 (Parent):COMPONENT_EXPORT(REDACTION_TOOL)
Xiaohan Wang . resolved

Unnecessary EXPORT removed.

File components/regional_capabilities/regional_capabilities_switches.cc
Line 31, Patchset 3 (Parent):COMPONENT_EXPORT(REGIONAL_CAPABILITIES_SWITCHES)
Xiaohan Wang . resolved

Unnecessary EXPORT removed.

File components/search_engines/search_engines_switches.cc
Line 47, Patchset 3 (Parent):COMPONENT_EXPORT(SEARCH_ENGINES_SWITCHES)
Xiaohan Wang . resolved

Unnecessary EXPORT removed. Ditto oither places in this file.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355
Gerrit-Change-Number: 6945639
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaohan Wang <xhw...@chromium.org>
Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Sat, 13 Sep 2025 05:15:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Xiaohan Wang (Gerrit)

unread,
Sep 13, 2025, 1:58:26 AM (5 days ago) Sep 13
to Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org

Xiaohan Wang added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Xiaohan Wang . resolved

dcheng: This CL is a bit too big, and I can use "git cl split" to split it up. Do you prefer that way, or would rather this as is?

Gerrit-Comment-Date: Sat, 13 Sep 2025 05:58:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Xiaohan Wang (Gerrit)

unread,
Sep 13, 2025, 1:59:43 AM (5 days ago) Sep 13
to Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org

Xiaohan Wang voted Auto-Submit+1

Auto-Submit+1
Gerrit-Comment-Date: Sat, 13 Sep 2025 05:59:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Xiaohan Wang (Gerrit)

unread,
Sep 15, 2025, 7:38:33 PM (3 days ago) Sep 15
to Daniel Cheng, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
Attention needed from Daniel Cheng

Xiaohan Wang voted and added 2 comments

Votes added by Xiaohan Wang

Auto-Submit+1

2 comments

Patchset-level comments
File-level comment, Patchset 3:
Xiaohan Wang . unresolved

dcheng: This CL is a bit too big, and I can use "git cl split" to split it up. Do you prefer that way, or would rather this as is?

Xiaohan Wang

I looked at splitting the CL, and there are so many little folders making it non-trivial. So if you don't mind, landing it in one CL would be convenient.

File-level comment, Patchset 5 (Latest):
Xiaohan Wang . resolved

dchent: Sorry I forgot to actually add you to the CL for review. PTAL!

Other than the script doing it's job, I manually removed some EXPORTs which you can see in https://chromium-review.googlesource.com/c/chromium/src/+/6945639/4..5.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355
    Gerrit-Change-Number: 6945639
    Gerrit-PatchSet: 5
    Gerrit-Owner: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Peter Williamson <pet...@chromium.org>
    Gerrit-CC: Sean Maher <sp...@chromium.org>
    Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Sep 2025 23:38:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Xiaohan Wang <xhw...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 15, 2025, 9:06:48 PM (2 days ago) Sep 15
    to Daniel Cheng, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
    Attention needed from Xiaohan Wang

    Daniel Cheng voted and added 1 comment

    Votes added by Daniel Cheng

    Code-Review+1
    Commit-Queue+2
    Owners-Override+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Daniel Cheng . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Xiaohan Wang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355
    Gerrit-Change-Number: 6945639
    Gerrit-PatchSet: 5
    Gerrit-Owner: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Peter Williamson <pet...@chromium.org>
    Gerrit-CC: Sean Maher <sp...@chromium.org>
    Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Attention: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 01:06:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 15, 2025, 10:13:28 PM (2 days ago) Sep 15
    to Daniel Cheng, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
    Attention needed from Xiaohan Wang

    Daniel Cheng voted and added 1 comment

    Votes added by Daniel Cheng

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 3:
    Xiaohan Wang . resolved

    dcheng: This CL is a bit too big, and I can use "git cl split" to split it up. Do you prefer that way, or would rather this as is?

    Xiaohan Wang

    I looked at splitting the CL, and there are so many little folders making it non-trivial. So if you don't mind, landing it in one CL would be convenient.

    Daniel Cheng

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Xiaohan Wang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355
    Gerrit-Change-Number: 6945639
    Gerrit-PatchSet: 5
    Gerrit-Owner: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Peter Williamson <pet...@chromium.org>
    Gerrit-CC: Sean Maher <sp...@chromium.org>
    Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Attention: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 02:13:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Xiaohan Wang <xhw...@chromium.org>
    satisfied_requirement
    open
    diffy

    Xiaohan Wang (Gerrit)

    unread,
    Sep 15, 2025, 11:32:52 PM (2 days ago) Sep 15
    to Daniel Cheng, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
    Attention needed from Daniel Cheng

    Xiaohan Wang voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355
    Gerrit-Change-Number: 6945639
    Gerrit-PatchSet: 5
    Gerrit-Owner: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Xiaohan Wang <xhw...@chromium.org>
    Gerrit-CC: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Peter Williamson <pet...@chromium.org>
    Gerrit-CC: Sean Maher <sp...@chromium.org>
    Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 03:32:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Xiaohan Wang (Gerrit)

    unread,
    Sep 16, 2025, 12:32:41 AM (2 days ago) Sep 16
    to Daniel Cheng, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
    Gerrit-Comment-Date: Tue, 16 Sep 2025 04:32:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Xiaohan Wang (Gerrit)

    unread,
    Sep 16, 2025, 1:16:20 AM (2 days ago) Sep 16
    to Daniel Cheng, Alexei Svitkine, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Peter Beverloo, Peter Williamson, Sean Maher, Thiabaud Engelbrecht, alexmit...@chromium.org, alexmt...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dimich...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, gogerald+pa...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jeffreycohen+watc...@chromium.org, jkeitel+watch-...@google.com, johnyki...@google.com, jophba...@chromium.org, kaklilu+watch-...@chromium.org, language...@chromium.org, lens-chrome...@google.com, loading-rev...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mercer...@google.com, mfoltz...@chromium.org, milicau+watchlis...@google.com, minap+watch-p...@google.com, mpdento...@chromium.org, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, npnavarro+p...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, rizvis...@google.com, rlp+...@chromium.org, rouslan+au...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, subresource-f...@chromium.org, tgupta...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org

    Xiaohan Wang submitted the change

    Change information

    Commit message:
    components: Migrate BASE_FEATURE macros to 2-argument version

    This CL migrates three-argument BASE_FEATURE macros in //components to
    the new two-argument version where the C++ identifier and the string
    feature name match.

    This automated refactoring helps ensure that the C++ identifier and the
    string feature name always match, reducing potential errors.

    The following features could not be migrated automatically and may
    require manual intervention:

    * kDownloadServiceFeature vs "DownloadService"
    * Identifier has Feature suffix.

    * kDisplayInitiatorOrigin vs "DownloadsDisplayInitiatorOrigin"
    * Name has Downloads prefix.

    * kInvalidateTokenFeature vs "GCMTokenInvalidAfterDays"
    * Identifier has Feature suffix.

    * kReportingStorageDegradationFeature vs "ReportingStorageDegradation"
    * Identifier has Feature suffix.

    * kEncryptedReportingFeature vs "EncryptedReporting"
    * Identifier has Feature suffix.

    * kEnableCompose vs "Compose"
    * Identifier has Enable prefix.

    * kEnableComposeSavedStateNudge vs "ComposeNudge"
    * Identifier has Enable prefix and different name.

    * kEnableComposeProactiveNudge vs "ComposeProactiveNudge"
    * Identifier has Enable prefix.

    * kEnableComposeLanguageBypassForContextMenu vs "ComposeLanguageBypassForContextMenu"
    * Identifier has Enable prefix.

    * kEnableComposeWebUIAnimations vs "ComposeWebUIAnimations"
    * Identifier has Enable prefix.

    * kEnableNudgeForUnspecifiedHint vs "ComposeEnableNudgeForUnspecifiedHint"
    * Identifier has different name.

    * kPasswordsGrouperHeapIntegrityKillSwitch vs "PasswordsGrouperHeapIntegrityKillSwitchv2"
    * Name has v2 suffix.

    * kClearUndecryptablePasswordsOnSync vs "ClearUndecryptablePasswordsInSync"
    * on vs in.

    * kFillOnAccountSelect vs "fill-on-account-select"
    * Case and kebab-case mismatch.

    * kIOSProactivePasswordGenerationBottomSheet vs "kIOSProactivePasswordGenerationBottomSheet"
    * Name has k prefix.

    * kPasswordGenerationChunking vs "PasswordGenerationChunkPassword"
    * Chunking vs ChunkPassword.

    * kDelaySuggestionsOnAutofocusWaitingForPasskeys vs "DelaysSuggestionsOnAutofocusWaitingForPasskeys"
    * Delay vs Delays.

    * kAdSamplerTriggerFeature vs "SafeBrowsingAdSamplerTrigger"
    * Identifier has Feature suffix and name has SafeBrowsing prefix.

    * kDelayedWarnings vs "SafeBrowsingDelayedWarnings"
    * Name has SafeBrowsing prefix.

    * kExtensionTelemetryConfiguration vs "SafeBrowsingExtensionTelemetryConfiguration"
    * Name has SafeBrowsing prefix.

    * kExtensionTelemetryDeclarativeNetRequestActionSignal vs "SafeBrowsingExtensionTelemetryDeclarativeNetRequestActionSignal"
    * Name has SafeBrowsing prefix.

    * kExtensionTelemetryFileDataForCommandLineExtensions vs "SafeBrowsingExtensionTelemetryFileDataForCommandLineExtensions"
    * Name has SafeBrowsing prefix.

    * kExtensionTelemetrySearchHijackingSignal vs "SafeBrowsingExtensionTelemetrySearchHijackingSignal"
    * Name has SafeBrowsing prefix.

    * kExternalAppRedirectTelemetry vs "SafeBrowsingExternalAppRedirectTelemetry"
    * Name has SafeBrowsing prefix.

    * kGooglePlayProtectInApkTelemetry vs "SafeBrowsingGooglePlayProtectInApkTelemetry"
    * Name has SafeBrowsing prefix.

    * kGooglePlayProtectReducesWarnings vs "SafeBrowsingGooglePlayProtectReducesWarnings"
    * Name has SafeBrowsing prefix.

    * kHashPrefixRealTimeLookups vs "SafeBrowsingHashPrefixRealTimeLookups"
    * Name has SafeBrowsing prefix.

    * kHashPrefixRealTimeLookupsSamplePing vs "SafeBrowsingHashPrefixRealTimeLookupsSamplePing"
    * Name has SafeBrowsing prefix.

    * kLocalListsUseSBv5 vs "SafeBrowsingLocalListsUseSBv5"
    * Name has SafeBrowsing prefix.

    * kSuspiciousSiteTriggerQuotaFeature vs "SafeBrowsingSuspiciousSiteTriggerQuota"
    * Identifier has Feature suffix and name has SafeBrowsing prefix.

    * kThreatDomDetailsTagAndAttributeFeature vs "ThreatDomDetailsTagAttributes"
    * Identifier has Feature suffix and name has different name.

    * kConfirmSuggestionRemovals vs "ConfirmNtpSuggestionRemovals"
    * Name has Ntp prefix.

    * kRealboxCr23Theming vs "NtpRealboxCr23Theming"
    * Name has Ntp prefix.

    * kRealboxMatchSearchboxTheme vs "NtpRealboxMatchSearchboxTheme"
    * Name has Ntp prefix.

    * kRealboxUseGoogleGIcon vs "NtpRealboxUseGoogleGIcon"
    * Name has Ntp prefix.

    * kNtpTabGroupsModule vs "kNtpTabGroupsModule"
    * Name has k prefix.

    * kNtpTabGroupsModuleZeroState vs "kNtpTabGroupsModuleZeroState"
    * Name has k prefix.

    * kAndroidMediaPickerAdoption vs "MediaPickerAdoption"
    * Identifier has Android prefix.

    * kLocalWebApprovalsWidgetSupportsUrlPayload vs "PacpWidgetSupportsUrlPayload"
    * Identifier has different name.

    * kOmniboxAction vs "JourneysOmniboxAction"
    * Name has Journeys prefix.

    * kOmniboxHistoryClusterProvider vs "JourneysOmniboxHistoryClusterProvider"
    * Name has Journeys prefix.

    * kNonUserVisibleDebug vs "JourneysNonUserVisibleDebug"
    * Name has Journeys prefix.

    * kUserVisibleDebug vs "JourneysUserVisibleDebug"
    * Name has Journeys prefix.

    * kSearchesFindUngroupedVisits vs "GroupedHistorySearchesFindUngroupedVisits"
    * Name has GroupedHistory prefix.

    * kOnDeviceClustering vs "HistoryClustersOnDeviceClustering"
    * Name has HistoryClusters prefix.

    * kOnDeviceClusteringBlocklists vs "JourneysOnDeviceClusteringBlocklist"
    * Name has Journeys prefix and Blocklists vs Blocklist.

    * kOnDeviceClusteringKeywordFiltering vs "JourneysKeywordFiltering"
    * Name has Journeys prefix.

    * kOnDeviceClusteringVisitRanking vs "JourneysOnDeviceClusteringVisitRanking"
    * Name has Journeys prefix.

    * kSyntheticCapabilities vs "FeedSyntheticCapabilities"
    * Name has Feed prefix.

    * kGroupingFrameworkForNonZPS vs "OmniboxGroupingFrameworkForNonZPS"
    * Name has Omnibox prefix.

    * kMaxZeroSuggestMatches vs "OmniboxMaxZeroSuggestMatches"
    * Name has Omnibox prefix.

    * kUIExperimentMaxAutocompleteMatches vs "OmniboxUIExperimentMaxAutocompleteMatches"
    * Name has Omnibox prefix.

    * kDynamicMaxAutocomplete vs "OmniboxDynamicMaxAutocomplete"
    * Name has Omnibox prefix.

    * kFocusTriggersWebAndSRPZeroSuggest vs "OmniboxFocusTriggersWebAndSRPZeroSuggest"
    * Name has Omnibox prefix.

    * kHideSuggestionGroupHeaders vs "OmniboxHideSuggestionGroupHeaders"
    * Name has Omnibox prefix.

    * kOnDeviceHeadProviderIncognito vs "OmniboxOnDeviceHeadProviderIncognito"
    * Name has Omnibox prefix.

    * kOnDeviceHeadProviderNonIncognito vs "OmniboxOnDeviceHeadProviderNonIncognito"
    * Name has Omnibox prefix.

    * kOnDeviceTailModel vs "OmniboxOnDeviceTailModel"
    * Name has Omnibox prefix.

    * kOnDeviceTailEnableEnglishModel vs "OmniboxOnDeviceTailEnableEnglishModel"
    * Name has Omnibox prefix.

    * kDocumentProvider vs "OmniboxDocumentProvider"
    * Name has Omnibox prefix.

    * kDocumentProviderPrimaryAccountRequirement vs "OmniboxDocumentProviderPrimaryAccountRequirement"
    * Name has Omnibox prefix.

    * kDocumentProviderEnterpriseEligibility vs "OmniboxDocumentProviderEnterpriseEligibility"
    * Name has Omnibox prefix.

    * kDocumentProviderEnterpriseEligibilityWhenUnknown vs "OmniboxDocumentProviderEnterpriseEligibilityWhenUnknown"
    * Name has Omnibox prefix.

    * kDocumentProviderNoSyncRequirement vs "OmniboxDocumentProviderNoSyncRequirement"
    * Name has Omnibox prefix.

    * kShowPopupOnMouseReleased vs "OmniboxShowPopupOnMouseReleased"
    * Name has Omnibox prefix.

    * kMostVisitedTilesHorizontalRenderGroup vs "OmniboxMostVisitedTilesHorizontalRenderGroup"
    * Name has Omnibox prefix.

    * kRichAutocompletion vs "OmniboxRichAutocompletion"
    * Name has Omnibox prefix.

    * kDefaultTypedNavigationsToHttps vs "OmniboxDefaultTypedNavigationsToHttps"
    * Name has Omnibox prefix.

    * kNumNtpZpsRecentSearches vs "OmniboxNumNtpZpsRecentSearches"
    * Name has Omnibox prefix.

    * kNumNtpZpsTrendingSearches vs "OmniboxNumNtpZpsTrendingSearches"
    * Name has Omnibox prefix.

    * kNumWebZpsRecentSearches vs "OmniboxNumWebZpsRecentSearches"
    * Name has Omnibox prefix.

    * kNumWebZpsRelatedSearches vs "OmniboxNumWebZpsRelatedSearches"
    * Name has Omnibox prefix.

    * kNumWebZpsMostVisitedUrls vs "OmniboxNumWebZpsMostVisitedUrls"
    * Name has Omnibox prefix.

    * kNumSrpZpsRecentSearches vs "OmniboxNumSrpZpsRecentSearches"
    * Name has Omnibox prefix.

    * kNumSrpZpsRelatedSearches vs "OmniboxNumSrpZpsRelatedSearches"
    * Name has Omnibox prefix.

    * kMultilineEditField vs "OmniboxMultilineEditField"
    * Name has Omnibox prefix.

    * kHideAimEntrypointOnUserInput vs "OmniboxHideAimEntrypointOnUserInput"
    * Name has Omnibox prefix.

    * kDiagnostics vs "OmniboxDiagnostics"
    * Name has Omnibox prefix.

    * kUkmSamplingRateFeature vs "UkmSamplingRate"
    * Identifier has Feature suffix.

    * kAsyncCheck vs "AsyncNavigationIntercept"
    * Identifier has different name.

    * kPushNotifications vs "OptimizationGuidePushNotifications"
    * Name has OptimizationGuide prefix.

    * kPageTextExtraction vs "OptimizationGuidePageContentExtraction"
    * Name has OptimizationGuide prefix.

    * kOptimizationGuideFetchingForSRP vs "OptimizationHintsFetchingSRP"
    * Guide vs Hints.

    * kOptimizationGuidePersonalizedFetching vs "OptimizationPersonalizedHintsFetching"
    * Guide vs PersonalizedHints.

    * kPasswordChangeSubmission vs "PasswordChangeSubmissionSettingsVisibility"
    * Name has SettingsVisibility suffix.

    * kHintsBatchUpdateForActiveTabsAndTopHosts vs "OptimizationGuideHintsBatchUpdateForActiveTabsAndTopHosts"
    * Name has OptimizationGuide prefix.

    * kHintsMaxConcurrentBatchUpdateFetchesOverride vs "OptimizationGuideHintsMaxConcurrentBatchUpdateFetchesOverride"
    * Name has OptimizationGuide prefix.

    * kHintsMaxConcurrentNavigationFetchesOverride vs "OptimizationGuideHintsMaxConcurrentNavigationFetchesOverride"
    * Name has OptimizationGuide prefix.

    * kDisableStrikeSystem vs "DisableAutofillStrikeSystem"
    * Name has Autofill prefix.

    * kPriceInsightsHighPriceIos vs "PriceInsightsHighPrice"
    * Identifier has Ios suffix.

    * kLensSearchNotFoundOnPageToast vs "kLensSearchNotFoundOnPageToast"
    * Name has k prefix.

    * kEnforceNonceChecking vs "CastNonceEnforced"
    * Enforce vs Cast and Checking vs Enforced.

    * kEnforceSHA256Checking vs "CastSHA256Enforced"
    * Enforce vs Cast and Checking vs Enforced.

    * kSafeBrowsingSubresourceFilter vs "SubresourceFilter"
    * Identifier has SafeBrowsing prefix.

    * kIPHDummyGroup vs "IPH_DummyGroup"
    * Case difference.

    * kiOSFullscreenPromosGroup vs "IPH_iOSFullscreenPromosGroup"
    * Case difference.

    * kiOSDefaultBrowserPromosGroup vs "IPH_iOSDefaultBrowserPromosGroup"
    * Case difference.

    * kiOSTailoredDefaultBrowserPromosGroup vs "IPH_iOSTailoredDefaultBrowserPromosGroup"
    * Case difference.

    * kiOSTailoredNonModalDefaultBrowserPromosGroup vs "IPH_iOSTailoredNonModalDefaultBrowserPromosGroup"
    * Case difference.

    * kiOSNonModalSigninPromosGroup vs "IPH_iOSNonModalSigninPromosGroup"
    * Case difference.

    * kiOSHomepageNewBadgesGroup vs "IPH_iOSHomepageNewBadgesGroup"
    * Case difference.

    * kClankDefaultBrowserPromosGroup vs "IPH_ClankDefaultBrowserPromosGroup"
    * Case difference.

    * kIPHDemoMode vs "IPH_DemoMode"
    * Case difference.

    * kIPHDummyFeature vs "IPH_Dummy"
    * Identifier has Feature suffix.

    * kEsbDownloadRowPromoFeature vs "EsbDownloadRowPromo"
    * Identifier has Feature suffix.

    * kIPHBatterySaverModeFeature vs "IPH_BatterySaverMode"
    * Identifier has Feature suffix.

    * kIPHCompanionSidePanelFeature vs "IPH_CompanionSidePanel"
    * Identifier has Feature suffix.

    * kIPHCompanionSidePanelRegionSearchFeature vs "IPH_CompanionSidePanelRegionSearch"
    * Identifier has Feature suffix.

    * kIPHComposeMSBBSettingsFeature vs "IPH_ComposeMSBBSettingsFeature"
    * Identifier has Feature suffix.

    * kIPHComposeNewBadgeFeature vs "IPH_ComposeNewBadgeFeature"
    * Identifier has Feature suffix.

    * kIPHDesktopSharedHighlightingFeature vs "IPH_DesktopSharedHighlighting"
    * Identifier has Feature suffix.

    * kIPHDesktopCustomizeChromeFeature vs "IPH_DesktopCustomizeChrome"
    * Identifier has Feature suffix.

    * kIPHDesktopCustomizeChromeRefreshFeature vs "IPH_DesktopCustomizeChromeRefresh"
    * Identifier has Feature suffix.

    * kIPHDiscardRingFeature vs "IPH_DiscardRing"
    * Identifier has Feature suffix.

    * kIPHDownloadEsbPromoFeature vs "IPH_DownloadEsbPromo"
    * Identifier has Feature suffix.

    * kIPHExplicitBrowserSigninPreferenceRememberedFeature vs "IPH_ExplicitBrowserSigninPreferenceRemembered"
    * Identifier has Feature suffix.

    * kIPHHistorySearchFeature vs "IPH_HistorySearch"
    * Identifier has Feature suffix.

    * kIPHExtensionsMenuFeature vs "IPH_ExtensionsMenu"
    * Identifier has Feature suffix.

    * kIPHExtensionsRequestAccessButtonFeature vs "IPH_ExtensionsRequestAccessButton"
    * Identifier has Feature suffix.

    * kIPHExtensionsZeroStatePromoFeature vs "IPH_ExtensionsZeroStatePromo"
    * Identifier has Feature suffix.

    * kIPHFocusHelpBubbleScreenReaderPromoFeature vs "IPH_FocusHelpBubbleScreenReaderPromo"
    * Identifier has Feature suffix.

    * kIPHGlicPromoFeature vs "IPH_GlicPromo"
    * Identifier has Feature suffix.

    * kIPHGMCCastStartStopFeature vs "IPH_GMCCastStartStop"
    * Identifier has Feature suffix.

    * kIPHGMCLocalMediaCastingFeature vs "IPH_GMCLocalMediaCasting"
    * Identifier has Feature suffix.

    * kIPHMemorySaverModeFeature vs "IPH_HighEfficiencyMode"
    * MemorySaver vs HighEfficiency.

    * kIPHLiveCaptionFeature vs "IPH_LiveCaption"
    * Identifier has Feature suffix.

    * kIPHMerchantTrustFeature vs "IPH_MerchantTrust"
    * Identifier has Feature suffix.

    * kIPHLensOverlayFeature vs "IPH_LensOverlay"
    * Identifier has Feature suffix.

    * kIPHLensOverlayTranslateButtonFeature vs "IPH_LensOverlayTranslateButton"
    * Identifier has Feature suffix.

    * kIPHTabAudioMutingFeature vs "IPH_TabAudioMuting"
    * Identifier has Feature suffix.

    * kIPHPasswordsSavePrimingPromoFeature vs "IPH_PasswordsSavePrimingPromo"
    * Identifier has Feature suffix.

    * kIPHPasswordsSaveRecoveryPromoFeature vs "IPH_PasswordsSaveRecoveryPromo"
    * Identifier has Feature suffix.

    * kIPHPasswordsManagementBubbleAfterSaveFeature vs "IPH_PasswordsManagementBubbleAfterSave"
    * Identifier has Feature suffix.

    * kIPHPasswordsManagementBubbleDuringSigninFeature vs "IPH_PasswordsManagementBubbleDuringSignin"
    * Identifier has Feature suffix.

    * kIPHPasswordsWebAppProfileSwitchFeature vs "IPH_PasswordsWebAppProfileSwitch"
    * Identifier has Feature suffix.

    * kIPHPasswordManagerShortcutFeature vs "IPH_PasswordManagerShortcut"
    * Identifier has Feature suffix.

    * kIPHPasswordSharingFeature vs "IPH_PasswordSharingFeature"
    * Identifier has Feature suffix.

    * kIPHPdfSearchifyFeature vs "IPH_PdfSearchifyFeature"
    * Identifier has Feature suffix.

    * kIPHPerformanceInterventionDialogFeature vs "IPH_PerformanceInterventionDialogFeature"
    * Identifier has Feature suffix.

    * kIPHPlusAddressFirstSaveFeature vs "IPH_PlusAddressFirstSaveFeature"
    * Identifier has Feature suffix.

    * kIPHPowerBookmarksSidePanelFeature vs "IPH_PowerBookmarksSidePanel"
    * Identifier has Feature suffix.

    * kIPHPriceInsightsPageActionIconLabelFeature vs "IPH_PriceInsightsPageActionIconLabelFeature"
    * Identifier has Feature suffix.

    * kIPHPriceTrackingEmailConsentFeature vs "IPH_PriceTrackingEmailConsentFeature"
    * Identifier has Feature suffix.

    * kIPHPriceTrackingPageActionIconLabelFeature vs "IPH_PriceTrackingPageActionIconLabelFeature"
    * Identifier has Feature suffix.

    * kIPHReadingListDiscoveryFeature vs "IPH_ReadingListDiscovery"
    * Identifier has Feature suffix.

    * kIPHReadingListEntryPointFeature vs "IPH_ReadingListEntryPoint"
    * Identifier has Feature suffix.

    * kIPHReadingListInSidePanelFeature vs "IPH_ReadingListInSidePanel"
    * Identifier has Feature suffix.

    * kIPHReadingModeSidePanelFeature vs "IPH_ReadingModeSidePanel"
    * Identifier has Feature suffix.

    * kIPHShoppingCollectionFeature vs "IPH_ShoppingCollectionFeature"
    * Identifier has Feature suffix.

    * kIPHSideBySidePinnableFeature vs "IPH_SideBySidePinnableFeature"
    * Identifier has Feature suffix.

    * kIPHSidePanelGenericPinnableFeature vs "IPH_SidePanelGenericPinnableFeature"
    * Identifier has Feature suffix.

    * kIPHSidePanelLensOverlayPinnableFeature vs "IPH_SidePanelLensOverlayPinnableFeature"
    * Identifier has Feature suffix.

    * kIPHSidePanelLensOverlayPinnableFollowupFeature vs "IPH_SidePanelLensOverlayPinnableFollowupFeature"
    * Identifier has Feature suffix.

    * kIPHSideSearchAutoTriggeringFeature vs "IPH_SideSearchAutoTriggering"
    * Identifier has Feature suffix.

    * kIPHSideSearchPageActionLabelFeature vs "IPH_SideSearchPageActionLabel"
    * Identifier has Feature suffix.

    * kIPHSignoutWebInterceptFeature vs "IPH_SignoutWebIntercept"
    * Identifier has Feature suffix.

    * kIPHPwaQuietNotificationFeature vs "IPH_PwaQuietNotification"
    * Identifier has Feature suffix.

    * kIPHTabGroupsSaveV2IntroFeature vs "IPH_TabGroupsSaveV2Intro"
    * Identifier has Feature suffix.

    * kIPHTabGroupsSaveV2CloseGroupFeature vs "IPH_TabGroupsSaveV2CloseGroup"
    * Identifier has Feature suffix.

    * kIPHTabGroupsSharedTabChangedFeature vs "IPH_TabGroupsSharedTabChanged"
    * Identifier has Feature suffix.

    * kIPHTabGroupsSharedTabFeedbackFeature vs "IPH_TabGroupsSharedTabFeedback"
    * Identifier has Feature suffix.

    * kIPHTabOrganizationSuccessFeature vs "IPH_TabOrganizationSuccess"
    * Identifier has Feature suffix.

    * kIPHTabSearchFeature vs "IPH_TabSearch"
    * Identifier has Feature suffix.

    * kIPHTabSearchToolbarButtonFeature vs "IPH_TabSearchToolbarButton"
    * Identifier has Feature suffix.

    * kIPHDesktopSnoozeFeature vs "IPH_DesktopSnoozeFeature"
    * Identifier has Feature suffix.

    * kIPHDesktopPwaInstallFeature vs "IPH_DesktopPwaInstall"
    * Identifier has Feature suffix.

    * kIPHProfileSwitchFeature vs "IPH_ProfileSwitch"
    * Identifier has Feature suffix.

    * kIPHWebUiHelpBubbleTestFeature vs "IPH_WebUiHelpBubbleTest"
    * Identifier has Feature suffix.

    * kIPHPriceTrackingInSidePanelFeature vs "IPH_PriceTrackingInSidePanel"
    * Identifier has Feature suffix.

    * kIPHBackNavigationMenuFeature vs "IPH_BackNavigationMenu"
    * Identifier has Feature suffix.

    * kIPHAccountSettingsHistorySync vs "IPH_AccountSettingsHistorySync"
    * Identifier has Feature suffix.

    * kIPHAndroidTabDeclutter vs "IPH_AndroidTabDeclutter"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationNewTabFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_NewTab"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationOpenInBrowserFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_OpenInBrowser"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationShareFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_Share"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationVoiceSearchFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_VoiceSearch"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationTranslateFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_Translate"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationAddToBookmarksFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_AddToBookmarks"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationReadAloudFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_ReadAloud"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationPageSummaryWebFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_PageSummary_Web"
    * Identifier has Feature suffix.

    * kIPHAdaptiveButtonInTopToolbarCustomizationPageSummaryPdfFeature vs "IPH_AdaptiveButtonInTopToolbarCustomization_PageSummary_Pdf"
    * Identifier has Feature suffix.

    * kIPHPageSummaryWebMenuFeature vs "IPH_PageSummaryWebMenu"
    * Identifier has Feature suffix.

    * kIPHPageSummaryPdfMenuFeature vs "IPH_PageSummaryPdfMenu"
    * Identifier has Feature suffix.

    * kIPHAppSpecificHistory vs "IPH_AppSpecificHistory"
    * Identifier has Feature suffix.

    * kIPHAutoDarkOptOutFeature vs "IPH_AutoDarkOptOut"
    * Identifier has Feature suffix.

    * kIPHAutoDarkUserEducationMessageFeature vs "IPH_AutoDarkUserEducationMessage"
    * Identifier has Feature suffix.

    * kIPHAutoDarkUserEducationMessageOptInFeature vs "IPH_AutoDarkUserEducationMessageOptIn"
    * Identifier has Feature suffix.

    * kIPHCCTHistory vs "IPH_CCTHistory"
    * Identifier has Feature suffix.

    * kIPHCCTMinimized vs "IPH_CCTMinimized"
    * Identifier has Feature suffix.

    * kIPHContextualPageActionsQuietVariantFeature vs "IPH_ContextualPageActions_QuietVariant"
    * Identifier has Feature suffix.

    * kIPHContextualPageActionsActionChipFeature vs "IPH_ContextualPageActions_ActionChip"
    * Identifier has Feature suffix.

    * kIPHDataSaverDetailFeature vs "IPH_DataSaverDetail"
    * Identifier has Feature suffix.

    * kIPHDataSaverMilestonePromoFeature vs "IPH_DataSaverMilestonePromo"
    * Identifier has Feature suffix.

    * kIPHDataSaverPreviewFeature vs "IPH_DataSaverPreview"
    * Identifier has Feature suffix.

    * kIPHDefaultBrowserPromoMagicStackFeature vs "IPH_DefaultBrowserPromoMagicStack"
    * Identifier has Feature suffix.

    * kIPHDefaultBrowserPromoMessagesFeature vs "IPH_DefaultBrowserPromoMessages"
    * Identifier has Feature suffix.

    * kIPHDefaultBrowserPromoSettingCardFeature vs "IPH_DefaultBrowserPromoSettingCard"
    * Identifier has Feature suffix.

    * kIPHDownloadHomeFeature vs "IPH_DownloadHome"
    * Identifier has Feature suffix.

    * kIPHDownloadIndicatorFeature vs "IPH_DownloadIndicator"
    * Identifier has Feature suffix.

    * kIPHDownloadPageFeature vs "IPH_DownloadPage"
    * Identifier has Feature suffix.

    * kIPHDownloadPageScreenshotFeature vs "IPH_DownloadPageScreenshot"
    * Identifier has Feature suffix.

    * kIPHChromeHomeExpandFeature vs "IPH_ChromeHomeExpand"
    * Identifier has Feature suffix.

    * kIPHChromeHomePullToRefreshFeature vs "IPH_ChromeHomePullToRefresh"
    * Identifier has Feature suffix.

    * kIPHDownloadSettingsFeature vs "IPH_DownloadSettings"
    * Identifier has Feature suffix.

    * kIPHDownloadInfoBarDownloadContinuingFeature vs "IPH_DownloadInfoBarDownloadContinuing"
    * Identifier has Feature suffix.

    * kIPHDownloadInfoBarDownloadsAreFasterFeature vs "IPH_DownloadInfoBarDownloadsAreFaster"
    * Identifier has Feature suffix.

    * kIPHReadAloudAppMenuFeature vs "IPH_ReadAloudAppMenuFeature"
    * Identifier has Feature suffix.

    * kIPHReadAloudExpandedPlayerFeature vs "IPH_ReadAloudExpandedPlayerFeature"
    * Identifier has Feature suffix.

    * kIPHReadAloudPlaybackModeFeature vs "IPH_ReadAloudPlaybackModeFeature"
    * Identifier has Feature suffix.

    * kIPHReadLaterContextMenuFeature vs "IPH_ReadLaterContextMenu"
    * Identifier has Feature suffix.

    * kIPHReadLaterAppMenuBookmarkThisPageFeature vs "IPH_ReadLaterAppMenuBookmarkThisPage"
    * Identifier has Feature suffix.

    * kIPHReadLaterAppMenuBookmarksFeature vs "IPH_ReadLaterAppMenuBookmarks"
    * Identifier has Feature suffix.

    * kIPHReadLaterBottomSheetFeature vs "IPH_ReadLaterBottomSheet"
    * Identifier has Feature suffix.

    * kIPHRequestDesktopSiteDefaultOnFeature vs "IPH_RequestDesktopSiteDefaultOn"
    * Identifier has Feature suffix.

    * kIPHRequestDesktopSiteExceptionsGenericFeature vs "IPH_RequestDesktopSiteExceptionsGeneric"
    * Identifier has Feature suffix.

    * kIPHRequestDesktopSiteWindowSettingFeature vs "IPH_RequestDesktopSiteWindowSetting"
    * Identifier has Feature suffix.

    * kIPHRtlGestureNavigationFeature vs "IPH_RtlGestureNavigation"
    * Identifier has Feature suffix.

    * kIPHShoppingListSaveFlowFeature vs "IPH_ShoppingListSaveFlow"
    * Identifier has Feature suffix.

    * kIPHEphemeralTabFeature vs "IPH_EphemeralTab"
    * Identifier has Feature suffix.

    * kIPHFeedCardMenuFeature vs "IPH_FeedCardMenu"
    * Identifier has Feature suffix.

    * kIPHGenericAlwaysTriggerHelpUiFeature vs "IPH_GenericAlwaysTriggerHelpUiFeature"
    * Identifier has Feature suffix.

    * kIPHIdentityDiscFeature vs "IPH_IdentityDisc"
    * Identifier has Feature suffix.

    * kIPHInstanceSwitcherFeature vs "IPH_InstanceSwitcher"
    * Identifier has Feature suffix.

    * kIPHKeyboardAccessoryAddressFillingFeature vs "IPH_KeyboardAccessoryAddressFilling"
    * Identifier has Feature suffix.

    * kIPHKeyboardAccessoryBarSwipingFeature vs "IPH_KeyboardAccessoryBarSwiping"
    * Identifier has Feature suffix.

    * kIPHKeyboardAccessoryPasswordFillingFeature vs "IPH_KeyboardAccessoryPasswordFilling"
    * Identifier has Feature suffix.

    * kIPHKeyboardAccessoryPaymentFillingFeature vs "IPH_KeyboardAccessoryPaymentFilling"
    * Identifier has Feature suffix.

    * kIPHKeyboardAccessoryPaymentOfferFeature vs "IPH_KeyboardAccessoryPaymentOffer"
    * Identifier has Feature suffix.

    * kIPHLowUserEngagementDetectorFeature vs "IPH_LowUserEngagementDetector"
    * Identifier has Feature suffix.

    * kIPHMicToolbarFeature vs "IPH_MicToolbar"
    * Identifier has Feature suffix.

    * kIPHMenuAddToGroup vs "IPH_MenuAddToGroup"
    * Identifier has Feature suffix.

    * kIPHMostVisitedTilesCustomizationPinFeature vs "IPH_MostVisitedTilesCustomizationPin"
    * Identifier has Feature suffix.

    * kIPHPageInfoFeature vs "IPH_PageInfo"
    * Identifier has Feature suffix.

    * kIPHPageInfoStoreInfoFeature vs "IPH_PageInfoStoreInfo"
    * Identifier has Feature suffix.

    * kIPHPageZoomFeature vs "IPH_PageZoom"
    * Identifier has Feature suffix.

    * kIPHPdfPageDownloadFeature vs "IPH_PdfPageDownload"
    * Identifier has Feature suffix.

    * kIPHPreviewsOmniboxUIFeature vs "IPH_PreviewsOmniboxUI"
    * Identifier has Feature suffix.

    * kIPHReaderModeDistillInAppFeature vs "IPH_ReaderModeDistillInApp"
    * Identifier has Feature suffix.

    * kIPHShoppingListMenuItemFeature vs "IPH_ShoppingListMenuItem"
    * Identifier has Feature suffix.

    * kIPHTabGroupCreationDialogSyncTextFeature vs "IPH_TabGroupCreationDialogSyncText"
    * Identifier has Feature suffix.

    * kIPHTabGroupsDragAndDropFeature vs "IPH_TabGroupsDragAndDrop"
    * Identifier has Feature suffix.

    * kIPHTabGroupShareNoticeFeature vs "IPH_TabGroupShareNotice"
    * Identifier has Feature suffix.

    * kIPHTabGroupShareNotificationBubbleOnStripFeature vs "IPH_TabGroupSharedNotificationBubbleOnStrip"
    * Identifier has Feature suffix.

    * kIPHTabGroupShareUpdateFeature vs "IPH_TabGroupShareUpdate"
    * Identifier has Feature suffix.

    * kIPHTabGroupShareVersionUpdateFeature vs "IPH_TabGroupShareVersionUpdate"
    * Identifier has Feature suffix.

    * kIPHTabGroupsRemoteGroupFeature vs "IPH_TabGroupsRemoteGroup"
    * Identifier has Feature suffix.

    * kIPHTabGroupsSurfaceFeature vs "IPH_TabGroupsSurface"
    * Identifier has Feature suffix.

    * kIPHTabGroupsSurfaceOnHideFeature vs "IPH_TabGroupsSurfaceOnHide"
    * Identifier has Feature suffix.

    * kIPHTabGroupSyncOnStripFeature vs "IPH_TabGroupSyncOnStrip"
    * Identifier has Feature suffix.

    * kIPHTabSwitcherAddToGroup vs "IPH_TabSwitcherAddToGroup"
    * Identifier has Feature suffix.

    * kIPHTabSwitcherButtonFeature vs "IPH_TabSwitcherButton"
    * Identifier has Feature suffix.

    * kIPHTabSwitcherButtonSwitchIncognitoFeature vs "IPH_TabSwitcherButtonSwitchIncognito"
    * Identifier has Feature suffix.

    * kIPHTouchToSearchCalloutFeature vs "IPH_TouchToSearchCallout"
    * Identifier has Feature suffix.

    * kIPHTranslateMenuButtonFeature vs "IPH_TranslateMenuButton"
    * Identifier has Feature suffix.

    * kIPHVideoTutorialNTPChromeIntroFeature vs "IPH_VideoTutorial_NTP_ChromeIntro"
    * Identifier has Feature suffix.

    * kIPHVideoTutorialNTPDownloadFeature vs "IPH_VideoTutorial_NTP_Download"
    * Identifier has Feature suffix.

    * kIPHVideoTutorialNTPSearchFeature vs "IPH_VideoTutorial_NTP_Search"
    * Identifier has Feature suffix.

    * kIPHVideoTutorialNTPVoiceSearchFeature vs "IPH_VideoTutorial_NTP_VoiceSearch"
    * Identifier has Feature suffix.

    * kIPHVideoTutorialNTPSummaryFeature vs "IPH_VideoTutorial_NTP_Summary"
    * Identifier has Feature suffix.

    * kIPHVideoTutorialTryNowFeature vs "IPH_VideoTutorial_TryNow"
    * Identifier has Feature suffix.

    * kIPHExploreSitesTileFeature vs "IPH_ExploreSitesTile"
    * Identifier has Feature suffix.

    * kIPHFeedHeaderMenuFeature vs "IPH_FeedHeaderMenu"
    * Identifier has Feature suffix.

    * kIPHWebFeedAwarenessFeature vs "IPH_WebFeedAwareness"
    * Identifier has Feature suffix.

    * kIPHFeedSwipeRefresh vs "IPH_FeedSwipeRefresh"
    * Identifier has Feature suffix.

    * kIPHChromeReengagementNotification1Feature vs "IPH_ChromeReengagementNotification1"
    * Identifier has Feature suffix.

    * kIPHChromeReengagementNotification2Feature vs "IPH_ChromeReengagementNotification2"
    * Identifier has Feature suffix.

    * kIPHChromeReengagementNotification3Feature vs "IPH_ChromeReengagementNotification3"
    * Identifier has Feature suffix.

    * kIPHShareScreenshotFeature vs "IPH_ShareScreenshot"
    * Identifier has Feature suffix.

    * kIPHSharingHubLinkToggleFeature vs "IPH_SharingHubLinkToggle"
    * Identifier has Feature suffix.

    * kIPHWebFeedFollowFeature vs "IPH_WebFeedFollow"
    * Identifier has Feature suffix.

    * kIPHWebFeedPostFollowDialogFeature vs "IPH_WebFeedPostFollowDialog"
    * Identifier has Feature suffix.

    * kIPHWebFeedPostFollowDialogFeatureWithUIUpdate vs "IPH_WebFeedPostFollowDialogWithUIUpdate"
    * Identifier has Feature suffix.

    * kIPHSharedHighlightingBuilder vs "IPH_SharedHighlightingBuilder"
    * Identifier has Feature suffix.

    * kIPHSharedHighlightingReceiverFeature vs "IPH_SharedHighlightingReceiver"
    * Identifier has Feature suffix.

    * kIPHSharingHubWebnotesStylizeFeature vs "IPH_SharingHubWebnotesStylize"
    * Identifier has Feature suffix.

    * kIPHRestoreTabsOnFREFeature vs "IPH_RestoreTabsOnFRE"
    * Identifier has Feature suffix.

    * kIPHTabSwitcherXR vs "IPH_TabSwitcherXR"
    * Identifier has Feature suffix.

    * kIPHTabTearingXR vs "IPH_TabTearingXR"
    * Identifier has Feature suffix.

    * kIPHBottomToolbarTipFeature vs "IPH_BottomToolbarTip"
    * Identifier has Feature suffix.

    * kIPHLongPressToolbarTipFeature vs "IPH_LongPressToolbarTip"
    * Identifier has Feature suffix.

    * kIPHBadgedReaderModeFeature vs "IPH_BadgedReaderMode"
    * Identifier has Feature suffix.

    * kIPHBadgedReadingListFeature vs "IPH_BadgedReadingList"
    * Identifier has Feature suffix.

    * kIPHWhatsNewFeature vs "IPH_WhatsNew"
    * Identifier has Feature suffix.

    * kIPHWhatsNewUpdatedFeature vs "IPH_WhatsNewUpdated"
    * Identifier has Feature suffix.

    * kIPHReadingListMessagesFeature vs "IPH_ReadingListMessages"
    * Identifier has Feature suffix.

    * kIPHBadgedTranslateManualTriggerFeature vs "IPH_BadgedTranslateManualTrigger"
    * Identifier has Feature suffix.

    * kIPHDiscoverFeedHeaderFeature vs "IPH_DiscoverFeedHeaderMenu"
    * Identifier has Feature suffix.

    * kIPHDefaultSiteViewFeature vs "IPH_DefaultSiteView"
    * Identifier has Feature suffix.

    * kIPHFollowWhileBrowsingFeature vs "IPH_FollowWhileBrowsing"
    * Identifier has Feature suffix.

    * kIPHPriceNotificationsWhileBrowsingFeature vs "IPH_PriceNotificationsWhileBrowsing"
    * Identifier has Feature suffix.

    * kIPHiOSDefaultBrowserBadgeEligibilityFeature vs "IPH_iOSDefaultBrowserBadgeEligibility"
    * Identifier has Feature suffix.

    * kIPHiOSDefaultBrowserOverflowMenuBadgeFeature vs "IPH_iOSDefaultBrowserOverflowMenuBadge"
    * Identifier has Feature suffix.

    * kIPHiOSDownloadAutoDeletionFeature vs "IPH_iOSDownloadAutoDeletion"
    * Identifier has Feature suffix.

    * kIPHiOSLensKeyboardFeature vs "IPH_iOSLensKeyboard"
    * Identifier has Feature suffix.

    * kIPHiOSPromoAppStoreFeature vs "IPH_iOSPromoAppStore"
    * Identifier has Feature suffix.

    * kIPHiOSPromoWhatsNewFeature vs "IPH_iOSPromoWhatsNew"
    * Identifier has Feature suffix.

    * kIPHiOSPromoSigninFullscreenFeature vs "IPH_iOSPromoSigninFullscreen"
    * Identifier has Feature suffix.

    * kIPHiOSPromoPostRestoreFeature vs "IPH_iOSPromoPostRestore"
    * Identifier has Feature suffix.

    * kIPHiOSPromoCredentialProviderExtensionFeature vs "IPH_iOSPromoCredentialProviderExtension"
    * Identifier has Feature suffix.

    * kIPHiOSPromoDefaultBrowserReminderFeature vs "IPH_iOSPromoDefaultBrowserReminder"
    * Identifier has Feature suffix.

    * kIPHiOSHistoryOnOverflowMenuFeature vs "IPH_iOSHistoryOnOverflowMenuFeature"
    * Identifier has Feature suffix.

    * kIPHiOSPromoPostRestoreDefaultBrowserFeature vs "IPH_iOSPromoPostRestoreDefaultBrowser"
    * Identifier has Feature suffix.

    * kIPHiOSPromoNonModalUrlPasteDefaultBrowserFeature vs "IPH_iOSPromoNonModalUrlPasteDefaultBrowser"
    * Identifier has Feature suffix.

    * kIPHiOSPromoNonModalAppSwitcherDefaultBrowserFeature vs "IPH_iOSPromoNonModalAppSwitcherDefaultBrowser"
    * Identifier has Feature suffix.

    * kIPHiOSPromoNonModalShareDefaultBrowserFeature vs "IPH_iOSPromoNonModalShareDefaultBrowser"
    * Identifier has Feature suffix.

    * kIPHiOSPromoNonModalSigninPasswordFeature vs "IPH_iOSPromoNonModalSigninPassword"
    * Identifier has Feature suffix.

    * kIPHiOSPromoNonModalSigninBookmarkFeature vs "IPH_iOSPromoNonModalSigninBookmark"
    * Identifier has Feature suffix.

    * kIPHiOSPromoPasswordManagerWidgetFeature vs "IPH_iOSPromoPasswordManagerWidget"
    * Identifier has Feature suffix.

    * kIPHiOSPullToRefreshFeature vs "IPH_iOSPullToRefreshFeature"
    * Identifier has Feature suffix.

    * kIPHiOSReplaceSyncPromosWithSignInPromos vs "IPH_iOSReplaceSyncPromosWithSignInPromos"
    * Identifier has Feature suffix.

    * kIPHiOSTabGridSwipeRightForIncognito vs "IPH_iOSTabGridSwipeRightForIncognito"
    * Case difference.

    * kIPHiOSDockingPromoFeature vs "IPH_iOSDockingPromo"
    * Identifier has Feature suffix.

    * kIPHiOSDockingPromoRemindMeLaterFeature vs "IPH_iOSDockingPromoRemindMeLater"
    * Identifier has Feature suffix.

    * kIPHiOSPromoAllTabsFeature vs "IPH_iOSPromoAllTabs"
    * Identifier has Feature suffix.

    * kIPHiOSPromoMadeForIOSFeature vs "IPH_iOSPromoMadeForIOS"
    * Identifier has Feature suffix.

    * kIPHiOSPromoStaySafeFeature vs "IPH_iOSPromoStaySafe"
    * Identifier has Feature suffix.

    * kIPHiOSSwipeBackForwardFeature vs "IPH_iOSSwipeBackForward"
    * Identifier has Feature suffix.

    * kIPHiOSSwipeToolbarToChangeTabFeature vs "IPH_iOSSwipeToolbarToChangeTab"
    * Identifier has Feature suffix.

    * kIPHiOSPostDefaultAbandonmentPromoFeature vs "IPH_iOSPostDefaultAbandonmentPromo"
    * Identifier has Feature suffix.

    * kIPHiOSPromoGenericDefaultBrowserFeature vs "IPH_iOSPromoGenericDefaultBrowser"
    * Identifier has Feature suffix.

    * kIPHiOSOverflowMenuCustomizationFeature vs "IPH_iOSOverflowMenuCustomization"
    * Identifier has Feature suffix.

    * kIPHiOSPageInfoRevampFeature vs "IPH_iOSPageInfoRevamp"
    * Identifier has Feature suffix.

    * kIPHiOSInlineEnhancedSafeBrowsingPromoFeature vs "IPH_iOSInlineEnhancedSafeBrowsingPromo"
    * Identifier has Feature suffix.

    * kIPHiOSSavedTabGroupClosed vs "IPH_iOSSavedTabGroupClosed"
    * Case difference.

    * kIPHiOSContextualPanelSampleModelFeature vs "IPH_iOSContextualPanelSampleModel"
    * Identifier has Feature suffix.

    * kIPHiOSContextualPanelPriceInsightsFeature vs "IPH_iOSContextualPanelPriceInsights"
    * Identifier has Feature suffix.

    * kIPHHomeCustomizationMenuFeature vs "IPH_HomeCustomizationMenu"
    * Identifier has Feature suffix.

    * kIPHiOSLensOverlayEntrypointTipFeature vs "IPH_iOSLensOverlayEntrypointTip"
    * Identifier has Feature suffix.

    * kIPHiOSLensOverlayEscapeHatchTipFeature vs "IPH_iOSLensOverlayEscapeHatchTip"
    * Identifier has Feature suffix.

    * kIPHiOSSharedTabGroupForeground vs "IPH_iOSSharedTabGroupForeground"
    * Identifier has Feature suffix.

    * kIPHiOSDefaultBrowserBannerPromoFeature vs "IPH_iOSDefaultBrowserBannerPromoFeature"
    * Identifier has Feature suffix.

    * kIPHiOSDefaultBrowserOffCyclePromoFeature vs "IPH_iOSDefaultBrowserOffCyclePromo"
    * Identifier has Feature suffix.

    * kIPHiOSReminderNotificationsOverflowMenuBubbleFeature vs "IPH_iOSReminderNotificationsOverflowMenuBubbleFeature"
    * Identifier has Feature suffix.

    * kIPHiOSReminderNotificationsOverflowMenuNewBadgeFeature vs "IPH_iOSReminderNotificationsOverflowMenuNewBadgeFeature"
    * Identifier has Feature suffix.

    * kIPHiOSSafariImportFeature vs "IPH_iOSSafariImportFeature"
    * Case difference.

    * kIPHiOSSettingsInOverflowMenuBubbleFeature vs "IPH_iOSSettingsInOverflowMenuBubbleFeature"
    * Identifier has Feature suffix.

    * kIPHiOSSwitchAccountsWithNTPAccountParticleDiscFeature vs "IPH_iOSSwitchAccountsWithNTPAccountParticleDiscFeature"
    * Identifier has Feature suffix.

    * kIPHiOSFeedSwipeStaticFeature vs "IPH_iOSFeedSwipeStaticFeature"
    * Identifier has Feature suffix.

    * kIPHiOSFeedSwipeAnimatedFeature vs "IPH_iOSFeedSwipeAnimatedFeature"
    * Identifier has Feature suffix.

    * kIPHiOSWelcomeBackFeature vs "IPH_iOSWelcomeBack"
    * Identifier has Feature suffix.

    * kIPHIOSPageActionMenu vs "IPH_iOSPageActionMenu"
    * Case difference.

    * kIPHiOSReaderModeOptionsFeature vs "IPH_iOSReaderModeOptions"
    * Identifier has Feature suffix.

    * kIPHiOSHomepageLensNewBadge vs "IPH_iOSHomepageLensNewBadge"
    * Identifier has Feature suffix.

    * kIPHiOSHomepageCustomizationNewBadge vs "IPH_iOSHomepageCustomizationNewBadge"
    * Identifier has Feature suffix.

    * kIPHiOSOneTimeDefaultBrowserNotificationFeature vs "IPH_iOSOneTimeDefaultBrowserNotification"
    * Identifier has Feature suffix.

    * kIPHiOSAIHubNewBadge vs "IPH_iOSAIHubNewBadge"
    * Identifier has Feature suffix.

    * kIPHAutofillBnplAffirmOrZipSuggestionFeature vs "IPH_AutofillBnplAffirmOrZipSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillBnplAffirmZipOrKlarnaSuggestionFeature vs "IPH_AutofillBnplAffirmZipOrKlarnaSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillCardInfoRetrievalSuggestionFeature vs "IPH_AutofillCardInfoRetrievalSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillCreditCardBenefitFeature vs "IPH_AutofillCreditCardBenefit"
    * Identifier has Feature suffix.

    * kIPHAutofillDisabledVirtualCardSuggestionFeature vs "IPH_AutofillDisabledVirtualCardSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillExternalAccountProfileSuggestionFeature vs "IPH_AutofillExternalAccountProfileSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillHomeWorkProfileSuggestionFeature vs "IPH_AutofillHomeWorkProfileSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillAccountNameEmailSuggestionFeature vs "IPH_AutofillAccountNameEmailSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillAiOptInFeature vs "IPH_AutofillAiOptIn"
    * Identifier has Feature suffix.

    * kIPHAutofillVirtualCardCVCSuggestionFeature vs "IPH_AutofillVirtualCardCVCSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillVirtualCardSuggestionFeature vs "IPH_AutofillVirtualCardSuggestion"
    * Identifier has Feature suffix.

    * kIPHCookieControlsFeature vs "IPH_CookieControls"
    * Identifier has Feature suffix.

    * kIPHPlusAddressCreateSuggestionFeature vs "IPH_PlusAddressCreateSuggestion"
    * Identifier has Feature suffix.

    * kIPHAutofillEnableLoyaltyCardsFeature vs "IPH_AutofillEnableLoyaltyCards"
    * Identifier has Feature suffix.

    * kIPHGrowthFramework vs "IPH_GrowthFramework"
    * Identifier has Feature suffix.

    * kIPHGoogleOneOfferNotificationFeature vs "IPH_GoogleOneOfferNotification"
    * Identifier has Feature suffix.

    * kIPHLauncherSearchHelpUiFeature vs "IPH_LauncherSearchHelpUi"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedOneFeature vs "IPH_ScalableIphTimerBasedOne"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedTwoFeature vs "IPH_ScalableIphTimerBasedTwo"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedThreeFeature vs "IPH_ScalableIphTimerBasedThree"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedFourFeature vs "IPH_ScalableIphTimerBasedFour"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedFiveFeature vs "IPH_ScalableIphTimerBasedFive"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedSixFeature vs "IPH_ScalableIphTimerBasedSix"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedSevenFeature vs "IPH_ScalableIphTimerBasedSeven"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedEightFeature vs "IPH_ScalableIphTimerBasedEight"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedNineFeature vs "IPH_ScalableIphTimerBasedNine"
    * Identifier has Feature suffix.

    * kIPHScalableIphTimerBasedTenFeature vs "IPH_ScalableIphTimerBasedTen"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedOneFeature vs "IPH_ScalableIphUnlockedBasedOne"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedTwoFeature vs "IPH_ScalableIphUnlockedBasedTwo"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedThreeFeature vs "IPH_ScalableIphUnlockedBasedThree"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedFourFeature vs "IPH_ScalableIphUnlockedBasedFour"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedFiveFeature vs "IPH_ScalableIphUnlockedBasedFive"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedSixFeature vs "IPH_ScalableIphUnlockedBasedSix"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedSevenFeature vs "IPH_ScalableIphUnlockedBasedSeven"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedEightFeature vs "IPH_ScalableIphUnlockedBasedEight"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedNineFeature vs "IPH_ScalableIphUnlockedBasedNine"
    * Identifier has Feature suffix.

    * kIPHScalableIphUnlockedBasedTenFeature vs "IPH_ScalableIphUnlockedBasedTen"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedNudgeFeature vs "IPH_ScalableIphHelpAppBasedNudge"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedOneFeature vs "IPH_ScalableIphHelpAppBasedOne"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedTwoFeature vs "IPH_ScalableIphHelpAppBasedTwo"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedThreeFeature vs "IPH_ScalableIphHelpAppBasedThree"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedFourFeature vs "IPH_ScalableIphHelpAppBasedFour"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedFiveFeature vs "IPH_ScalableIphHelpAppBasedFive"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedSixFeature vs "IPH_ScalableIphHelpAppBasedSix"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedSevenFeature vs "IPH_ScalableIphHelpAppBasedSeven"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedEightFeature vs "IPH_ScalableIphHelpAppBasedEight"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedNineFeature vs "IPH_ScalableIphHelpAppBasedNine"
    * Identifier has Feature suffix.

    * kIPHScalableIphHelpAppBasedTenFeature vs "IPH_ScalableIphHelpAppBasedTen"
    * Identifier has Feature suffix.

    * kIPHScalableIphGamingFeature vs "IPH_ScalableIphGaming"
    * Identifier has Feature suffix.

    * kIPHDesktopPWAsLinkCapturingLaunch vs "IPH_DesktopPWAsLinkCapturingLaunch"
    * Identifier has Feature suffix.

    * kIPHDesktopPWAsLinkCapturingLaunchAppInTab vs "IPH_DesktopPWAsLinkCapturingLaunchAppInTab"
    * Identifier has Feature suffix.

    * kIPHSupervisedUserProfileSigninFeature vs "IPH_SupervisedUserProfileSignin"
    * Identifier has Feature suffix.

    * kIPHiOSPasswordPromoDesktopFeature vs "IPH_iOSPasswordPromoDesktop"
    * Identifier has Feature suffix.

    * kIPHiOSAddressPromoDesktopFeature vs "IPH_iOSAddressPromoDesktop"
    * Identifier has Feature suffix.

    * kIPHiOSPaymentPromoDesktopFeature vs "IPH_iOSPaymentPromoDesktop"
    * Identifier has Feature suffix.

    * kIPHiOSLensPromoDesktopFeature vs "IPH_iOSLensPromoDesktop"
    * Identifier has Feature suffix.

    * kIPHiOSEnhancedBrowsingDesktopFeature vs "IPH_iOSEnhancedBrowsingDesktop"
    * Case difference.

    * kCctAutoTranslate vs "CCTAutoTranslate"
    * Case difference.

    * kEnableZstd vs "EnableZstdV2"
    * Name has V2 suffix.

    * kLogMe vs "CronetLogMe"
    * Name has Cronet prefix.

    * kWindowsMemoryPressurePeriod vs "WinMemoryPressurePeriod"
    * Windows vs Win.

    * kOfflinePagesInDownloadHomeOpenInCctFeature vs "OfflinePagesInDownloadHomeOpenInCct"
    * Identifier has Feature suffix.

    * kStructuredMetrics vs "EnableStructuredMetrics"
    * Name has Enable prefix.

    * kExpiredHistogramLogicFeature vs "ExpiredHistogramLogic"
    * Identifier has Feature suffix.

    * kPersistentHistogramsFeature vs "PersistentHistograms"
    * Identifier has Feature suffix.

    * kUseUserDefaultsForExitedCleanlyBeacon vs "UseUserDefaultsForExitedCleanlyBeaconEnabler"
    * Name has Enabler suffix.

    * kPseudoMetricsEffectFeature vs "UMAPseudoMetricsEffect"
    * Name has UMA prefix.

    * kCARenderer vs "CoreAnimationRenderer"
    * CA vs CoreAnimation.

    * kHDRUnderlays vs "CoreAnimationHDRUnderlays"
    * Name has CoreAnimation prefix.

    * kWebAuthnAndroidPasskeyCacheMigration vs "WebAuthenticationAndroidPasskeyCacheMigration"
    * WebAuthn vs WebAuthentication.

    * kCrosSystemLevelPermissionBlockedWarnings vs "CrosBlockWarnings"
    * SystemLevelPermissionBlocked vs Block.

    * kFlushAfterAppending vs "SessionStorageFlushAfterAppendingCommands"
    * Name has SessionStorage prefix and Commands suffix.

    * kUseFinchPermanentCountryForFetchCountryId vs "UseFinchPermanentCountyForFetchCountryId"
    * Country vs County.

    * kSiteIsolationForPasswordSites vs "site-isolation-for-password-sites"
    * Case and kebab-case mismatch.

    * kSiteIsolationMemoryThresholdsAndroid vs "SiteIsolationMemoryThresholds"
    * Identifier has Android suffix.

    * kDataSharingFeature vs "DataSharing"
    * Identifier has Feature suffix.

    * kSegmentationPlatformFeature vs "SegmentationPlatform"
    * Identifier has Feature suffix.

    * kResumeHeavyUserSegmentFeature vs "ResumeHeavyUserSegment"
    * Identifier has Feature suffix.

    * kUIDebugToolsEnableSyntheticEvents vs "ui-debug-tools-enable-synthetic-events"
    * Case and kebab-case mismatch.

    * kPopularSitesBakedInContentFeature vs "NTPPopularSitesBakedInContent"
    * Name has NTP prefix.

    * kNtpMostLikelyFaviconsFromServerFeature vs "NTPMostLikelyFaviconsFromServer"
    * Identifier has Feature suffix.

    * kNtpEnterpriseShortcuts vs "NTPEnterpriseShortcuts"
    * Identifier has Feature suffix.

    Enabled-by-default-reason: refactor
    NO_IFTTT=refactor; no functionality change
    Bug: 436274260
    Change-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355
    Owners-Override: Daniel Cheng <dch...@chromium.org>
    Commit-Queue: Xiaohan Wang <xhw...@chromium.org>
    Auto-Submit: Xiaohan Wang <xhw...@chromium.org>
    Reviewed-by: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1515845}
    Files:
    • M components/affiliations/core/browser/affiliation_backend.cc
    • M components/aggregation_service/features.cc
    • M components/android_autofill/browser/android_autofill_features.cc
    • M components/app_launch_prefetch/app_launch_prefetch.cc
    • M components/app_restore/features.cc
    • M components/assist_ranker/predictor_config_definitions.cc
    • M components/attribution_reporting/features.cc
    • M components/autofill/core/common/autofill_features.cc
    • M components/autofill/core/common/autofill_payments_features.cc
    • M components/autofill/ios/common/features.mm
    • M components/blocked_content/safe_browsing_triggered_popup_blocker.cc
    • M components/bookmarks/common/bookmark_features.cc
    • M components/browser_sync/browser_sync_switches.cc
    • M components/browser_ui/contacts_picker/android/features.cc
    • M components/browser_ui/modaldialog/android/features.cc
    • M components/browser_ui/notifications/android/features.cc
    • M components/browsing_data/core/features.cc
    • M components/captive_portal/core/features.cc
    • M components/collaboration/public/features.cc
    • M components/commerce/core/commerce_feature_list.cc
    • M components/compose/core/browser/compose_features.cc
    • M components/content_settings/core/common/features.cc
    • M components/contextual_search/core/browser/contextual_search_field_trial.cc
    • M components/continuous_search/renderer/config.cc
    • M components/crash/content/browser/child_exit_observer_android.cc
    • M components/credential_management/android/features.cc
    • M components/cronet/url_request_context_config.cc
    • M components/cross_device/nearby/nearby_features.cc
    • M components/custom_handlers/protocol_handler.cc
    • M components/data_sharing/public/features.cc
    • M components/device_signals/core/common/signals_features.cc
    • M components/dom_distiller/core/dom_distiller_features.cc
    • M components/download/public/background_service/features.cc
    • M components/download/public/common/download_features.cc
    • M components/embedder_support/android/util/features.cc
    • M components/embedder_support/android/util/input_stream.cc
    • M components/embedder_support/origin_trials/features.cc
    • M components/enterprise/client_certificates/core/features.cc
    • M components/enterprise/connectors/core/features.cc
    • M components/enterprise/data_controls/core/browser/features.cc
    • M components/enterprise/obfuscation/core/utils.cc
    • M components/exo/buffer.cc
    • M components/exo/surface.cc
    • M components/external_intents/android/external_intents_features.cc
    • M components/eye_dropper/features.cc
    • M components/facilitated_payments/core/features/features.cc
    • M components/favicon/core/large_icon_worker.cc
    • M components/feature_engagement/public/feature_constants.cc
    • M components/feed/feed_feature_list.cc
    • M components/feedback/features.cc
    • M components/feedback/redaction_tool/redaction_tool.cc
    • M components/fingerprinting_protection_filter/common/fingerprinting_protection_filter_features.cc
    • M components/fingerprinting_protection_filter/interventions/common/interventions_features.cc
    • M components/fullscreen_control/fullscreen_features.cc
    • M components/google/core/common/google_util.cc
    • M components/gwp_asan/client/gwp_asan.cc
    • M components/gwp_asan/client/gwp_asan_features.cc
    • M components/heap_profiling/in_process/heap_profiler_parameters.cc
    • M components/heavy_ad_intervention/heavy_ad_features.cc
    • M components/history/core/browser/features.cc
    • M components/history_clusters/core/features.cc
    • M components/history_embeddings/history_embeddings_features.cc
    • M components/input/features.cc
    • M components/js_injection/browser/navigation_web_message_sender.cc
    • M components/js_injection/renderer/js_communication.cc
    • M components/language/core/common/language_experiments.cc
    • M components/language_detection/core/features.cc
    • M components/language_detection/core/language_detection_provider.cc
    • M components/lens/lens_features.cc
    • M components/leveldb_proto/internal/leveldb_proto_feature_list.cc
    • M components/live_caption/views/caption_bubble_model.cc
    • M components/manta/features.cc
    • M components/media_device_salt/media_device_salt_service.cc
    • M components/memory_pressure/multi_source_memory_pressure_monitor.cc
    • M components/memory_pressure/system_memory_pressure_evaluator_mac.cc
    • M components/memory_pressure/system_memory_pressure_evaluator_win.cc
    • M components/memory_system/memory_system_features.cc
    • M components/messages/android/messages_feature.cc
    • M components/metal_util/hdr_copier_layer.mm
    • M components/metrics/call_stacks/call_stack_profile_metrics_provider.cc
    • M components/metrics/dwa/dwa_recorder.cc
    • M components/metrics/metrics_features.cc
    • M components/metrics/structured/structured_metrics_features.cc
    • M components/mirroring/service/mirroring_features.cc
    • M components/network_time/network_time_tracker.cc
    • M components/no_state_prefetch/browser/no_state_prefetch_field_trial.cc
    • M components/offline_pages/core/offline_page_feature.cc
    • M components/omnibox/browser/aim_eligibility_service.cc
    • M components/omnibox/browser/aim_eligibility_service_features.cc
    • M components/omnibox/common/omnibox_features.cc
    • M components/open_from_clipboard/clipboard_recent_content_features.cc
    • M components/optimization_guide/core/feature_registry/feature_registration.cc
    • M components/optimization_guide/core/model_execution/model_execution_features.cc
    • M components/optimization_guide/core/model_execution/on_device_model_validator.cc
    • M components/optimization_guide/core/model_execution/performance_class.cc
    • M components/optimization_guide/core/optimization_guide_features.cc
    • M components/ownership/owner_settings_service.cc
    • M components/page_content_annotations/core/page_content_annotations_features.cc
    • M components/page_image_service/features.cc
    • M components/page_info/core/features.cc
    • M components/page_load_metrics/browser/features.cc
    • M components/page_load_metrics/renderer/features.cc
    • M components/paint_preview/features/features.cc
    • M components/passage_embeddings/passage_embeddings_features.cc
    • M components/password_manager/core/browser/features/password_features.cc
    • M components/password_manager/core/common/password_manager_features.cc
    • M components/password_manager/ios/features.mm
    • M components/payments/content/android/payment_feature_map.cc
    • M components/payments/core/features.cc
    • M components/performance_manager/features.cc
    • M components/permissions/android/permissions_android_feature_map.cc
    • M components/permissions/features.cc
    • M components/plus_addresses/core/common/features.cc
    • M components/policy/core/browser/gen_ai_default_settings_policy_handler.cc
    • M components/policy/core/common/cloud/cloud_policy_client.cc
    • M components/policy/core/common/cloud/cloud_policy_manager.cc
    • M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc
    • M components/policy/core/common/cloud/machine_level_user_cloud_policy_store.cc
    • M components/policy/core/common/cloud/realtime_reporting_job_configuration.cc
    • M components/policy/core/common/features.cc
    • M components/power_bookmarks/core/power_bookmark_features.cc
    • M components/private_inference/features.cc
    • M components/push_messaging/push_messaging_features.cc
    • M components/regional_capabilities/regional_capabilities_switches.cc
    • M components/remote_cocoa/app_shim/features.cc
    • M components/reporting/util/disconnectable_client.cc
    • M components/safe_browsing/core/common/features.cc
    • M components/safe_browsing/ios/browser/web_ui/features.mm
    • M components/saved_tab_groups/public/features.cc
    • M components/search/ntp_features.cc
    • M components/search_engines/search_engines_switches.cc
    • M components/security_interstitials/content/ssl_error_handler.cc
    • M components/security_interstitials/core/features.cc
    • M components/segmentation_platform/embedder/default_model/chrome_user_engagement.cc
    • M components/segmentation_platform/embedder/default_model/ios_default_browser_promo.cc
    • M components/segmentation_platform/embedder/default_model/most_visited_tiles_user.cc
    • M components/segmentation_platform/embedder/default_model/optimization_target_segmentation_dummy.cc
    • M components/segmentation_platform/internal/database/signal_database_impl.cc
    • M components/segmentation_platform/internal/execution/processing/sync_device_info_observer.cc
    • M components/segmentation_platform/internal/signals/signal_handler.cc
    • M components/segmentation_platform/public/features.cc
    • M components/send_tab_to_self/features.cc
    • M components/sensitive_content/features.cc
    • M components/services/app_service/public/cpp/features.cc
    • M components/services/storage/dom_storage/features.cc
    • M components/shared_highlighting/core/common/shared_highlighting_features.cc
    • M components/sharing_message/features.cc
    • M components/sharing_message/sharing_fcm_sender.cc
    • M components/signin/internal/identity_manager/primary_account_manager.cc
    • M components/signin/public/base/signin_switches.cc
    • M components/signin/public/identity_manager/access_token_fetcher.cc
    • M components/site_isolation/features.cc
    • M components/soda/soda_features.cc
    • M components/spellcheck/common/spellcheck_features.cc
    • M components/stylus_handwriting/android/stylus_handwriting_feature_map.cc
    • M components/stylus_handwriting/win/features.cc
    • M components/subresource_filter/content/browser/safe_browsing_child_navigation_throttle.cc
    • M components/subresource_filter/core/browser/subresource_filter_features.cc
    • M components/subresource_filter/core/common/common_features.cc
    • M components/supervised_user/core/browser/fetcher_config.cc
    • M components/supervised_user/core/common/features.cc
    • M components/sync/base/features.cc
    • M components/sync/engine/backoff_delay_provider.cc
    • M components/sync/engine/commit_contribution_impl.cc
    • M components/sync/nigori/nigori_state.cc
    • M components/sync/service/sync_service_impl.cc
    • M components/sync_bookmarks/switches.cc
    • M components/sync_preferences/features.cc
    • M components/sync_sessions/features.cc
    • M components/tracing/common/etw_export_win.cc
    • M components/tracing/common/tracing_scenarios_config.cc
    • M components/translate/core/browser/translate_infobar_delegate.cc
    • M components/translate/core/browser/translate_prefs.cc
    • M components/translate/core/browser/translate_ranker_impl.cc
    • M components/translate/core/common/translate_util.cc
    • M components/trusted_vault/features.cc
    • M components/unexportable_keys/features.cc
    • M components/user_education/common/user_education_features.cc
    • M components/variations/fake_crash.cc
    • M components/variations/net/variations_command_line.cc
    • M components/variations/service/variations_field_trial_creator.cc
    • M components/variations/synthetic_trial_registry.cc
    • M components/visited_url_ranking/public/features.cc
    • M components/viz/common/features.cc
    • M components/viz/service/display/overlay_processor_surface_control.cc
    • M components/viz/service/display/skia_renderer.cc
    • M components/viz/service/display_embedder/skia_output_device_buffer_queue.cc
    • M components/viz/service/frame_sinks/external_begin_frame_source_mac.cc
    • M components/viz/service/frame_sinks/external_begin_frame_source_win.cc
    • M components/wallet/core/common/wallet_features.cc
    • M components/webapps/browser/features.cc
    • M components/webapps/isolated_web_apps/features.cc
    • M components/webauthn/ios/features.mm
    • M components/webcrypto/webcrypto_impl.cc
    • M components/webdata/common/web_database.cc
    Change size: XL
    Delta: 195 files changed, 560 insertions(+), 2194 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Daniel Cheng
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f73ba5f7d552815f81a737b82441cfc3ea16355
    Gerrit-Change-Number: 6945639
    Gerrit-PatchSet: 6
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages