Log connection timing in FromGwsAbandonedPageLoadMetricsObserver UKM. [chromium/src : main]
0 views
Skip to first unread message
Keita Suzuki (Gerrit)
Dec 15, 2025, 7:01:01 PM (yesterday) Dec 15
to Shunya Shishido, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Robert Kaplow and Shunya Shishido
Keita Suzuki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Robert Kaplow
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Kaplow (Gerrit)
9:51 AM (12 hours ago) 9:51 AM
to Keita Suzuki, Shunya Shishido, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Keita Suzuki and Shunya Shishido
Robert Kaplow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Keita Suzuki
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shunya Shishido (Gerrit)
8:29 PM (2 hours ago) 8:29 PM
to Keita Suzuki, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Keita Suzuki
Shunya Shishido voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Keita Suzuki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keita Suzuki (Gerrit)
8:34 PM (2 hours ago) 8:34 PM
to Shunya Shishido, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Keita Suzuki voted and added 1 comment![]( "Open in Gerrit")
Votes added by Keita Suzuki
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:30 PM (1 hour ago) 9:30 PM
to Keita Suzuki, Shunya Shishido, Robert Kaplow, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Log connection timing in FromGwsAbandonedPageLoadMetricsObserver UKM.
Expose the latest NavigationHandleTiming via a getter in
AbandonedPageLoadMetricsObserver and use it in
FromGwsAbandonedPageLoadMetricsObserver::OnComplete to record first
request connect, domain lookup, and SSL delays to UKM.
Doc (internal):
https://docs.google.com/document/d/1YI6hD_tAZU4JCtu_nuappEsXb_SSW8AVOhKvrrvHBso/edit?tab=t.0
Bug: 465631851
Change-Id: Iefefd17d62223a137f50ad551f9b62651b2f63b1
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Commit-Queue: Keita Suzuki <suzuk...@chromium.org>
Reviewed-by: Shunya Shishido <sisid...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1559692}
Files:
- M components/page_load_metrics/browser/observers/abandoned_page_load_metrics_observer.h
- M components/page_load_metrics/google/browser/from_gws_abandoned_page_load_metrics_observer.cc
- M tools/metrics/ukm/ukm.xml
Change size: S
Delta: 3 files changed, 34 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Shunya Shishido, +1 by Robert Kaplow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages