Log connection timing in FromGwsAbandonedPageLoadMetricsObserver UKM. [chromium/src : main]

0 views
Skip to first unread message

Keita Suzuki (Gerrit)

unread,
Dec 15, 2025, 7:01:01 PM (yesterday) Dec 15
to Shunya Shishido, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Robert Kaplow and Shunya Shishido

Keita Suzuki added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Keita Suzuki . resolved

PTAL. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Robert Kaplow
  • Shunya Shishido
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iefefd17d62223a137f50ad551f9b62651b2f63b1
Gerrit-Change-Number: 7221292
Gerrit-PatchSet: 1
Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Robert Kaplow <rka...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Robert Kaplow <rka...@chromium.org>
Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 00:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Robert Kaplow (Gerrit)

unread,
9:51 AM (12 hours ago) 9:51 AM
to Keita Suzuki, Shunya Shishido, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Keita Suzuki and Shunya Shishido

Robert Kaplow voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keita Suzuki
  • Shunya Shishido
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iefefd17d62223a137f50ad551f9b62651b2f63b1
    Gerrit-Change-Number: 7221292
    Gerrit-PatchSet: 1
    Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Robert Kaplow <rka...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Attention: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Dec 2025 14:50:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Shunya Shishido (Gerrit)

    unread,
    8:29 PM (2 hours ago) 8:29 PM
    to Keita Suzuki, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
    Attention needed from Keita Suzuki

    Shunya Shishido voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keita Suzuki
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iefefd17d62223a137f50ad551f9b62651b2f63b1
    Gerrit-Change-Number: 7221292
    Gerrit-PatchSet: 1
    Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Robert Kaplow <rka...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Dec 2025 01:28:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Keita Suzuki (Gerrit)

    unread,
    8:34 PM (2 hours ago) 8:34 PM
    to Shunya Shishido, Robert Kaplow, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org

    Keita Suzuki voted and added 1 comment

    Votes added by Keita Suzuki

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Keita Suzuki . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iefefd17d62223a137f50ad551f9b62651b2f63b1
    Gerrit-Change-Number: 7221292
    Gerrit-PatchSet: 1
    Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Robert Kaplow <rka...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Wed, 17 Dec 2025 01:33:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    9:30 PM (1 hour ago) 9:30 PM
    to Keita Suzuki, Shunya Shishido, Robert Kaplow, Chromium Metrics Reviews, AyeAye, bmcquad...@chromium.org, suzukike...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Log connection timing in FromGwsAbandonedPageLoadMetricsObserver UKM.

    Expose the latest NavigationHandleTiming via a getter in
    AbandonedPageLoadMetricsObserver and use it in
    FromGwsAbandonedPageLoadMetricsObserver::OnComplete to record first
    request connect, domain lookup, and SSL delays to UKM.

    Doc (internal):
    https://docs.google.com/document/d/1YI6hD_tAZU4JCtu_nuappEsXb_SSW8AVOhKvrrvHBso/edit?tab=t.0
    Bug: 465631851
    Change-Id: Iefefd17d62223a137f50ad551f9b62651b2f63b1
    Reviewed-by: Robert Kaplow <rka...@chromium.org>
    Commit-Queue: Keita Suzuki <suzuk...@chromium.org>
    Reviewed-by: Shunya Shishido <sisid...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1559692}
    Files:
    • M components/page_load_metrics/browser/observers/abandoned_page_load_metrics_observer.h
    • M components/page_load_metrics/google/browser/from_gws_abandoned_page_load_metrics_observer.cc
    • M tools/metrics/ukm/ukm.xml
    Change size: S
    Delta: 3 files changed, 34 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Shunya Shishido, +1 by Robert Kaplow
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iefefd17d62223a137f50ad551f9b62651b2f63b1
    Gerrit-Change-Number: 7221292
    Gerrit-PatchSet: 2
    Gerrit-Owner: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Robert Kaplow <rka...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages