Fix flakiness of InlineScriptCache browsertests [chromium/src : main]
0 views
Skip to first unread message
Takashi Nakayama (Gerrit)
Jun 28, 2026, 12:20:01 PM (11 days ago) Jun 28
to Kouhei Ueno, Hiroshige Hayashizaki, Peter Beverloo, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, loading-re...@chromium.org, kinuko...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, alexmo...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, navigation...@chromium.org, webap...@microsoft.com
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno
Takashi Nakayama added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 14 (Latest):
Takashi Nakayama . resolved
@kou...@chromium.org @hiro...@chromium.org Could you review this CL? The previous MegaCQ failed for some builders, but I believe these are not due to the current change.
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Jul 8, 2026, 10:09:06 PM (6 hours ago) Jul 8
to Takashi Nakayama, Hiroshige Hayashizaki, Peter Beverloo, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, loading-re...@chromium.org, kinuko...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, alexmo...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, navigation...@chromium.org, webap...@microsoft.com
Attention needed from Hiroshige Hayashizaki and Takashi Nakayama
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hiroshige Hayashizaki
- Takashi Nakayama
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Nakayama (Gerrit)
Jul 8, 2026, 10:23:13 PM (6 hours ago) Jul 8
to Rakina Zata Amni, Chromium IPC Reviews, Martin Šrámek, Hiroshige Hayashizaki, Kouhei Ueno, Peter Beverloo, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, loading-re...@chromium.org, kinuko...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, alexmo...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, navigation...@chromium.org, webap...@microsoft.com
Attention needed from Chromium IPC Reviews, Hiroshige Hayashizaki, Martin Šrámek and Rakina Zata Amni
Takashi Nakayama added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 17 (Latest):
Takashi Nakayama . unresolved
@reviewers Could you please review this CL? This CL has apparently failing tests, but those are because I ran Mega-CQ just in case, and some other existing flaky tests failed.
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Hiroshige Hayashizaki
- Martin Šrámek
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jul 8, 2026, 10:25:27 PM (6 hours ago) Jul 8
to Takashi Nakayama, Chromium IPC Reviews, Hidehiko Abe, Rakina Zata Amni, Martin Šrámek, Hiroshige Hayashizaki, Kouhei Ueno, Peter Beverloo, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, loading-re...@chromium.org, kinuko...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, alexmo...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, navigation...@chromium.org, webap...@microsoft.com
Attention needed from Hidehiko Abe, Hiroshige Hayashizaki, Martin Šrámek and Rakina Zata Amni
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: hide...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): hide...@chromium.org
Reviewer source(s):
hide...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Hidehiko Abe
- Hiroshige Hayashizaki
- Martin Šrámek
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Šrámek (Gerrit)
1:29 AM (3 hours ago) 1:29 AM
to Takashi Nakayama, Chromium IPC Reviews, Hidehiko Abe, Rakina Zata Amni, Hiroshige Hayashizaki, Kouhei Ueno, Peter Beverloo, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, loading-re...@chromium.org, kinuko...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, alexmo...@chromium.org, asvitki...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mgiuca...@chromium.org, navigation...@chromium.org, webap...@microsoft.com
Attention needed from Hidehiko Abe, Hiroshige Hayashizaki, Rakina Zata Amni and Takashi Nakayama
Martin Šrámek voted and added 1 comment![]( "Open in Gerrit")
Votes added by Martin Šrámek
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Hidehiko Abe
- Hiroshige Hayashizaki
- Rakina Zata Amni
- Takashi Nakayama
Reply all
Reply to author
Forward
0 new messages