Fix meta refresh to fragment to use same-document navigation [chromium/src : main]

[Yoav Weiss (@Shopify) (Gerrit)]

Attention needed from Helmut Januschka and Nate Chapin

Yoav Weiss (@Shopify) added 1 comment

File third_party/blink/renderer/core/loader/http_refresh_scheduler.cc

Line 105, Patchset 5 (Latest): // Per HTML spec: If the refresh URL differs from the current document URL

Yoav Weiss (@Shopify) . unresolved

Are the other steps of https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate run before this function is called? (IIUC, this is implementing step 14)

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Nate Chapin

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a17aa73cc98fdd94370f6bd6c0bc8e23f32ec5e

Gerrit-Change-Number: 7080976

Gerrit-PatchSet: 5

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Nate Chapin <jap...@chromium.org>

Gerrit-Comment-Date: Mon, 03 Nov 2025 09:33:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nate Chapin (Gerrit)]

Attention needed from Helmut Januschka

Nate Chapin added 1 comment

File third_party/blink/renderer/core/loader/http_refresh_scheduler.cc

Line 149, Patchset 5 (Latest): load_type = WebFrameLoadType::kReload;

Nate Chapin . unresolved

Rather than adding a branch and calling `CommitSameDocumentNavigation` directly here, I think we should change the load type here. `FrameLoader::StartNavigation` will decide whether the navigation should be same-document or cross-document (here: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/frame_loader.cc;drc=35d26d364efb57d0386b98312ba739f7f65ae97e;l=1540). Howeveer, setting a WebFrameLoadType of kReload will ensure the navigation is always cross-document.

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a17aa73cc98fdd94370f6bd6c0bc8e23f32ec5e

Gerrit-Change-Number: 7080976

Gerrit-PatchSet: 5

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Comment-Date: Mon, 03 Nov 2025 19:27:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Helmut Januschka (Gerrit)]

Attention needed from Nate Chapin and Yoav Weiss (@Shopify)

Helmut Januschka added 2 comments

File third_party/blink/renderer/core/loader/http_refresh_scheduler.cc

Line 105, Patchset 5: // Per HTML spec: If the refresh URL differs from the current document URL

Yoav Weiss (@Shopify) . resolved

Are the other steps of https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate run before this function is called? (IIUC, this is implementing step 14)

Helmut Januschka

the new approach makes this change here obsolete 😊

Line 149, Patchset 5: load_type = WebFrameLoadType::kReload;

Nate Chapin . resolved

Rather than adding a branch and calling `CommitSameDocumentNavigation` directly here, I think we should change the load type here. `FrameLoader::StartNavigation` will decide whether the navigation should be same-document or cross-document (here: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/frame_loader.cc;drc=35d26d364efb57d0386b98312ba739f7f65ae97e;l=1540). Howeveer, setting a WebFrameLoadType of kReload will ensure the navigation is always cross-document.

Helmut Januschka

wow,thanks nate, that is so much cleaner now - i love code review!

Open in Gerrit

Related details

Attention is currently required from:

• Nate Chapin
• Yoav Weiss (@Shopify)

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9a17aa73cc98fdd94370f6bd6c0bc8e23f32ec5e

Gerrit-Change-Number: 7080976

Gerrit-PatchSet: 6

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-Attention: Nate Chapin <jap...@chromium.org>

Gerrit-Comment-Date: Tue, 04 Nov 2025 10:09:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Comment-In-Reply-To: Nate Chapin <jap...@chromium.org>