Use HttpRequestHeadersUpdateParams in NavigationURLLoader::FollowRedirect [chromium/src : main]
0 views
Skip to first unread message
Kenichi Ishibashi (Gerrit)
May 14, 2026, 12:20:12 AM (6 days ago) May 14
to Hiroshige Hayashizaki, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Hiroshige Hayashizaki
Kenichi Ishibashi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 14, 2026, 5:57:47 PM (5 days ago) May 14
to Rakina Zata Amni, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Rakina Zata Amni
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 13 (Latest):
Hiroshige Hayashizaki . resolved
+rakina for content OWNER review.
Related details
Attention is currently required from:
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
May 15, 2026, 1:49:11 AM (5 days ago) May 15
to Hiroshige Hayashizaki, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Hiroshige Hayashizaki
Rakina Zata Amni voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hiroshige Hayashizaki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 19, 2026, 12:45:54 AM (yesterday) May 19
to Rakina Zata Amni, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Hiroshige Hayashizaki voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 19, 2026, 3:37:46 AM (24 hours ago) May 19
to Hiroshige Hayashizaki, Rakina Zata Amni, Kenichi Ishibashi, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
13 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: content/browser/webui/initial_webui_navigation_url_loader.cc
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Use HttpRequestHeadersUpdateParams in NavigationURLLoader::FollowRedirect
Follow-up of https://crrev.com/c/7835601 that introduced
`network::HttpRequestHeadersUpdateParams`.
This CL shouldn't change the behavior.
Bug: 511306597, 434292502
Change-Id: I59e74aab37ce2e2a3d28c273f8278782fc73ffca
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1632672}
Files:
- M content/browser/loader/cached_navigation_url_loader.cc
- M content/browser/loader/cached_navigation_url_loader.h
- M content/browser/loader/navigation_url_loader.h
- M content/browser/loader/navigation_url_loader_impl.cc
- M content/browser/loader/navigation_url_loader_impl.h
- M content/browser/loader/navigation_url_loader_impl_unittest.cc
- M content/browser/renderer_host/navigation_request.cc
- M content/browser/webui/initial_webui_navigation_url_loader.cc
- M content/browser/webui/initial_webui_navigation_url_loader.h
- M content/test/test_navigation_url_loader.cc
- M content/test/test_navigation_url_loader.h
Change size: M
Delta: 11 files changed, 29 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kenichi Ishibashi, +1 by Rakina Zata Amni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages