Reland "[EVP] Show the loading indicator after DNS TXT lookup" [chromium/src : main]
0 views
Skip to first unread message
Yi Gu (Gerrit)
Aug 19, 2026, 12:00:27 PM (24 hours ago) Aug 19
to Jihad Hanna, rubber-...@appspot.gserviceaccount.com, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Avi Drissman, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, loading...@chromium.org, yigu+...@chromium.org, browser-comp...@chromium.org, npm+...@chromium.org
Attention needed from Avi Drissman
Yi Gu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yi Gu
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Yi Gu . resolved
Hello! I fixed the compilation issue in patchset #2 (see delta). PTAL. Thanks!
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Aug 19, 2026, 12:01:23 PM (24 hours ago) Aug 19
to Yi Gu, Jihad Hanna, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Avi Drissman, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, loading...@chromium.org, yigu+...@chromium.org, browser-comp...@chromium.org, npm+...@chromium.org
Attention needed from Avi Drissman and Yi Gu
Message from rubber-...@appspot.gserviceaccount.com![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Avi Drissman
- Yi Gu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Aug 19, 2026, 2:53:56 PM (21 hours ago) Aug 19
to Yi Gu, Avi Drissman, Jihad Hanna, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, loading...@chromium.org, yigu+...@chromium.org, browser-comp...@chromium.org, npm+...@chromium.org
Attention needed from Yi Gu
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Yi Gu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jihad Hanna (Gerrit)
Aug 19, 2026, 3:01:57 PM (21 hours ago) Aug 19
to Yi Gu, Avi Drissman, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, loading...@chromium.org, yigu+...@chromium.org, browser-comp...@chromium.org, npm+...@chromium.org
Attention needed from Yi Gu
Jihad Hanna voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jihad Hanna
| Code-Review | +1 |
1 comment
Patchset-level comments
Yi Gu (Gerrit)
Aug 19, 2026, 3:02:01 PM (21 hours ago) Aug 19
to Avi Drissman, Jihad Hanna, luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, loading...@chromium.org, yigu+...@chromium.org, browser-comp...@chromium.org, npm+...@chromium.org
Yi Gu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yi Gu
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 19, 2026, 3:05:44 PM (21 hours ago) Aug 19
to Yi Gu, Avi Drissman, Jihad Hanna, luci-bi...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Christian Biesinger, chromium...@chromium.org, loading...@chromium.org, yigu+...@chromium.org, browser-comp...@chromium.org, npm+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[EVP] Show the loading indicator after DNS TXT lookup"
This reverts commit b264e1521389e0961704985af370b48b6d5ab54b.
Reason for revert: Fixed the issue (patchset 1 v.s. 3)
Original change's description:
> Revert "[EVP] Show the loading indicator after DNS TXT lookup"
>
> This reverts commit e45069331a199f5fbff11d91fe8dc908973630be.
>
> Reason for revert:
> LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8673028508549296625
>
> Sample failed build: https://ci.chromium.org/b/8673028508549296625
>
> If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8266172&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8673028508549296625&type=BUG
>
> Original change's description:
> > [EVP] Show the loading indicator after DNS TXT lookup
> >
> > To avoid showing a loading indicator for email domains that do not
> > support EVP (e.g. non-EVP email providers that fail the DNS TXT lookup),
> > the indicator was supposed to be deferred until DNS TXT resolution
> > confirms EVP support.
> >
> > This CL implements the logic in a way that:
> > 1. No loading indicator if the email provider doesn't support EVP
> > 2. Shows an indicator before the permission UI and dismisses it when
> > the permission UI is shown
> > 3. When the permission UI is skipped for opt-in users, the indicator
> > remains at the loading state.
> >
> > Fixed: 548295868
> > Change-Id: I06538113fe99aa6f129a4382dc31d4b9215fe4e1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8266172
> > Reviewed-by: Avi Drissman <a...@chromium.org>
> > Commit-Queue: Yi Gu <yi...@chromium.org>
> > Reviewed-by: Jihad Hanna <jihad...@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1682325}
> >
>
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Iec3a9049160bf83abd38439246fc799b87409a45
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8269556
> Owners-Override: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>
> Bot-Commit: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>
> Commit-Queue: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1682328}
Change-Id: I93822afc19c83c7529e9f24ff27c448c6507c560
Reviewed-by: Jihad Hanna <jihad...@google.com>
Commit-Queue: Yi Gu <yi...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1682531}
Files:
- M chrome/browser/autofill/email_verification_browsertest.cc
- M components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate.cc
- M components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate.h
- M components/autofill/content/browser/integrators/email_verifier/email_verifier_delegate_unittest.cc
- M content/browser/loader/connection_allowlist_browsertest.cc
- M content/browser/webid/delegation/email_verification_request.cc
- M content/browser/webid/delegation/email_verification_request.h
- M content/browser/webid/delegation/email_verification_request_unittest.cc
- M content/browser/webid/delegation/email_verifier_impl.cc
- M content/browser/webid/delegation/email_verifier_impl.h
- M content/browser/webid/delegation/email_verifier_impl_unittest.cc
- M content/public/browser/webid/email_verifier.h
Change size: L
Delta: 12 files changed, 415 insertions(+), 103 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jihad Hanna, +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages