Rename SearchPrewarmProgressService to SearchPreloadProgressService [chromium/src : main]

0 views
Skip to first unread message

Jiacheng Guo (Gerrit)

unread,
Aug 20, 2026, 7:43:27 AMAug 20
to prerendering-reviews, chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org, bmcquad...@chromium.org, lingqi...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, gavin...@chromium.org, loading-rev...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org

Jiacheng Guo has uploaded the change for review

Commit message

Rename SearchPrewarmProgressService to SearchPreloadProgressService

Rename SearchPrewarmProgressService and its factory to
SearchPreloadProgressService and
SearchPreloadProgressServiceFactory. This prepares for tracking
broader search preloading states across prewarm and prerender
lifecycles.
Bug: 473593133
Change-Id: I3d79094696836ab30d262dd3a331d4ab2e31ed65

Change diff


Change information

Files:
  • M chrome/browser/preloading/prefetch/search_prefetch/search_prefetch_request.cc
  • M chrome/browser/preloading/prefetch/search_prefetch/search_prefetch_request.h
  • M chrome/browser/preloading/prefetch/search_prefetch/search_preload_unified_browsertest.cc
  • M chrome/browser/preloading/prerender/BUILD.gn
  • M chrome/browser/preloading/prerender/dse_prewarm_navigation_throttle.cc
  • M chrome/browser/preloading/prerender/dse_prewarm_navigation_throttle.h
  • M chrome/browser/preloading/prerender/dse_prewarm_navigation_throttle_browsertest.cc
  • M chrome/browser/preloading/prerender/prerender_browsertest.cc
  • M chrome/browser/preloading/prerender/prerender_manager.cc
  • R chrome/browser/preloading/prerender/search_preload_progress_service.cc
  • R chrome/browser/preloading/prerender/search_preload_progress_service.h
  • A chrome/browser/preloading/prerender/search_preload_progress_service_factory.cc
  • A chrome/browser/preloading/prerender/search_preload_progress_service_factory.h
  • R chrome/browser/preloading/prerender/search_preload_progress_service_unittest.cc
  • A chrome/browser/preloading/prerender/search_preload_progress_test_utils.cc
  • A chrome/browser/preloading/prerender/search_preload_progress_test_utils.h
  • D chrome/browser/preloading/prerender/search_prewarm_progress_service_factory.cc
  • D chrome/browser/preloading/prerender/search_prewarm_progress_service_factory.h
  • D chrome/browser/preloading/prerender/search_prewarm_progress_test_utils.cc
  • D chrome/browser/preloading/prerender/search_prewarm_progress_test_utils.h
  • M chrome/browser/preloading/search_preload/search_preload_browsertest.cc
  • M chrome/browser/preloading/search_preload/search_preload_pipeline_manager.cc
  • M chrome/browser/preloading/search_preload/search_preload_pipeline_manager.h
  • M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
Change size: L
Delta: 24 files changed, 245 insertions(+), 245 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3d79094696836ab30d262dd3a331d4ab2e31ed65
Gerrit-Change-Number: 8260258
Gerrit-PatchSet: 1
Gerrit-Owner: Jiacheng Guo <g...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Ken Okada (Gerrit)

unread,
Aug 21, 2026, 4:39:25 AMAug 21
to Jiacheng Guo, Hidehiko Abe, Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, gavin...@chromium.org, lingqi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
Attention needed from Hidehiko Abe, Jiacheng Guo and Takashi Toyoshima

Ken Okada voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Jiacheng Guo
  • Takashi Toyoshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3d79094696836ab30d262dd3a331d4ab2e31ed65
    Gerrit-Change-Number: 8260258
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Fri, 21 Aug 2026 08:38:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    Aug 23, 2026, 10:28:54 PMAug 23
    to Jiacheng Guo, Ken Okada, Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, gavin...@chromium.org, lingqi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
    Attention needed from Jiacheng Guo and Takashi Toyoshima

    Hidehiko Abe voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jiacheng Guo
    • Takashi Toyoshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3d79094696836ab30d262dd3a331d4ab2e31ed65
    Gerrit-Change-Number: 8260258
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Comment-Date: Mon, 24 Aug 2026 02:28:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    Aug 24, 2026, 1:18:54 AMAug 24
    to Jiacheng Guo, Hidehiko Abe, Ken Okada, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, gavin...@chromium.org, lingqi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
    Attention needed from Jiacheng Guo

    Takashi Toyoshima voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jiacheng Guo
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3d79094696836ab30d262dd3a331d4ab2e31ed65
    Gerrit-Change-Number: 8260258
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Comment-Date: Mon, 24 Aug 2026 05:18:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jiacheng Guo (Gerrit)

    unread,
    Aug 25, 2026, 5:08:22 AMAug 25
    to Takashi Toyoshima, Hidehiko Abe, Ken Okada, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, gavin...@chromium.org, lingqi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org

    Jiacheng Guo voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3d79094696836ab30d262dd3a331d4ab2e31ed65
    Gerrit-Change-Number: 8260258
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Comment-Date: Tue, 25 Aug 2026 09:08:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 25, 2026, 6:14:09 AMAug 25
    to Jiacheng Guo, Takashi Toyoshima, Hidehiko Abe, Ken Okada, Chromium Metrics Reviews, chromium...@chromium.org, prerendering-reviews, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, gavin...@chromium.org, lingqi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Rename SearchPrewarmProgressService to SearchPreloadProgressService

    Rename SearchPrewarmProgressService and its factory to
    SearchPreloadProgressService and
    SearchPreloadProgressServiceFactory. This prepares for tracking
    broader search preloading states across prewarm and prerender
    lifecycles.
    Bug: 473593133
    Change-Id: I3d79094696836ab30d262dd3a331d4ab2e31ed65
    Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
    Reviewed-by: Hidehiko Abe <hide...@chromium.org>
    Reviewed-by: Ken Okada <ken...@chromium.org>
    Commit-Queue: Jiacheng Guo <g...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1685429}
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Takashi Toyoshima, +1 by Hidehiko Abe, +1 by Ken Okada
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3d79094696836ab30d262dd3a331d4ab2e31ed65
    Gerrit-Change-Number: 8260258
    Gerrit-PatchSet: 3
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Ken Okada <ken...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages