Extract browser navigator into a separate build target [chromium/src : main]

0 views
Skip to first unread message

Foromo Daniel Soromou (Gerrit)

unread,
11:11 AM (5 hours ago) 11:11 AM
to Kaan Alsan, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, aixba+wat...@chromium.org, ajayramamurth...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, chungshe...@google.com, crisrael+w...@google.com, crost...@chromium.org, csharrison+...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, ffred...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, japhet+...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, menghua...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, stevenjb+wa...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, xlythe+wa...@google.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Kaan Alsan

Foromo Daniel Soromou voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kaan Alsan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65c10afadfb1dc3857a3714cdbce6d06201633ab
Gerrit-Change-Number: 7803848
Gerrit-PatchSet: 4
Gerrit-Owner: Foromo Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: Kaan Alsan <al...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Kaan Alsan <al...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Apr 2026 15:11:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Foromo Daniel Soromou (Gerrit)

unread,
11:12 AM (5 hours ago) 11:12 AM
to Darryl James, Kaan Alsan, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, aixba+wat...@chromium.org, ajayramamurth...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, chungshe...@google.com, crisrael+w...@google.com, crost...@chromium.org, csharrison+...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, ffred...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, japhet+...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, menghua...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, stevenjb+wa...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, xlythe+wa...@google.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Darryl James and Kaan Alsan

Foromo Daniel Soromou voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Darryl James
  • Kaan Alsan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65c10afadfb1dc3857a3714cdbce6d06201633ab
Gerrit-Change-Number: 7803848
Gerrit-PatchSet: 6
Gerrit-Owner: Foromo Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: Kaan Alsan <al...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Kaan Alsan <al...@chromium.org>
Gerrit-Attention: Darryl James <dlj...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Apr 2026 15:12:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kaan Alsan (Gerrit)

unread,
11:18 AM (5 hours ago) 11:18 AM
to Foromo Daniel Soromou, Darryl James, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, aixba+wat...@chromium.org, ajayramamurth...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, chungshe...@google.com, crisrael+w...@google.com, crost...@chromium.org, csharrison+...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, ffred...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, japhet+...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, menghua...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, stevenjb+wa...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, xlythe+wa...@google.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Darryl James and Foromo Daniel Soromou

Kaan Alsan added 1 comment

File chrome/browser/ui/navigator/BUILD.gn
Line 18, Patchset 6: "//build:android_buildflags",
Kaan Alsan . unresolved

ooc, why is this needed if the BUILD file already asserts this is on desktop?

Open in Gerrit

Related details

Attention is currently required from:
  • Darryl James
  • Foromo Daniel Soromou
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I65c10afadfb1dc3857a3714cdbce6d06201633ab
    Gerrit-Change-Number: 7803848
    Gerrit-PatchSet: 8
    Gerrit-Owner: Foromo Daniel Soromou <koreta...@chromium.org>
    Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
    Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>
    Gerrit-Reviewer: Kaan Alsan <al...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Darryl James <dlj...@chromium.org>
    Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 15:18:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kaan Alsan (Gerrit)

    unread,
    11:19 AM (5 hours ago) 11:19 AM
    to Foromo Daniel Soromou, Darryl James, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, aixba+wat...@chromium.org, ajayramamurth...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, chungshe...@google.com, crisrael+w...@google.com, crost...@chromium.org, csharrison+...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, ffred...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, japhet+...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, menghua...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, stevenjb+wa...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, xlythe+wa...@google.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Darryl James and Foromo Daniel Soromou

    Kaan Alsan voted and added 1 comment

    Votes added by Kaan Alsan

    Code-Review+1

    1 comment

    File chrome/browser/ui/navigator/BUILD.gn
    Line 18, Patchset 6: "//build:android_buildflags",
    Kaan Alsan . resolved

    ooc, why is this needed if the BUILD file already asserts this is on desktop?

    Kaan Alsan

    ah, I see this was resolved in a followup patchset (8)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Darryl James
    • Foromo Daniel Soromou
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I65c10afadfb1dc3857a3714cdbce6d06201633ab
      Gerrit-Change-Number: 7803848
      Gerrit-PatchSet: 8
      Gerrit-Owner: Foromo Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
      Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Kaan Alsan <al...@chromium.org>
      Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-Attention: Darryl James <dlj...@chromium.org>
      Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>
      Gerrit-Comment-Date: Wed, 29 Apr 2026 15:18:53 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Kaan Alsan <al...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Kaan Alsan (Gerrit)

      unread,
      12:40 PM (3 hours ago) 12:40 PM
      to Foromo Daniel Soromou, Darryl James, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Nikhil Nayunigari, Permissions Reviews, Peter Beverloo, aixba+wat...@chromium.org, ajayramamurth...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, chadduffin+w...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, chungshe...@google.com, crisrael+w...@google.com, crost...@chromium.org, csharrison+...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, ejcaruso+wa...@chromium.org, estali...@chromium.org, extension...@chromium.org, ffred...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, japhet+...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, kuragin+web-ap...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mattreyno...@chromium.org, mek+w...@chromium.org, menghua...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rrsilva+wat...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, stevenjb+wa...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tluk+...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, xlythe+wa...@google.com, ydago...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Darryl James and Foromo Daniel Soromou

      Kaan Alsan voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Darryl James
      • Foromo Daniel Soromou
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I65c10afadfb1dc3857a3714cdbce6d06201633ab
      Gerrit-Change-Number: 7803848
      Gerrit-PatchSet: 13
      Gerrit-Owner: Foromo Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
      Gerrit-Reviewer: Foromo Daniel Soromou <koreta...@chromium.org>
      Gerrit-Reviewer: Kaan Alsan <al...@chromium.org>
      Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-Attention: Darryl James <dlj...@chromium.org>
      Gerrit-Attention: Foromo Daniel Soromou <koreta...@chromium.org>
      Gerrit-Comment-Date: Wed, 29 Apr 2026 16:40:47 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages