Huanpo Lin (Gerrit)

unread,

Aug 19, 2026, 5:06:10 AM (yesterday) Aug 19

to Hiroki Nakagawa, Simon Pelchat, Patrik Hofman, Ken Okada, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Hiroki Nakagawa and Simon Pelchat

Huanpo Lin voted and added 4 comments

Votes added by Huanpo Lin

Commit-Queue

+1

4 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Huanpo Lin . resolved

include spelchat@ for histograms.xml

Commit Message

Line 7, Patchset 3:Support Back/Forward/Reload in PreloadServingMetrics PLMO

Ken Okada . resolved

`NavigationInitiator Back/Forward/Reload` would be better.

Huanpo Lin

Done

Line 10, Patchset 3:initiator location. This CL adds the newly added initiator to

Ken Okada . resolved

navigation initiator

Huanpo Lin

Done

File chrome/browser/page_load_metrics/observers/back_forward_cache_page_load_metrics_observer_browsertest.cc

Line 48, Patchset 3: command_line->AppendSwitch(switches::kIgnoreGooglePortNumbers);

Ken Okada . resolved

For what and why we need it? Could you add a comment?

Huanpo Lin

Added, PTAL.
https://source.chromium.org/chromium/chromium/src/+/af6ed9b22f53ed6523c83dc7481b0d3c35e1df72:components/google/core/common/google_util.cc;l=269
It is due to the util function need this flag to consider customized port to be SRP.

Open in Gerrit

Related details

Attention is currently required from:

Hiroki Nakagawa
Simon Pelchat

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simon Pelchat (Gerrit)

unread,

Aug 19, 2026, 12:04:04 PM (24 hours ago) Aug 19

to Huanpo Lin, Chromium LUCI CQ, Hiroki Nakagawa, Patrik Hofman, Ken Okada, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Hiroki Nakagawa and Huanpo Lin

Simon Pelchat voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Hiroki Nakagawa
Huanpo Lin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Hiroki Nakagawa (Gerrit)

unread,

Aug 19, 2026, 9:13:48 PM (15 hours ago) Aug 19

to Huanpo Lin, Simon Pelchat, Chromium LUCI CQ, Patrik Hofman, Ken Okada, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Huanpo Lin

Hiroki Nakagawa voted and added 3 comments

Votes added by Hiroki Nakagawa

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Hiroki Nakagawa . resolved

LGTM, thanks!

File chrome/browser/page_load_metrics/observers/back_forward_cache_page_load_metrics_observer_browsertest.cc

Line 47, Patchset 6 (Latest):

Hiroki Nakagawa . unresolved

// Allows the embedded test server's non-standard ports to be recognized as valid Google search URLs (SRP).

File components/page_load_metrics/browser/observers/preload_serving_metrics_page_load_metrics_observer.cc

Line 64, Patchset 6 (Latest):

    } else {
      navigation_initiator_string_ = "Other";
    }

Hiroki Nakagawa . unresolved

I guess this does not happen according to https://chromium-review.git.corp.google.com/c/chromium/src/+/8208862/comment/dfc004fd_6843919d/ ?

Open in Gerrit

Related details

Attention is currently required from:

Huanpo Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Huanpo Lin (Gerrit)

unread,

Aug 19, 2026, 10:08:49 PM (14 hours ago) Aug 19

to Hiroki Nakagawa, Simon Pelchat, Chromium LUCI CQ, Patrik Hofman, Ken Okada, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Huanpo Lin voted and added 3 comments

Votes added by Huanpo Lin

Commit-Queue

+1

3 comments

Patchset-level comments

File-level comment, Patchset 6:

Huanpo Lin . resolved

Thanks!

File chrome/browser/page_load_metrics/observers/back_forward_cache_page_load_metrics_observer_browsertest.cc

Line 47, Patchset 6:

Hiroki Nakagawa . resolved

// Allows the embedded test server's non-standard ports to be recognized as valid Google search URLs (SRP).

Huanpo Lin

Done

File components/page_load_metrics/browser/observers/preload_serving_metrics_page_load_metrics_observer.cc

Line 64, Patchset 6:

    } else {
      navigation_initiator_string_ = "Other";
    }

Hiroki Nakagawa . resolved

I guess this does not happen according to https://chromium-review.git.corp.google.com/c/chromium/src/+/8208862/comment/dfc004fd_6843919d/ ?

Huanpo Lin

Yes, though AI agent insists this is safer, I tested its example `history.go(0);` still results in reload in page transition, suggesting back forward page transition has no 0 offset.
I'm thinking about keeping track of the CHECK report, if it looks good for a while, I'll change this to CHECK_NE.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Huanpo Lin (Gerrit)

unread,

Aug 19, 2026, 10:08:56 PM (14 hours ago) Aug 19

to Hiroki Nakagawa, Simon Pelchat, Chromium LUCI CQ, Patrik Hofman, Ken Okada, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Huanpo Lin voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 19, 2026, 11:34:54 PM (12 hours ago) Aug 19

to Huanpo Lin, Hiroki Nakagawa, Simon Pelchat, Patrik Hofman, Ken Okada, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/page_load_metrics/observers/back_forward_cache_page_load_metrics_observer_browsertest.cc
Insertions: 2, Deletions: 1.

@@ -44,7 +44,8 @@
                   kBackForwardCacheEmitZeroSamplesForKeyMetrics,
               {{}}}}),
         content::GetDefaultDisabledBackForwardCacheFeaturesForTesting());
-
+    // Allows the embedded test server's non-standard ports to be recognized as
+    // valid Google search URLs (SRP).
     command_line->AppendSwitch(switches::kIgnoreGooglePortNumbers);
     MetricIntegrationTest::SetUpCommandLine(command_line);
   }
```

Change information

Commit message:

Support NavigationInitiator Back/Forward/Reload in PreloadServingMetrics PLMO

As https://crrev.com/c/8208862 introduces Back/Forward/Reload in the
navigation initiator. This CL adds the newly added initiator to
PreloadServingMetricsPageLoadMetricsObserver.

Bug: 517725655

Change-Id: I0a2f4331455ebe059e3927efcb606c812d7617e4

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8260221

Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>

Reviewed-by: Simon Pelchat <spel...@chromium.org>

Reviewed-by: Ken Okada <ken...@chromium.org>

Commit-Queue: Huanpo Lin <robe...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1682841}

Files:

M chrome/browser/page_load_metrics/observers/back_forward_cache_page_load_metrics_observer_browsertest.cc
M chrome/browser/page_load_metrics/observers/navigation_initiator_page_load_metrics_observer_browsertest.cc
M components/page_load_metrics/browser/observers/preload_serving_metrics_page_load_metrics_observer.cc
M tools/metrics/histograms/metadata/preloading/histograms.xml

Change size: M

Delta: 4 files changed, 207 insertions(+), 6 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Hiroki Nakagawa, +1 by Simon Pelchat, +1 by Ken Okada

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Support NavigationInitiator Back/Forward/Reload in PreloadServingMetrics PLMO [chromium/src : main]

Huanpo Lin (Gerrit)

Huanpo Lin voted and added 4 comments

Votes added by Huanpo Lin

4 comments

Related details

Simon Pelchat (Gerrit)

Simon Pelchat voted Code-Review+1

Related details

Hiroki Nakagawa (Gerrit)

Hiroki Nakagawa voted and added 3 comments

Votes added by Hiroki Nakagawa

3 comments

Related details

Huanpo Lin (Gerrit)

Huanpo Lin voted and added 3 comments

Votes added by Huanpo Lin

3 comments

Related details

Huanpo Lin (Gerrit)

Huanpo Lin voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information