Enable kThrottleSendingCustomUserTimings by default on non-Android platforms. [chromium/src : main]

0 views
Skip to first unread message

Shunya Shishido (Gerrit)

unread,
Jun 9, 2026, 2:11:03 AM (2 days ago) Jun 9
to Keita Suzuki, Yoshisato Yanagisawa, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org
Attention needed from Keita Suzuki and Yoshisato Yanagisawa

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Keita Suzuki
  • Yoshisato Yanagisawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If19aeef62500c29a2a40d9aa696a875bde3a40ab
Gerrit-Change-Number: 7911365
Gerrit-PatchSet: 1
Gerrit-Owner: Shunya Shishido <sisid...@chromium.org>
Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Keita Suzuki <suzuk...@chromium.org>
Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 06:10:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Keita Suzuki (Gerrit)

unread,
Jun 9, 2026, 11:08:40 PM (2 days ago) Jun 9
to Shunya Shishido, Yoshisato Yanagisawa, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org
Attention needed from Shunya Shishido and Yoshisato Yanagisawa

Keita Suzuki voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shunya Shishido
  • Yoshisato Yanagisawa
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If19aeef62500c29a2a40d9aa696a875bde3a40ab
    Gerrit-Change-Number: 7911365
    Gerrit-PatchSet: 1
    Gerrit-Owner: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 03:08:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Shunya Shishido (Gerrit)

    unread,
    Jun 10, 2026, 12:16:28 AM (yesterday) Jun 10
    to Keita Suzuki, Yoshisato Yanagisawa, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org
    Attention needed from Yoshisato Yanagisawa

    Shunya Shishido voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yoshisato Yanagisawa
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If19aeef62500c29a2a40d9aa696a875bde3a40ab
    Gerrit-Change-Number: 7911365
    Gerrit-PatchSet: 1
    Gerrit-Owner: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 04:16:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yoshisato Yanagisawa (Gerrit)

    unread,
    Jun 10, 2026, 12:18:05 AM (yesterday) Jun 10
    to Shunya Shishido, Keita Suzuki, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org
    Attention needed from Shunya Shishido

    Yoshisato Yanagisawa voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Shunya Shishido
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If19aeef62500c29a2a40d9aa696a875bde3a40ab
    Gerrit-Change-Number: 7911365
    Gerrit-PatchSet: 1
    Gerrit-Owner: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 04:17:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 10, 2026, 12:20:23 AM (yesterday) Jun 10
    to Shunya Shishido, Yoshisato Yanagisawa, Keita Suzuki, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Enable kThrottleSendingCustomUserTimings by default on non-Android platforms.

    We confirmed this feature flag doesn't introduce any regressions. This
    change enables the feature to throttle custom user timings by default on
    desktop. For Android, we'll keep running the experiment for a while.
    Bug: 467177770, 511200987
    Change-Id: If19aeef62500c29a2a40d9aa696a875bde3a40ab
    Commit-Queue: Shunya Shishido <sisid...@chromium.org>
    Reviewed-by: Keita Suzuki <suzuk...@chromium.org>
    Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1644437}
    Files:
    • M components/page_load_metrics/common/features.cc
    • M testing/variations/fieldtrial_testing_config.json
    Change size: S
    Delta: 2 files changed, 6 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yoshisato Yanagisawa, +1 by Keita Suzuki
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If19aeef62500c29a2a40d9aa696a875bde3a40ab
    Gerrit-Change-Number: 7911365
    Gerrit-PatchSet: 2
    Gerrit-Owner: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    open
    diffy
    satisfied_requirement

    luci-bisection@appspot.gserviceaccount.com (Gerrit)

    unread,
    Jun 10, 2026, 9:50:21 AM (21 hours ago) Jun 10
    to Chromium LUCI CQ, Shunya Shishido, Yoshisato Yanagisawa, Keita Suzuki, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org

    Message from luci-bi...@appspot.gserviceaccount.com

    LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5759381204369408

    Sample build with failed test: https://ci.chromium.org/b/8679399260187842993
    Affected test(s):
    [://chrome/test\:browser_tests!gtest::GWSAbandonedPageLoadMetricsObserverWithIgnoreDuplicateFlagBrowserTest#DuplicateNavigation_RendererInitiated/All.1](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Ftest%5C:browser_tests%21gtest::GWSAbandonedPageLoadMetricsObserverWithIgnoreDuplicateFlagBrowserTest%23DuplicateNavigation_RendererInitiated%2FAll.1?q=VHash%3A90889a43f237da1e)
    A revert for this change was not created because there are merged changes depending on it.

    If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5759381204369408&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7911365&type=BUG

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If19aeef62500c29a2a40d9aa696a875bde3a40ab
    Gerrit-Change-Number: 7911365
    Gerrit-PatchSet: 2
    Gerrit-Owner: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Keita Suzuki <suzuk...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 13:50:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages