Add modular diagnostic histograms for prewarm & prerender coverage [chromium/src : main]

0 views

Skip to first unread message

Jiacheng Guo (Gerrit)

unread,

3:35 AM (8 hours ago) 3:35 AM

to prerendering-reviews, chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, gavin...@chromium.org, loading-rev...@chromium.org, tburkar...@chromium.org, speed-metr...@chromium.org

Jiacheng Guo has uploaded the change for review

Commit message

Add modular diagnostic histograms for prewarm & prerender coverage

Add three diagnostic sub-histograms to break down prewarm and prerender
coverage and process reuse:
1. PageLoad.Clients.GoogleSearch.PrewarmNotAttemptedReason
2. PageLoad.Clients.GoogleSearch.PreloadProcessNotReusedReason
3. PageLoad.Clients.GoogleSearch.PrewarmFailureReason

These sub-histograms capture the exact operational reasons why prewarm
was not attempted (blackout, memory threshold, startup, feature flag,
or user interaction), why an active prewarm/prerender process was not
reused by primary search, and why a prewarm attempt failed before
becoming ready.

Bug: 473593133

Change-Id: I55574a0196a501c0a4fedfe5fff4253876e2f3aa

Change diff

Change information

Files:

M chrome/browser/page_load_metrics/observers/gws_page_load_metrics_observer_unittest.cc
M chrome/browser/preloading/prerender/prerender_manager.cc
M chrome/browser/preloading/prerender/prerender_manager.h
M chrome/browser/preloading/prerender/prerender_manager_unittest.cc
M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.h
M components/page_load_metrics/google/browser/search_prewarm_types.cc
M components/page_load_metrics/google/browser/search_prewarm_types.h
M tools/metrics/histograms/metadata/page/enums.xml
M tools/metrics/histograms/metadata/page/histograms.xml

Change size: L

Delta: 10 files changed, 290 insertions(+), 1 deletion(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages