Add -Wshorten-64-to-32 and -Wtautological-unsigned-zero-compare to `inside_blink` config [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jul 8, 2026, 5:54:17 AM (22 hours ago) Jul 8
to Kent Tamura, Fredrik Söderquist, Ryan Hamilton, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, loading...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Fredrik Söderquist and Ryan Hamilton

Kent Tamura added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kent Tamura . resolved

fs@, would you review the whole CL please?
rch@ would you approve net/quic/ please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Ryan Hamilton
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4bf0cd742df4b4ef833dee0402a08b9efa7e83d1
Gerrit-Change-Number: 8062845
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Ryan Hamilton <r...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Ryan Hamilton <r...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 09:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Jul 8, 2026, 6:15:29 AM (22 hours ago) Jul 8
to Kent Tamura, Ryan Hamilton, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, loading...@chromium.org, gavinp...@chromium.org, net-r...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org
Attention needed from Kent Tamura and Ryan Hamilton

Fredrik Söderquist voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
  • Ryan Hamilton
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4bf0cd742df4b4ef833dee0402a08b9efa7e83d1
    Gerrit-Change-Number: 8062845
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Ryan Hamilton <r...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Ryan Hamilton <r...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 10:15:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages