Fix Null-dereference READ in blink::Document::GetExecutionContext [chromium/src : main]
0 views
Skip to first unread message
Tarcísio Fischer (Gerrit)
Jan 27, 2026, 7:24:20 AM (4 days ago) Jan 27
to David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and David Baron
Tarcísio Fischer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tarcísio Fischer . resolved
Hey, all.
Is there any option to run that exact environment+test from the fuzzer here on CI?
Thanks in advance.
Related details
Attention is currently required from:
- Charlie Harrison
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Jan 27, 2026, 11:47:44 AM (4 days ago) Jan 27
to Tarcísio Fischer, David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and Tarcísio Fischer
David Baron added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/dom/document.cc
Line 7819, Patchset 1 (Latest):
ExecutionContext* Document::GetExecutionContext() const {David Baron . unresolved
This change isn't needed; Member::Get() should be fine if the pointer is null.
File third_party/blink/renderer/core/html/parser/html_document_parser.cc
Line 1831, Patchset 1 (Latest):
// Seen CSP tag, but there is no document to check the CSP. Disallow preloads.David Baron . unresolved
Maybe the comment should mention that `detach()` has already been called, given that that's what the comment above the definition of `GetDocument()` says.
Related details
Attention is currently required from:
- Charlie Harrison
- Tarcísio Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tarcísio Fischer (Gerrit)
Jan 29, 2026, 5:30:55 AM (2 days ago) Jan 29
to David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and David Baron
Tarcísio Fischer added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/dom/document.cc
Line 7819, Patchset 1:
ExecutionContext* Document::GetExecutionContext() const {David Baron . resolved
This change isn't needed; Member::Get() should be fine if the pointer is null.
Tarcísio Fischer
Done
File third_party/blink/renderer/core/html/parser/html_document_parser.cc
Line 1831, Patchset 1:
// Seen CSP tag, but there is no document to check the CSP. Disallow preloads.David Baron . resolved
Maybe the comment should mention that `detach()` has already been called, given that that's what the comment above the definition of `GetDocument()` says.
Attention is currently required from:
- Charlie Harrison
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Jan 29, 2026, 10:36:00 AM (2 days ago) Jan 29
to Tarcísio Fischer, David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and Tarcísio Fischer
David Baron voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Charlie Harrison
- Tarcísio Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages