Fix Null-dereference READ in blink::Document::GetExecutionContext [chromium/src : main]
0 views
Skip to first unread message
Tarcísio Fischer (Gerrit)
Jan 27, 2026, 7:24:20 AMJan 27
to David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and David Baron
Tarcísio Fischer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tarcísio Fischer . resolved
Hey, all.
Is there any option to run that exact environment+test from the fuzzer here on CI?
Thanks in advance.
Related details
Attention is currently required from:
- Charlie Harrison
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Jan 27, 2026, 11:47:44 AMJan 27
to Tarcísio Fischer, David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and Tarcísio Fischer
David Baron added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/dom/document.cc
Line 7819, Patchset 1 (Latest):
ExecutionContext* Document::GetExecutionContext() const {David Baron . unresolved
This change isn't needed; Member::Get() should be fine if the pointer is null.
File third_party/blink/renderer/core/html/parser/html_document_parser.cc
Line 1831, Patchset 1 (Latest):
// Seen CSP tag, but there is no document to check the CSP. Disallow preloads.David Baron . unresolved
Maybe the comment should mention that `detach()` has already been called, given that that's what the comment above the definition of `GetDocument()` says.
Related details
Attention is currently required from:
- Charlie Harrison
- Tarcísio Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tarcísio Fischer (Gerrit)
Jan 29, 2026, 5:30:55 AMJan 29
to David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and David Baron
Tarcísio Fischer added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/dom/document.cc
Line 7819, Patchset 1:
ExecutionContext* Document::GetExecutionContext() const {David Baron . resolved
This change isn't needed; Member::Get() should be fine if the pointer is null.
Tarcísio Fischer
Done
File third_party/blink/renderer/core/html/parser/html_document_parser.cc
Line 1831, Patchset 1:
// Seen CSP tag, but there is no document to check the CSP. Disallow preloads.David Baron . resolved
Maybe the comment should mention that `detach()` has already been called, given that that's what the comment above the definition of `GetDocument()` says.
Attention is currently required from:
- Charlie Harrison
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Jan 29, 2026, 10:36:00 AMJan 29
to Tarcísio Fischer, David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and Tarcísio Fischer
David Baron voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Charlie Harrison
- Tarcísio Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tarcísio Fischer (Gerrit)
Feb 18, 2026, 9:31:07 AM (2 days ago) Feb 18
to David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison
Tarcísio Fischer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tarcísio Fischer . resolved
Gentle bump on this @cshar...@chromium.org if you have the time to take a look, please :)
Related details
Attention is currently required from:
- Charlie Harrison
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Feb 18, 2026, 12:55:12 PM (2 days ago) Feb 18
to Tarcísio Fischer, David Baron, Charlie Harrison, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison and Tarcísio Fischer
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Charlie Harrison
- Tarcísio Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Charlie Harrison (Gerrit)
Feb 18, 2026, 1:17:41 PM (2 days ago) Feb 18
to Tarcísio Fischer, Mason Freed, David Baron, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Tarcísio Fischer
Charlie Harrison voted and added 1 comment![]( "Open in Gerrit")
Votes added by Charlie Harrison
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Tarcísio Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tarcísio Fischer (Gerrit)
Feb 19, 2026, 3:45:57 AM (yesterday) Feb 19
to Charlie Harrison, Mason Freed, David Baron, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison, David Baron and Mason Freed
Tarcísio Fischer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Tarcísio Fischer . resolved
Thanks all for the review.
I don't have the credentials to merge, could someone please merge this for me?
Thanks in advance!
Related details
Attention is currently required from:
- Charlie Harrison
- David Baron
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Feb 19, 2026, 9:42:04 AM (yesterday) Feb 19
to Tarcísio Fischer, David Baron, Charlie Harrison, Mason Freed, Chromium LUCI CQ, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Charlie Harrison, Mason Freed and Tarcísio Fischer
David Baron voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Charlie Harrison
- Mason Freed
- Tarcísio Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 19, 2026, 10:34:43 AM (yesterday) Feb 19
to Tarcísio Fischer, David Baron, Charlie Harrison, Mason Freed, AyeAye, loading-rev...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix Null-dereference READ in blink::Document::GetExecutionContext
Bug: 469851573
Change-Id: I1aa7e03fd86aa3a060b612eee1a7a82e8aae596f
Reviewed-by: David Baron <dba...@chromium.org>
Commit-Queue: David Baron <dba...@chromium.org>
Reviewed-by: Charlie Harrison <cshar...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1587117}
Files:
- M third_party/blink/renderer/core/html/parser/html_document_parser.cc
Change size: XS
Delta: 1 file changed, 8 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Charlie Harrison, +1 by David Baron, +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages