[Connection-Allowlist] Enforce for FedCM API - Update Metrics and Console Messages [chromium/src : main]
Xiaochen Zhou (Gerrit)
Xiaochen Zhou added 1 comment![]( "Open in Gerrit")
+cbiesinger@ for code review and owner approval of content/browser/webid/, thank you.
Related details
- Christian Biesinger
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Biesinger (Gerrit)
Christian Biesinger added 1 comment![]( "Open in Gerrit")
- Xiaochen Zhou
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Biesinger (Gerrit)
Christian Biesinger voted and added 1 comment![]( "Open in Gerrit")
Votes added by Christian Biesinger
| Code-Review | +1 |
1 comment
lgtm
Related details
- Xiaochen Zhou
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaochen Zhou (Gerrit)
Xiaochen Zhou added 1 comment![]( "Open in Gerrit")
+alexrudenko@ for owner approval of content/browser/devtools/ devtools_instrumentation.cc.
+chrome-ipc-reviews@ for approval of third_party/blink/public/mojom/devtools/ inspector_issue.mojom.
Thank you.
Related details
- Alex Rudenko
- Chromium IPC Reviews
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
Shadow: ari...@chromium.org; IPC: ke...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
Shadow IPC reviewer(s): ari...@chromium.org. Please conduct an IPC review and CR+1 when satisfied. Remember to add the main reviewers to the attention set if needed.
Main IPC reviewer(s): ke...@chromium.org. Please wait for the shadowed IPC reviewer to CR+1 before reviewing.
Shadowed: ari...@chromium.org
Reviewer source(s):
ari...@chromium.org, ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Alex Rudenko
- Ari Chivukula
- Ken Buchanan
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula voted Code-Review+1![]( "Open in Gerrit")
- Alex Rudenko
- Ken Buchanan
- Xiaochen Zhou
Ken Buchanan (Gerrit)
Ken Buchanan added 1 comment![]( "Open in Gerrit")
// third_party/blink/public/devtools_protocol/domains/Audits.pdl, which includesShould this file be updated as well?
Related details
- Alex Rudenko
- Xiaochen Zhou
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula added 1 comment![]( "Open in Gerrit")
// third_party/blink/public/devtools_protocol/domains/Audits.pdl, which includesShould this file be updated as well?
I assumed that wasn't included as it's not being harnessed in content/browser/devtools/devtools_instrumentation.cc (the TODOs make that seems like it's the next step)
Related details
- Alex Rudenko
- Christian Biesinger
- Xiaochen Zhou
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaochen Zhou (Gerrit)
Xiaochen Zhou added 1 comment![]( "Open in Gerrit")
// third_party/blink/public/devtools_protocol/domains/Audits.pdl, which includesAri ChivukulaShould this file be updated as well?
I assumed that wasn't included as it's not being harnessed in content/browser/devtools/devtools_instrumentation.cc (the TODOs make that seems like it's the next step)
I was planning to update this file in the next CL that implements the devtool issues: crrev.com/c/8122679. Should I combine that into this CL?
Related details
- Alex Rudenko
- Ari Chivukula
- Christian Biesinger
- Ken Buchanan
Ari Chivukula (Gerrit)
Ari Chivukula added 1 comment![]( "Open in Gerrit")
// third_party/blink/public/devtools_protocol/domains/Audits.pdl, which includesAri ChivukulaShould this file be updated as well?
Xiaochen ZhouI assumed that wasn't included as it's not being harnessed in content/browser/devtools/devtools_instrumentation.cc (the TODOs make that seems like it's the next step)
I was planning to update this file in the next CL that implements the devtool issues: crrev.com/c/8122679. Should I combine that into this CL?
I'm fine with it being split as the IPC is just enums, there's not some big e2e component that isn't being validated here to prove the mojo change
Related details
- Alex Rudenko
- Christian Biesinger
- Ken Buchanan
- Xiaochen Zhou
Ken Buchanan (Gerrit)
Ken Buchanan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Buchanan
| Code-Review | +1 |
1 comment
// third_party/blink/public/devtools_protocol/domains/Audits.pdl, which includesAri ChivukulaShould this file be updated as well?
Xiaochen ZhouI assumed that wasn't included as it's not being harnessed in content/browser/devtools/devtools_instrumentation.cc (the TODOs make that seems like it's the next step)
Ari ChivukulaI was planning to update this file in the next CL that implements the devtool issues: crrev.com/c/8122679. Should I combine that into this CL?
I'm fine with it being split as the IPC is just enums, there's not some big e2e component that isn't being validated here to prove the mojo change
- Alex Rudenko
- Ari Chivukula
- Christian Biesinger
- Xiaochen Zhou
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula voted Code-Review+1![]( "Open in Gerrit")
- Alex Rudenko
- Christian Biesinger
- Xiaochen Zhou
Alex Rudenko (Gerrit)
Alex Rudenko added 1 comment![]( "Open in Gerrit")
case FederatedRequestResult::kWellKnownBlockedByConnectionAllowlist:It looks like the protocol change that generates the enums is added in this CL (third_party/blink/public/devtools_protocol/domains/Audits.pdl) Is there a reason not to mapa the result codes to the new enum values?
Related details
- Christian Biesinger
- Xiaochen Zhou
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |