Bedrock: Migrate page_load_metrics and pdf to BrowserWindowInterface [chromium/src : main]

0 views
Skip to first unread message

Sophie Chang (Gerrit)

unread,
Aug 19, 2026, 2:27:47 PM (21 hours ago) Aug 19
to Farid (Mojtaba) Faridzad, Thomas Lukaszewicz, chromium...@chromium.org, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, bmcquad...@chromium.org, chromium-a...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, nektar...@chromium.org, pdf-r...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, yuzo+...@chromium.org
Attention needed from Farid (Mojtaba) Faridzad and Thomas Lukaszewicz

Sophie Chang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Farid (Mojtaba) Faridzad
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7dc4b85a2016bfb37801b2a1a9a25ef4685b7a91
Gerrit-Change-Number: 8268724
Gerrit-PatchSet: 1
Gerrit-Owner: Farid (Mojtaba) Faridzad <fari...@google.com>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Farid (Mojtaba) Faridzad <fari...@google.com>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 18:27:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
Aug 19, 2026, 2:28:28 PM (21 hours ago) Aug 19
to Farid (Mojtaba) Faridzad, Sophie Chang, chromium...@chromium.org, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, bmcquad...@chromium.org, chromium-a...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, nektar...@chromium.org, pdf-r...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, yuzo+...@chromium.org
Attention needed from Farid (Mojtaba) Faridzad

Thomas Lukaszewicz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Farid (Mojtaba) Faridzad
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7dc4b85a2016bfb37801b2a1a9a25ef4685b7a91
Gerrit-Change-Number: 8268724
Gerrit-PatchSet: 1
Gerrit-Owner: Farid (Mojtaba) Faridzad <fari...@google.com>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Farid (Mojtaba) Faridzad <fari...@google.com>
Gerrit-Comment-Date: Wed, 19 Aug 2026 18:28:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Farid (Mojtaba) Faridzad (Gerrit)

unread,
Aug 19, 2026, 6:46:33 PM (17 hours ago) Aug 19
to Thomas Lukaszewicz, Sophie Chang, chromium...@chromium.org, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, bmcquad...@chromium.org, chromium-a...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, nektar...@chromium.org, pdf-r...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, yuzo+...@chromium.org

Farid (Mojtaba) Faridzad voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7dc4b85a2016bfb37801b2a1a9a25ef4685b7a91
Gerrit-Change-Number: 8268724
Gerrit-PatchSet: 1
Gerrit-Owner: Farid (Mojtaba) Faridzad <fari...@google.com>
Gerrit-Reviewer: Farid (Mojtaba) Faridzad <fari...@google.com>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 22:46:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 19, 2026, 8:43:57 PM (15 hours ago) Aug 19
to Farid (Mojtaba) Faridzad, Thomas Lukaszewicz, Sophie Chang, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Josh Karlin, Yao Xiao, abigailbk...@google.com, bmcquad...@chromium.org, chromium-a...@chromium.org, csharris...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, nektar...@chromium.org, pdf-r...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Bedrock: Migrate page_load_metrics and pdf to BrowserWindowInterface

Migrate Browser references to BrowserWindowInterface across C++ files
in chrome/browser/page_load_metrics/ and chrome/browser/pdf/.

Changes:
- Replaced Browser pointers/references with BrowserWindowInterface
  in observers, integration tests, and pdf extension tests.
- Replaced #include "chrome/browser/ui/browser.h" with forward
  declarations of BrowserWindowInterface in headers where possible,
  and included browser_window_interface.h in implementation files.
- Eliminated GetBrowserForMigrationOnly() calls where applicable.
- Updated BUILD.gn files to depend on //chrome/browser/ui/browser_window.

TAG=agy
CONV=4241bed1-86b7-437f-a5be-b8396d75afa5
Bug: 496674143
Change-Id: I7dc4b85a2016bfb37801b2a1a9a25ef4685b7a91
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Commit-Queue: Farid (Mojtaba) Faridzad <fari...@google.com>
Cr-Commit-Position: refs/heads/main@{#1682754}
Files:
  • M chrome/browser/page_load_metrics/BUILD.gn
  • M chrome/browser/page_load_metrics/integration_tests/BUILD.gn
  • M chrome/browser/page_load_metrics/integration_tests/image_loading_uma_browsertest.cc
  • M chrome/browser/page_load_metrics/integration_tests/interaction_to_next_paint_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/BUILD.gn
  • M chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/ash_session_restore_page_load_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/gws_abandoned_page_load_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/initial_webui_page_load_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer.cc
  • M chrome/browser/page_load_metrics/observers/navigation_initiator_page_load_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/serp_page_load_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/observers/tab_strip_page_load_metrics_observer.cc
  • M chrome/browser/page_load_metrics/observers/third_party_metrics_observer_browsertest.cc
  • M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
  • M chrome/browser/pdf/BUILD.gn
  • M chrome/browser/pdf/pdf_extension_accessibility_test.cc
  • M chrome/browser/pdf/pdf_extension_download_test.cc
  • M chrome/browser/pdf/pdf_extension_js_test.cc
  • M chrome/browser/pdf/pdf_extension_test.cc
  • M chrome/browser/pdf/pdf_extension_test_base.cc
Change size: L
Delta: 21 files changed, 188 insertions(+), 183 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sophie Chang, +1 by Thomas Lukaszewicz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7dc4b85a2016bfb37801b2a1a9a25ef4685b7a91
Gerrit-Change-Number: 8268724
Gerrit-PatchSet: 2
Gerrit-Owner: Farid (Mojtaba) Faridzad <fari...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages