Aldo Culquicondor (Gerrit)

unread,

Jul 30, 2026, 10:33:12 AM (19 hours ago) Jul 30

to Yaron Friedman, Tibor Goldschwendt, Ian Clelland, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Ian Clelland, Tibor Goldschwendt and Yaron Friedman

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Ian Clelland
Tibor Goldschwendt
Yaron Friedman

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ian Clelland (Gerrit)

unread,

Jul 30, 2026, 10:42:02 AM (19 hours ago) Jul 30

to Aldo Culquicondor, Tibor Goldschwendt, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Aldo Culquicondor and Tibor Goldschwendt

Ian Clelland added 1 comment

File tools/metrics/histograms/metadata/new_tab_page/histograms.xml

Line 1125, Patchset 1: <variant name=".FirstContentfulPaint2" summary="First contentful paint."/>

Ian Clelland . unresolved

Can you add a tag to the CL description, along the lines of

```
OBSOLETE_HISTOGRAM[NewTabPage.LoadTime.FirstContentfulPaint]=Replaced by NewTabPage.LoadTime.FirstContentfulPaint2
```

(Possibly with a bit more explanatory information)

ref: [tools/metrics/histograms/README.md#add-an-obsoletion-message](https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#add-an-obsoletion-message)

Open in Gerrit

Related details

Attention is currently required from:

Aldo Culquicondor
Tibor Goldschwendt

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ian Clelland (Gerrit)

unread,

Jul 30, 2026, 10:42:59 AM (19 hours ago) Jul 30

to Aldo Culquicondor, Tibor Goldschwendt, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Aldo Culquicondor and Tibor Goldschwendt

Ian Clelland voted and added 1 comment

Votes added by Ian Clelland

Code-Review

+1

1 comment

File tools/metrics/histograms/metadata/new_tab_page/histograms.xml

Line 1125, Patchset 1: <variant name=".FirstContentfulPaint2" summary="First contentful paint."/>

Ian Clelland . resolved

Can you add a tag to the CL description, along the lines of
```
OBSOLETE_HISTOGRAM[NewTabPage.LoadTime.FirstContentfulPaint]=Replaced by NewTabPage.LoadTime.FirstContentfulPaint2
```
(Possibly with a bit more explanatory information)
ref: [tools/metrics/histograms/README.md#add-an-obsoletion-message](https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#add-an-obsoletion-message)

Ian Clelland

nm, you beat me to it 😄

Open in Gerrit

Related details

Attention is currently required from:

Aldo Culquicondor
Tibor Goldschwendt

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tibor Goldschwendt (Gerrit)

unread,

Jul 30, 2026, 1:05:25 PM (17 hours ago) Jul 30

to Aldo Culquicondor, Ian Clelland, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Aldo Culquicondor

Tibor Goldschwendt added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Tibor Goldschwendt . unresolved

How will that impact the metrics check for the WebUI NTP on AL?

File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Line 633, Patchset 2 (Latest): 10 * 60 * 1000, // 10 minutes

Tibor Goldschwendt . unresolved

Nit: Consider using `TimeUtils.MILLISECONDS_PER_MINUTE * 10` here since `TimeUtils` is already imported, which is more self-documenting.

Open in Gerrit

Related details

Attention is currently required from:

Aldo Culquicondor

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aldo Culquicondor (Gerrit)

unread,

Jul 30, 2026, 1:50:53 PM (16 hours ago) Jul 30

to Ian Clelland, Tibor Goldschwendt, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Tibor Goldschwendt

Aldo Culquicondor added 2 comments

Patchset-level comments

File-level comment, Patchset 2:

Tibor Goldschwendt . unresolved

How will that impact the metrics check for the WebUI NTP on AL?

Aldo Culquicondor

Which check?

Right now the metrics from java and webui are not comparable.

File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Line 633, Patchset 2: 10 * 60 * 1000, // 10 minutes

Tibor Goldschwendt . resolved

Nit: Consider using `TimeUtils.MILLISECONDS_PER_MINUTE * 10` here since `TimeUtils` is already imported, which is more self-documenting.

Aldo Culquicondor

Done

Open in Gerrit

Related details

Attention is currently required from:

Tibor Goldschwendt

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tibor Goldschwendt (Gerrit)

unread,

Jul 30, 2026, 2:58:00 PM (15 hours ago) Jul 30

to Aldo Culquicondor, Ian Clelland, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Aldo Culquicondor

Tibor Goldschwendt added 1 comment

Patchset-level comments

File-level comment, Patchset 2:

Tibor Goldschwendt . unresolved

How will that impact the metrics check for the WebUI NTP on AL?

Aldo Culquicondor

Which check?
Right now the metrics from java and webui are not comparable.

Tibor Goldschwendt

Chatted internally. Please put back into my attention set when ready.

Open in Gerrit

Related details

Attention is currently required from:

Aldo Culquicondor

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aldo Culquicondor (Gerrit)

unread,

Jul 30, 2026, 3:17:50 PM (14 hours ago) Jul 30

to Ian Clelland, Tibor Goldschwendt, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Aldo Culquicondor added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Aldo Culquicondor . unresolved

Not sure if I should keep the OBSOLETE_HISTOGRAM tag or not.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aldo Culquicondor (Gerrit)

unread,

Jul 30, 2026, 3:18:14 PM (14 hours ago) Jul 30

to Ian Clelland, Tibor Goldschwendt, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Tibor Goldschwendt

Aldo Culquicondor added 1 comment

Patchset-level comments

File-level comment, Patchset 2:

Tibor Goldschwendt . resolved

How will that impact the metrics check for the WebUI NTP on AL?

Aldo Culquicondor

Which check?
Right now the metrics from java and webui are not comparable.

Tibor Goldschwendt

Chatted internally. Please put back into my attention set when ready.

Aldo Culquicondor

Added the old histogram back for desktop only.

Open in Gerrit

Related details

Attention is currently required from:

Tibor Goldschwendt

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ian Clelland (Gerrit)

unread,

Jul 30, 2026, 3:34:36 PM (14 hours ago) Jul 30

to Aldo Culquicondor, Tibor Goldschwendt, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Aldo Culquicondor and Tibor Goldschwendt

Ian Clelland voted and added 2 comments

Votes added by Ian Clelland

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Aldo Culquicondor . unresolved

Not sure if I should keep the OBSOLETE_HISTOGRAM tag or not.

Ian Clelland

I'd remove that tag, and just tag it in the eventual CL that actually removes the variant.

File tools/metrics/histograms/metadata/new_tab_page/histograms.xml

Line 1127, Patchset 5 (Latest): removed."/>

Ian Clelland . unresolved

Shoud we also add "Replaced by NewTabPage.LoadTime.FirstContentfulPaint2" to the summary?

Open in Gerrit

Related details

Attention is currently required from:

Aldo Culquicondor
Tibor Goldschwendt

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aldo Culquicondor (Gerrit)

unread,

Jul 30, 2026, 3:38:19 PM (14 hours ago) Jul 30

to Ian Clelland, Tibor Goldschwendt, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Attention needed from Tibor Goldschwendt

Aldo Culquicondor voted and added 2 comments

Votes added by Aldo Culquicondor

Auto-Submit	+1
Commit-Queue	+1

2 comments

Patchset-level comments

File-level comment, Patchset 5:

Aldo Culquicondor . resolved

Not sure if I should keep the OBSOLETE_HISTOGRAM tag or not.

Ian Clelland

I'd remove that tag, and just tag it in the eventual CL that actually removes the variant.

Aldo Culquicondor

Done

File tools/metrics/histograms/metadata/new_tab_page/histograms.xml

Line 1127, Patchset 5: removed."/>

Ian Clelland . resolved

Shoud we also add "Replaced by NewTabPage.LoadTime.FirstContentfulPaint2" to the summary?

Aldo Culquicondor

Done

Open in Gerrit

Related details

Attention is currently required from:

Tibor Goldschwendt

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tibor Goldschwendt (Gerrit)

unread,

Jul 30, 2026, 3:40:12 PM (14 hours ago) Jul 30

to Aldo Culquicondor, Ian Clelland, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Tibor Goldschwendt voted and added 1 comment

Votes added by Tibor Goldschwendt

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5:

Aldo Culquicondor . unresolved

Not sure if I should keep the OBSOLETE_HISTOGRAM tag or not.

Tibor Goldschwendt

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aldo Culquicondor (Gerrit)

unread,

Jul 30, 2026, 4:07:00 PM (14 hours ago) Jul 30

to Tibor Goldschwendt, Ian Clelland, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Aldo Culquicondor voted and added 1 comment

Votes added by Aldo Culquicondor

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 5:

Aldo Culquicondor . resolved

Not sure if I should keep the OBSOLETE_HISTOGRAM tag or not.

Tibor Goldschwendt

+1

Aldo Culquicondor

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 30, 2026, 6:00:51 PM (12 hours ago) Jul 30

to Aldo Culquicondor, Tibor Goldschwendt, Ian Clelland, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: tools/metrics/histograms/metadata/new_tab_page/histograms.xml
Insertions: 2, Deletions: 2.

@@ -1123,8 +1123,8 @@
   <token key="NewTabPageTimings">
     <variant name=""/>
     <variant name=".FirstContentfulPaint"
-        summary="First contentful paint. Android desktop only. Soon to be
-                 removed and replaced by
+        summary="First contentful paint. Android desktop only. Its
+                 functionality is already covered by
                  NewTabPage.LoadTime.FirstContentfulPaint2."/>


     <variant name=".FirstContentfulPaint2" summary="First contentful paint."/>

     <variant name=".LargestContentfulPaint"
```

Change information

Commit message:

Homogenize NTP loadtime histogram between C++ and Java

NewTabPage.LoadTime.FirstContentfulPaint is now replaced by
NewTabPage.LoadTime.FirstContentfulPaint2, which correctly matches the
buckets between the Java and C++ uses.

NewTabPage.LoadTime.FirstContentfulPaint is still recorded for Android
desktop.

Bug: 531793117

Change-Id: I057dbee5c9606bf09d5db6d8466dc06a6ed2b4df

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8171446

Reviewed-by: Ian Clelland <icle...@chromium.org>

Reviewed-by: Tibor Goldschwendt <tib...@chromium.org>

Commit-Queue: Aldo Culquicondor <aco...@chromium.org>

Auto-Submit: Aldo Culquicondor <aco...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1671446}

Files:

M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
M chrome/browser/page_load_metrics/observers/new_tab_page_page_load_metrics_observer.cc
M chrome/browser/page_load_metrics/observers/new_tab_page_page_load_metrics_observer.h
M components/page_load_metrics/browser/page_load_metrics_util.h
M tools/metrics/histograms/metadata/new_tab_page/histograms.xml

Change size: S

Delta: 5 files changed, 42 insertions(+), 6 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Tibor Goldschwendt, +1 by Ian Clelland

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Shunya Shishido (Gerrit)

unread,

Jul 30, 2026, 8:41:52 PM (9 hours ago) Jul 30

to Aldo Culquicondor, Chromium LUCI CQ, Tibor Goldschwendt, Ian Clelland, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, loading-rev...@chromium.org, ntp-dev...@chromium.org, speed-metr...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, csharris...@chromium.org, hanxi...@chromium.org

Shunya Shishido has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Homogenize NTP loadtime histogram between C++ and Java [chromium/src : main]

Aldo Culquicondor (Gerrit)

New activity on the change

Related details

Ian Clelland (Gerrit)

Ian Clelland added 1 comment

Related details

Ian Clelland (Gerrit)

Ian Clelland voted and added 1 comment

Votes added by Ian Clelland

1 comment

Related details

Tibor Goldschwendt (Gerrit)

Tibor Goldschwendt added 2 comments

Related details

Aldo Culquicondor (Gerrit)

Aldo Culquicondor added 2 comments

Related details

Tibor Goldschwendt (Gerrit)

Tibor Goldschwendt added 1 comment

Related details

Aldo Culquicondor (Gerrit)

Aldo Culquicondor added 1 comment

Related details

Aldo Culquicondor (Gerrit)

Aldo Culquicondor added 1 comment

Related details

Ian Clelland (Gerrit)

Ian Clelland voted and added 2 comments

Votes added by Ian Clelland

2 comments

Related details

Aldo Culquicondor (Gerrit)

Aldo Culquicondor voted and added 2 comments

Votes added by Aldo Culquicondor

2 comments

Related details

Tibor Goldschwendt (Gerrit)

Tibor Goldschwendt voted and added 1 comment

Votes added by Tibor Goldschwendt

1 comment

Related details

Aldo Culquicondor (Gerrit)

Aldo Culquicondor voted and added 1 comment

Votes added by Aldo Culquicondor

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information

Shunya Shishido (Gerrit)

Shunya Shishido has created a revert of this change

Related details