Convert profile() to GetProfile() (Part 9) [chromium/src : main]

0 views
Skip to first unread message

Thomas Lukaszewicz (Gerrit)

unread,
Jul 8, 2026, 2:30:02 PM (14 hours ago) Jul 8
to Riley Tatum, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, abigailbk...@google.com, bmcquad...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, csharris...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, pdf-r...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org
Attention needed from Riley Tatum

Thomas Lukaszewicz added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thomas Lukaszewicz . resolved

Riley ptal (sorry for the large diff - purely mechanical so hopefully not too bad)

Open in Gerrit

Related details

Attention is currently required from:
  • Riley Tatum
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I229d6ce3712dc8b4a479ccbb77bcb7620fd5bad7
Gerrit-Change-Number: 8063344
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: Riley Tatum <rta...@google.com>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Riley Tatum <rta...@google.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 18:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Riley Tatum (Gerrit)

unread,
Jul 8, 2026, 6:49:01 PM (10 hours ago) Jul 8
to Thomas Lukaszewicz, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, abigailbk...@google.com, bmcquad...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, csharris...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, pdf-r...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org
Attention needed from Thomas Lukaszewicz

Riley Tatum voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I229d6ce3712dc8b4a479ccbb77bcb7620fd5bad7
    Gerrit-Change-Number: 8063344
    Gerrit-PatchSet: 2
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Riley Tatum <rta...@google.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 22:48:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Lukaszewicz (Gerrit)

    unread,
    Jul 8, 2026, 6:51:02 PM (10 hours ago) Jul 8
    to Riley Tatum, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, abigailbk...@google.com, bmcquad...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, csharris...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, pdf-r...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org

    Thomas Lukaszewicz voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I229d6ce3712dc8b4a479ccbb77bcb7620fd5bad7
    Gerrit-Change-Number: 8063344
    Gerrit-PatchSet: 2
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Riley Tatum <rta...@google.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 22:50:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 8, 2026, 6:54:38 PM (9 hours ago) Jul 8
    to Thomas Lukaszewicz, Riley Tatum, android-bu...@system.gserviceaccount.com, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, abigailbk...@google.com, bmcquad...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, csharris...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, pdf-r...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vasilii+watchlis...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Convert profile() to GetProfile() (Part 9)

    No expected behavior changes. This CL updates calls to
    Browser::profile() to instead be BrowserWindowInterface::GetProfile().

    This change contains only the rename + reformat (if necessary)
    Bug: 532248264
    Change-Id: I229d6ce3712dc8b4a479ccbb77bcb7620fd5bad7
    Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>
    Reviewed-by: Riley Tatum <rta...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1659106}
    Files:
    • M chrome/browser/net/profile_network_context_service_browsertest.cc
    • M chrome/browser/net/system_network_context_manager_browsertest.cc
    • M chrome/browser/net/websocket_browsertest.cc
    • M chrome/browser/new_tab_page/new_tab_page_util_browsertest.cc
    • M chrome/browser/new_tab_page/ntp_promo/ntp_promo_interactive_uitest.cc
    • M chrome/browser/notifications/notification_interactive_uitest.cc
    • M chrome/browser/notifications/notification_interactive_uitest_support.cc
    • M chrome/browser/notifications/notification_permission_browsertest.cc
    • M chrome/browser/notifications/notification_platform_bridge_chromeos_browsertest.cc
    • M chrome/browser/notifications/notification_platform_bridge_win_interactive_uitest.cc
    • M chrome/browser/notifications/notification_ui_manager_interactive_uitest.cc
    • M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
    • M chrome/browser/ntp_tiles/ntp_tiles_browsertest.cc
    • M chrome/browser/optimization_guide/hints_fetcher_browsertest.cc
    • M chrome/browser/optimization_guide/model_execution/model_execution_browsertest.cc
    • M chrome/browser/optimization_guide/model_execution/model_execution_live_test.cc
    • M chrome/browser/optimization_guide/model_execution/model_execution_validation_browsertest.cc
    • M chrome/browser/optimization_guide/model_execution/on_device_model_browsertest.cc
    • M chrome/browser/optimization_guide/optimization_guide_keyed_service_browsertest.cc
    • M chrome/browser/optimization_guide/optimization_guide_tab_url_provider_browsertest.cc
    • M chrome/browser/optimization_guide/prediction/prediction_manager_browsertest.cc
    • M chrome/browser/optimization_guide/prediction/prediction_model_store_browsertest.cc
    • M chrome/browser/os_crypt/app_bound_encryption_win_browsertest.cc
    • M chrome/browser/page_load_metrics/integration_tests/interaction_to_next_paint_browsertest.cc
    • M chrome/browser/page_load_metrics/observers/gws_abandoned_page_load_metrics_observer_browsertest.cc
    • M chrome/browser/page_load_metrics/observers/gws_page_load_metrics_observer_browsertest.cc
    • M chrome/browser/page_load_metrics/observers/initial_webui_page_load_metrics_observer_browsertest.cc
    • M chrome/browser/page_load_metrics/observers/navigation_initiator_page_load_metrics_observer_browsertest.cc
    • M chrome/browser/page_load_metrics/observers/serp_page_load_metrics_observer_browsertest.cc
    • M chrome/browser/page_load_metrics/observers/third_party_metrics_observer_browsertest.cc
    • M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
    • M chrome/browser/paint_preview/paint_preview_compositor_browsertest.cc
    • M chrome/browser/password_manager/credential_manager_browsertest.cc
    • M chrome/browser/password_manager/password_change_browsertest.cc
    • M chrome/browser/password_manager/password_generation_interactive_uitest.cc
    • M chrome/browser/password_manager/password_manager_browsertest.cc
    • M chrome/browser/password_manager/password_manager_captured_sites_interactive_uitest.cc
    • M chrome/browser/password_manager/password_manager_interactive_uitest.cc
    • M chrome/browser/password_manager/password_manager_test_base.cc
    • M chrome/browser/payments/manifest_verifier_browsertest.cc
    • M chrome/browser/pdf/pdf_extension_accessibility_test.cc
    • M chrome/browser/pdf/pdf_extension_download_test.cc
    Change size: L
    Delta: 42 files changed, 258 insertions(+), 241 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Riley Tatum
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I229d6ce3712dc8b4a479ccbb77bcb7620fd5bad7
    Gerrit-Change-Number: 8063344
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Riley Tatum <rta...@google.com>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages