Blink: Log blob: navigations under Trusted Types (metrics‑only; no behavior change) [chromium/src : main]
Rick Byers (Gerrit)
Rick Byers voted and added 2 comments![]( "Open in Gerrit")
Votes added by Rick Byers
| Code-Review | -1 |
2 comments
While other CLs from this account remain in violation of our AI policy (https://chromium-review.googlesource.com/c/chromium/src/+/6868239), I suggest no time be spent reviewing additional CLs. Please get to a
CONTENT_EXPORT BASE_DECLARE_FEATURE(kTrustedTypesBlobNavigationEnforcement);If this CL is just about adding metrics, why does it include a feature for "enforcement"?
This looks to me like a 3rd violation of our AI policy (other two being in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/6868239).
Can you explain how this happened?
Related details
- Camille Lamy
- David Amber “WebDUH LLC” Weatherspoon
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Amber “WebDUH LLC” Weatherspoon (Gerrit)
David Amber “WebDUH LLC” Weatherspoon added 1 comment![]( "Open in Gerrit")
CONTENT_EXPORT BASE_DECLARE_FEATURE(kTrustedTypesBlobNavigationEnforcement);If this CL is just about adding metrics, why does it include a feature for "enforcement"?
This looks to me like a 3rd violation of our AI policy (other two being in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/6868239).
Can you explain how this happened?
Yes - developed it out fully locally for expirementation and then regressed it to metrics to ensure it would be valid if moved forwarard - I am having issues with Gerry still!
Related details
- Camille Lamy
- Rick Byers
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Amber “WebDUH LLC” Weatherspoon (Gerrit)
David Amber “WebDUH LLC” Weatherspoon added 1 comment![]( "Open in Gerrit")
CONTENT_EXPORT BASE_DECLARE_FEATURE(kTrustedTypesBlobNavigationEnforcement);David Amber “WebDUH LLC” WeatherspoonIf this CL is just about adding metrics, why does it include a feature for "enforcement"?
This looks to me like a 3rd violation of our AI policy (other two being in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/6868239).
Can you explain how this happened?
David Amber “WebDUH LLC” WeatherspoonYes - developed it out fully locally for expirementation and then regressed it to metrics to ensure it would be valid if moved forwarard - I am having issues with Gerry still!
I was trying to acheive what was asked by the person you put in charge of me in the original cli so I filed the bugs she requested and am attempting to post just the metrics version only within the blink scope.
Rick Byers (Gerrit)
Rick Byers added 1 comment![]( "Open in Gerrit")
CONTENT_EXPORT BASE_DECLARE_FEATURE(kTrustedTypesBlobNavigationEnforcement);David Amber “WebDUH LLC” WeatherspoonIf this CL is just about adding metrics, why does it include a feature for "enforcement"?
This looks to me like a 3rd violation of our AI policy (other two being in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/6868239).
Can you explain how this happened?
Yes - developed it out fully locally for expirementation and then regressed it to metrics to ensure it would be valid if moved forwarard - I am having issues with Gerry still!
Ok. You can mark a patch as "work in progress" in the gerrit UI and not add any reviewers while you are developing it. We expect contributors to carefully review each and every line of their CL and make sure they make sense within the context of their CL description before asking anyone else to spend their time looking at the CL. I'll remove reviewers for now. Once you have confidence in the quality, completeness and self-consistency of your CL then an expert can invest their time reviewing it.
Related details
- Camille Lamy
- David Amber “WebDUH LLC” Weatherspoon
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Amber “WebDUH LLC” Weatherspoon (Gerrit)
David Amber “WebDUH LLC” Weatherspoon added 1 comment![]( "Open in Gerrit")
Message
Thank you and I apologize I promise I am working very hard on it it's mostly I am not used to Gerritt
Attention needed from Camille Lamy and David Amber “WebDUH LLC” Weatherspoon Line 180, Patchset 6 (Latest):
. Open in Gerrit
Attention is currently required from:
Submit Requirements: hidden footers settings
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4d87f9564f2bf4b4afbd6c2c59c1aec5e326797b
Gerrit-Change-Number: 6879190
Gerrit-PatchSet: 6
Gerrit-Owner: David Amber “WebDUH LLC” Weatherspoon <reconsume...@gmail.com>
Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-CC: Camille Lamy <cl...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Rick Byers <rby...@chromium.org>
Gerrit-CC: chromium...@chromium.org
Gerrit-Attention: David Amber “WebDUH LLC” Weatherspoon <reconsume...@gmail.com>
Gerrit-Attention: Camille Lamy <cl...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Sep 2025 14:31:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Amber “WebDUH LLC” Weatherspoon <reconsume...@gmail.com>
Comment-In-Reply-To: Rick Byers <rby...@chromium.org>
1 comment
Thank you and I apologize I promise I am working very hard on it it's mostly I am not used to Gerritt
Attention needed from Camille Lamy and David Amber “WebDUH LLC” Weatherspoon Line 180, Patchset 6 (Latest):
. Open in Gerrit
Attention is currently required from:
Submit Requirements: hidden footers settings
David Amber “WebDUH LLC” Weatherspoon (Gerrit)
David Amber “WebDUH LLC” Weatherspoon added 1 comment![]( "Open in Gerrit")
Message
I really hope you can tell from what was included how hoard I Am working on it it - I built it out several different ways ensuring I Would have a plan of action for whatever decisions the code owners make and I regressed several versions -> it was actually not producing any errors at all for me so much so I didn't notice I hadn't removed the obviously not supposed to be in there yet files. I am still learning gerritt and I Will make you proud!
On Fri, Sep 12, 2025 at 10:32 AM David Amber Weatherspoon <> wrote:
1 comment
I really hope you can tell from what was included how hoard I Am working on it it - I built it out several different ways ensuring I Would have a plan of action for whatever decisions the code owners make and I regressed several versions -> it was actually not producing any errors at all for me so much so I didn't notice I hadn't removed the obviously not supposed to be in there yet files. I am still learning gerritt and I Will make you proud!
On Fri, Sep 12, 2025 at 10:32 AM David Amber Weatherspoon <> wrote:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |