Renderer-side speculation heuristics - fix up preconnect fallback [chromium/src : main]
0 views
Skip to first unread message
Hiroki Nakagawa (Gerrit)
1:08 AM (5 hours ago) 1:08 AM
to Yoav Weiss (@Shopify), android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, prerendering-reviews, blink-...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, loading...@chromium.org, tburkar...@chromium.org
Attention needed from Yoav Weiss (@Shopify)
Hiroki Nakagawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hiroki Nakagawa
| Code-Review | +1 |
1 comment
Commit Message
Line 11, Patchset 2 (Latest):
fixes those failures.Hiroki Nakagawa . unresolved
Can you explain why the tests were failing, and how this CL fixes them?
Related details
Attention is currently required from:
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
1:34 AM (4 hours ago) 1:34 AM
to Hiroki Nakagawa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, prerendering-reviews, blink-...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, loading...@chromium.org, tburkar...@chromium.org
Yoav Weiss (@Shopify) voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yoav Weiss (@Shopify)
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Commit Message
Can you explain why the tests were failing, and how this CL fixes them?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:47 AM (4 hours ago) 1:47 AM
to Yoav Weiss (@Shopify), Hiroki Nakagawa, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, prerendering-reviews, blink-...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, loading...@chromium.org, tburkar...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Renderer-side speculation heuristics - fix up preconnect fallback
When trying to enable the renderer-side heuristics by default[1], we've
noticed a few failures related to browser-side preconnects. This CL
fixes those failures:
PreloadingDecider::OnPointerDown() returned early when renderer-side
heuristics were enabled, but the renderer only sent EnactCandidate for
speculation rules matches. That meant that regular anchors did not
get preconnect when the feature is enabled.
Now it triggers preconnect whenever the anchor is not a speculation
rules candidate.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/8164204
Bug: 532860179
Change-Id: I1580d155474bea72bd61cfd13ff747a35c2acd5d
Commit-Queue: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1671636}
Files:
- M content/browser/preloading/preloading_decider.cc
- M content/browser/preloading/preloading_decider.h
- M content/browser/preloading/preloading_decider_unittest.cc
- M third_party/blink/renderer/core/loader/anchor_element_interaction_test.cc
- M third_party/blink/renderer/core/loader/anchor_element_interaction_tracker.cc
Change size: L
Delta: 5 files changed, 292 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hiroki Nakagawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages