Use HttpRequestHeadersUpdateParams in test's FollowRedirectParams [chromium/src : main]
0 views
Skip to first unread message
Kenichi Ishibashi (Gerrit)
May 14, 2026, 12:21:49 AM (6 days ago) May 14
to Hiroshige Hayashizaki, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
Attention needed from Hiroshige Hayashizaki
Kenichi Ishibashi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Hiroshige Hayashizaki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 14, 2026, 5:46:51 PM (5 days ago) May 14
to Rakina Zata Amni, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
Attention needed from Rakina Zata Amni
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Hiroshige Hayashizaki . resolved
+rakina@ for cotent OWNER review.
Related details
Attention is currently required from:
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 14, 2026, 5:47:01 PM (5 days ago) May 14
to Rakina Zata Amni, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
Attention needed from Rakina Zata Amni
Hiroshige Hayashizaki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hiroshige Hayashizaki . resolved
Memo: checked again.
Rakina Zata Amni (Gerrit)
May 15, 2026, 1:49:07 AM (5 days ago) May 15
to Hiroshige Hayashizaki, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
Attention needed from Hiroshige Hayashizaki
Rakina Zata Amni voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hiroshige Hayashizaki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
May 15, 2026, 1:02:18 PM (5 days ago) May 15
to Rakina Zata Amni, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
Hiroshige Hayashizaki voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 19, 2026, 1:35:42 AM (yesterday) May 19
to Hiroshige Hayashizaki, Rakina Zata Amni, Kenichi Ishibashi, chromium...@chromium.org, prerendering-reviews, gavin...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
9 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: services/network/test/test_url_loader_factory.h
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Use HttpRequestHeadersUpdateParams in test's FollowRedirectParams
Follow-up of https://crrev.com/c/7835601 that introduced
`network::HttpRequestHeadersUpdateParams`.
This CL shouldn't change the behavior.
Bug: 511306597, 434292502
Change-Id: I92a3191fbde9f1c0bca4b2436f0c6d87096dcf63
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1632625}
Files:
- M content/browser/browsing_topics/browsing_topics_url_loader_unittest.cc
- M content/browser/interest_group/ad_auction_url_loader_interceptor_unittest.cc
- M content/browser/loader/keep_alive_url_loader_service_unittest.cc
- M content/browser/preloading/prefetch/prefetch_service_unittest.cc
- M services/network/test/test_url_loader_factory.cc
- M services/network/test/test_url_loader_factory.h
Change size: M
Delta: 6 files changed, 50 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rakina Zata Amni, +1 by Kenichi Ishibashi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages