WaaP: Accept WebUI metrics when WebUI toolbar is enabled [chromium/src : main]

[Eriko Kurimoto (Gerrit)]

Attention needed from Shunya Shishido

Eriko Kurimoto added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Eriko Kurimoto . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

• Shunya Shishido

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I03087688fba850c79a530ad34c5a5a668db254a8

Gerrit-Change-Number: 7513258

Gerrit-PatchSet: 1

Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>

Gerrit-Comment-Date: Wed, 28 Jan 2026 00:40:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Shunya Shishido (Gerrit)]

Attention needed from Eriko Kurimoto and Lingqi Chi

Shunya Shishido added 2 comments

File chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Line 321, Patchset 1 (Latest): if (base::StartsWith(name, "PageLoad.Internal.",

Shunya Shishido . unresolved

@lin...@chromium.org Do you know what kind of metrics are recorded as "PageLoad.Internal"? I saw you added multiple prerender related metrics here.

Line 338, Patchset 1 (Latest): "PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI",

Shunya Shishido . unresolved

I'm not sure if this direction is a correct approach. `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI` is recorded on the page visit if the page is built with the WebUI right?

This implies that the new WebUI based reload button effects existing `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI` metrics, and that makes the metric less reliable. Rather than excluding the metric here, I feel it's better to record the page load metrics for the WebUI based reload button separately, and not to record `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI/NonTabWebUI`. What do you think?

Open in Gerrit

Related details

Attention is currently required from:

• Eriko Kurimoto
• Lingqi Chi

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I03087688fba850c79a530ad34c5a5a668db254a8

Gerrit-Change-Number: 7513258

Gerrit-PatchSet: 1

Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Lingqi Chi <lin...@chromium.org>

Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Attention: Lingqi Chi <lin...@chromium.org>

Gerrit-Comment-Date: Thu, 29 Jan 2026 04:00:03 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Eriko Kurimoto (Gerrit)]

Attention needed from Lingqi Chi and Shunya Shishido

Eriko Kurimoto added 2 comments

File chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Line 338, Patchset 1: "PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI",

Shunya Shishido . unresolved

I'm not sure if this direction is a correct approach. `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI` is recorded on the page visit if the page is built with the WebUI right?

This implies that the new WebUI based reload button effects existing `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI` metrics, and that makes the metric less reliable. Rather than excluding the metric here, I feel it's better to record the page load metrics for the WebUI based reload button separately, and not to record `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI/NonTabWebUI`. What do you think?

Eriko Kurimoto

Thanks, +1 to introducing separate metrics. As we will work on adding metrics stuff later together, I'll leave this cl for a while.

Line 338, Patchset 1: "PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI",

Shunya Shishido . unresolved

I'm not sure if this direction is a correct approach. `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI` is recorded on the page visit if the page is built with the WebUI right?

This implies that the new WebUI based reload button effects existing `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI` metrics, and that makes the metric less reliable. Rather than excluding the metric here, I feel it's better to record the page load metrics for the WebUI based reload button separately, and not to record `PageLoad.PaintTiming.NavigationToFirstContentfulPaint.WebUI/NonTabWebUI`. What do you think?

Eriko Kurimoto

Thanks,

Open in Gerrit

Related details

Attention is currently required from:

• Lingqi Chi
• Shunya Shishido

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I03087688fba850c79a530ad34c5a5a668db254a8

Gerrit-Change-Number: 7513258

Gerrit-PatchSet: 1

Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Lingqi Chi <lin...@chromium.org>

Gerrit-Attention: Lingqi Chi <lin...@chromium.org>

Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>

Gerrit-Comment-Date: Thu, 29 Jan 2026 10:24:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Shunya Shishido <sisid...@chromium.org>

[Lingqi Chi (Gerrit)]

Attention needed from Shunya Shishido

Lingqi Chi added 1 comment

File chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Line 321, Patchset 1: if (base::StartsWith(name, "PageLoad.Internal.",

Shunya Shishido . unresolved

@lin...@chromium.org Do you know what kind of metrics are recorded as "PageLoad.Internal"? I saw you added multiple prerender related metrics here.

Lingqi Chi

IIRC, we use PageLoad.Internal for debugging and validation, so they are supposed to be short-lived, (but unfortunately some tasks are postponed so we just keep recording these metrics = =)

Open in Gerrit

Related details

Attention is currently required from:

• Shunya Shishido

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I03087688fba850c79a530ad34c5a5a668db254a8

Gerrit-Change-Number: 7513258

Gerrit-PatchSet: 2

Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>

Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Lingqi Chi <lin...@chromium.org>

Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>

Gerrit-Comment-Date: Fri, 30 Jan 2026 04:02:53 +0000