[webium] Remove kInitialWebUIMetrics flag completely [chromium/src : main]
0 views
Skip to first unread message
Ming-Ying Chung (Gerrit)
Aug 18, 2026, 11:20:23 PM (2 days ago) Aug 18
to Thomas Lukaszewicz, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, loading-rev...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, linyuh...@google.com
Attention needed from Thomas Lukaszewicz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Aug 19, 2026, 7:24:17 AM (yesterday) Aug 19
to Ming-Ying Chung, Mingyu Lei, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, dennyh...@google.com, chungshe...@google.com, weiluanw...@google.com, oshima...@chromium.org, byronle...@chromium.org, extension...@chromium.org, menghua...@google.com, chromium-a...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, linyuh...@google.com
Attention needed from Ming-Ying Chung
Thomas Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Ming-Ying Chung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ming-Ying Chung (Gerrit)
Aug 19, 2026, 10:41:55 PM (13 hours ago) Aug 19
to Thomas Lukaszewicz, Mingyu Lei, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, dennyh...@google.com, chungshe...@google.com, weiluanw...@google.com, oshima...@chromium.org, byronle...@chromium.org, extension...@chromium.org, menghua...@google.com, chromium-a...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, linyuh...@google.com
Ming-Ying Chung voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 19, 2026, 10:46:26 PM (13 hours ago) Aug 19
to Ming-Ying Chung, Thomas Lukaszewicz, Mingyu Lei, android-bu...@system.gserviceaccount.com, dennyh...@google.com, chungshe...@google.com, weiluanw...@google.com, oshima...@chromium.org, byronle...@chromium.org, extension...@chromium.org, menghua...@google.com, chromium-a...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, linyuh...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[webium] Remove kInitialWebUIMetrics flag completely
Removes the `kInitialWebUIMetrics` feature flag and enables WebUI
metrics logging unconditionally. Replaces nullable guards on
`WaapUIMetricsService` across UI and observer classes with `CHECK()`
assertions.
To support isolated test executions without feature gating, moves
process-global startup paint flags to anonymous namespace variables and
resets them alongside `startup_metric_utils` in
`WaapUIMetricsService::ResetForTesting()`.
In addition, updates
`ApiGuardDelegateShimlessRMAAppTest` to avoid creating an unused
desktop `Browser` for the Shimless RMA system profile.
Bug: 548337954,525236301
Change-Id: I9b0c758b8de7a110ad3db03003c82b273e86918a
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Commit-Queue: Ming-Ying Chung <my...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1682818}
Files:
- M chrome/browser/chromeos/extensions/telemetry/api/common/api_guard_delegate_unittest.cc
- M chrome/browser/page_load_metrics/observers/initial_webui_page_load_metrics_observer.cc
- M chrome/browser/page_load_metrics/observers/initial_webui_page_load_metrics_observer_browsertest.cc
- M chrome/browser/page_load_metrics/observers/initial_webui_page_load_metrics_observer_unittest.cc
- M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
- M chrome/browser/ui/browser_window/internal/browser_window_features.cc
- M chrome/browser/ui/views/frame/browser_view.cc
- M chrome/browser/ui/views/toolbar/reload_button_unittest.cc
- M chrome/browser/ui/waap/initial_webui_browsertest.cc
- M chrome/browser/ui/waap/initial_webui_window_metrics_manager.cc
- M chrome/browser/ui/waap/initial_webui_window_metrics_manager.h
- M chrome/browser/ui/waap/initial_webui_window_metrics_manager_unittest.cc
- M chrome/browser/ui/waap/waap_ui_metrics_recorder.cc
- M chrome/browser/ui/waap/waap_ui_metrics_recorder.h
- M chrome/browser/ui/waap/waap_ui_metrics_recorder_unittest.cc
- M chrome/browser/ui/waap/waap_ui_metrics_service.cc
- M chrome/browser/ui/waap/waap_ui_metrics_service.h
- M chrome/browser/ui/waap/waap_ui_metrics_service_factory.cc
- M chrome/browser/ui/waap/waap_ui_metrics_service_unittest.cc
- M chrome/browser/ui/waap/waap_utils.cc
- M chrome/browser/ui/waap/waap_utils.h
- M chrome/browser/ui/waap/waap_utils_unittest.cc
- M chrome/browser/ui/webui/webui_toolbar/browser_controls_service.cc
- M chrome/browser/ui/webui/webui_toolbar/browser_controls_service_unittest.cc
- M chrome/common/chrome_features.cc
- M chrome/common/chrome_features.h
Change size: M
Delta: 26 files changed, 75 insertions(+), 147 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages