Revert "Revert "Increase speculative image decode size threshold"" [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
Sep 15, 2025, 3:50:13 PM (3 days ago) Sep 15
to Stefan Zager, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Chromium LUCI CQ, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Philip Rogers and Stefan Zager

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Philip Rogers . resolved

LGTM but please wait for the pinpoint jobs to finish before landing, to confirm the regression has been fixed.

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3ebedb699abc6729c4f73ffde8708a49320bdaa7
Gerrit-Change-Number: 6951635
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 19:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Sep 15, 2025, 4:28:26 PM (3 days ago) Sep 15
to Stefan Zager, Philip Rogers, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Chromium LUCI CQ, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Philip Rogers and Stefan Zager

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17c94966510000

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3ebedb699abc6729c4f73ffde8708a49320bdaa7
Gerrit-Change-Number: 6951635
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 20:28:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Sep 15, 2025, 4:57:45 PM (3 days ago) Sep 15
to Stefan Zager, Philip Rogers, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Chromium LUCI CQ, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Philip Rogers and Stefan Zager

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf-pgo/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10491fd2510000

Gerrit-Comment-Date: Mon, 15 Sep 2025 20:57:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Stefan Zager (Gerrit)

unread,
Sep 15, 2025, 5:09:40 PM (3 days ago) Sep 15
to chrom...@appspot.gserviceaccount.com, Philip Rogers, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Chromium LUCI CQ, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Philip Rogers

Stefan Zager voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3ebedb699abc6729c4f73ffde8708a49320bdaa7
Gerrit-Change-Number: 6951635
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 21:09:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 15, 2025, 5:18:58 PM (3 days ago) Sep 15
to Stefan Zager, chrom...@appspot.gserviceaccount.com, Philip Rogers, chromium...@chromium.org, Daniel Cheng, Nate Chapin, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "Revert "Increase speculative image decode size threshold""

This reverts:

https://chromium-review.googlesource.com/c/chromium/src/+/6934770

The speedometer regression should be mitigated by:

https://chromium-review.googlesource.com/c/chromium/src/+/6950963
Bug: chromium:441844763,chromium:378623805
Change-Id: I3ebedb699abc6729c4f73ffde8708a49320bdaa7
Reviewed-by: Philip Rogers <p...@chromium.org>
Commit-Queue: Stefan Zager <sza...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1515712}
Files:
  • M third_party/blink/renderer/core/frame/web_frame_widget_test.cc
  • M third_party/blink/renderer/core/loader/resource/image_resource.h
Change size: S
Delta: 2 files changed, 13 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Rogers
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3ebedb699abc6729c4f73ffde8708a49320bdaa7
Gerrit-Change-Number: 6951635
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages