Make SharedArrayBuffer settable by the browser [chromium/src : main]

0 views
Skip to first unread message

Peter Pakkenberg (Gerrit)

unread,
May 2, 2025, 7:49:05 AMMay 2
to Camille Lamy, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Camille Lamy

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Camille Lamy
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id0fbc0bf2f8a0353e8388ef73c8c0f19ac06f311
Gerrit-Change-Number: 6458999
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Pakkenberg <pb...@chromium.org>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Peter Pakkenberg <pb...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Camille Lamy <cl...@chromium.org>
Gerrit-Comment-Date: Fri, 02 May 2025 11:48:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Camille Lamy (Gerrit)

unread,
May 21, 2025, 8:09:41 AMMay 21
to Peter Pakkenberg, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Peter Pakkenberg

Camille Lamy added 2 comments

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Camille Lamy . resolved

Beyond the question of whether we should be doing this at all, I have one question about the implementation below.

File third_party/blink/renderer/core/execution_context/execution_context.cc
Line 231, Patchset 9 (Latest): if (SecurityPolicy::IsSharedArrayBufferAlwaysAllowedForOrigin(origin))
Camille Lamy . unresolved

Have you considered using this function instead, which is what Fuschia is using to allow list the origin? This would avoid having to declare and pass new navigation parameters.

Open in Gerrit

Related details

Attention is currently required from:
  • Peter Pakkenberg
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id0fbc0bf2f8a0353e8388ef73c8c0f19ac06f311
    Gerrit-Change-Number: 6458999
    Gerrit-PatchSet: 9
    Gerrit-Owner: Peter Pakkenberg <pb...@chromium.org>
    Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
    Gerrit-Reviewer: Peter Pakkenberg <pb...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Peter Pakkenberg <pb...@chromium.org>
    Gerrit-Comment-Date: Wed, 21 May 2025 12:09:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Peter Pakkenberg (Gerrit)

    unread,
    Sep 16, 2025, 5:59:01 AM (7 days ago) Sep 16
    to Code Review Nudger, Camille Lamy, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org

    Peter Pakkenberg abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages