[SRI Message Signatures] Remove feature flags for shipped features. [chromium/src : main]
0 views
Skip to first unread message
Mike West (Gerrit)
Oct 22, 2025, 2:15:58 PMOct 22
to Adam Rice, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Adam Rice
Mike West added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mike West . resolved
Hey Adam, would you mind taking a look at this CL to drop a shipped flag in a way that I hope is a no-op?
Related details
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Oct 27, 2025, 8:49:01 PM (10 days ago) Oct 27
to Mike West, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Mike West
Adam Rice voted and added 2 comments![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
2 comments
Patchset-level comments
Adam Rice . resolved
lgtm, sorry for the delayed review.
File third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
Line 634, Patchset 1 (Latest):
bool SignaturesEnabled() { return GetParam(); }Adam Rice . unresolved
Remove?
Related details
Attention is currently required from:
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Nov 5, 2025, 7:18:23 AM (yesterday) Nov 5
to Adam Rice, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Mike West voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mike West
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
Line 634, Patchset 1:
bool SignaturesEnabled() { return GetParam(); }Adam Rice . resolved
Mike WestRemove?
Renamed to `InlineSignaturesEnabled`: we still need this for that feature, but hopefully we can ship it as well and get rid of this.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 5, 2025, 7:22:13 AM (yesterday) Nov 5
to Mike West, Adam Rice, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[SRI Message Signatures] Remove feature flags for shipped features.
This CL removes SRI Message Signature's feature flags in the network
stack and Blink. We shipped them in M141, and we're unlikely to need to
remove them at this point.
Change-Id: I0130f3c2cf07b55eccf280ac4f60e10e5df86be5
Commit-Queue: Mike West <mk...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540566}
Files:
- M chrome/browser/about_flags.cc
- M chrome/browser/flag_descriptions.h
- M content/child/runtime_features.cc
- M services/network/public/cpp/features.cc
- M services/network/public/cpp/features.h
- M services/network/public/cpp/sri_message_signatures.cc
- M services/network/public/cpp/sri_message_signatures.h
- M services/network/public/cpp/sri_message_signatures_unittest.cc
- M testing/variations/fieldtrial_testing_config.json
- M third_party/blink/renderer/platform/loader/subresource_integrity.cc
- M third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: M
Delta: 12 files changed, 32 insertions(+), 189 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adam Rice
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages