Alexei Svitkine (Gerrit)

unread,

Dec 12, 2025, 5:39:41 PM (4 days ago) Dec 12

to Mohamed Amir Yosef, Chromium Metrics Reviews, Kaan Icer, Christian Biesinger, AyeAye, Chromium LUCI CQ, Robert Kaplow, blink-re...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, blink-...@chromium.org

Attention needed from Mohamed Amir Yosef and Robert Kaplow

Alexei Svitkine added 1 comment

File components/page_load_metrics/browser/observers/use_counter/ukm_features.cc

Line 11, Patchset 1 (Latest):// (or highly likely to be) rare, e.g. <1% of page views as measured by UMA.

Alexei Svitkine . unresolved

It's not clear from the CL desc that this requirement is met. If it is, mention explicitly.

If it's unknown, then it can instead be added as a standalone UKM metric so it can be sampled automatically accordingly.

Open in Gerrit

Related details

Attention is currently required from:

Mohamed Amir Yosef
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mohamed Amir Yosef (Gerrit)

unread,

Dec 12, 2025, 5:43:57 PM (4 days ago) Dec 12

to Alexei Svitkine, Chromium Metrics Reviews, Kaan Icer, Christian Biesinger, AyeAye, Chromium LUCI CQ, Robert Kaplow, blink-re...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, blink-...@chromium.org

Attention needed from Alexei Svitkine and Robert Kaplow

Mohamed Amir Yosef voted and added 1 comment

Votes added by Mohamed Amir Yosef

Commit-Queue

+1

1 comment

File components/page_load_metrics/browser/observers/use_counter/ukm_features.cc

Line 11, Patchset 1:// (or highly likely to be) rare, e.g. <1% of page views as measured by UMA.

Alexei Svitkine . resolved

It's not clear from the CL desc that this requirement is met. If it is, mention explicitly.
If it's unknown, then it can instead be added as a standalone UKM metric so it can be sampled automatically accordingly.

Mohamed Amir Yosef

Done

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christian Biesinger (Gerrit)

unread,

Dec 12, 2025, 5:49:20 PM (4 days ago) Dec 12

to Mohamed Amir Yosef, Christian Biesinger, Alexei Svitkine, Chromium Metrics Reviews, Kaan Icer, AyeAye, Chromium LUCI CQ, Robert Kaplow, blink-re...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, blink-...@chromium.org

Attention needed from Alexei Svitkine, Mohamed Amir Yosef and Robert Kaplow

Christian Biesinger voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Mohamed Amir Yosef
Robert Kaplow

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Robert Kaplow (Gerrit)

unread,

Dec 15, 2025, 10:04:05 AM (yesterday) Dec 15

to Mohamed Amir Yosef, Christian Biesinger, Alexei Svitkine, Chromium Metrics Reviews, Kaan Icer, AyeAye, Chromium LUCI CQ, blink-re...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, blink-...@chromium.org

Attention needed from Alexei Svitkine and Mohamed Amir Yosef

Robert Kaplow voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Mohamed Amir Yosef (Gerrit)

unread,

Dec 15, 2025, 10:22:59 AM (yesterday) Dec 15

to Robert Kaplow, Christian Biesinger, Alexei Svitkine, Chromium Metrics Reviews, Kaan Icer, AyeAye, Chromium LUCI CQ, blink-re...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, blink-...@chromium.org

Attention needed from Alexei Svitkine

Mohamed Amir Yosef voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 15, 2025, 11:21:27 AM (yesterday) Dec 15

to Mohamed Amir Yosef, Robert Kaplow, Christian Biesinger, Alexei Svitkine, Chromium Metrics Reviews, Kaan Icer, AyeAye, blink-re...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org, asvitkine...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[DC] Add UseCounter for unknown DC protocols

This CL adds a new WebFeature kDigitalCredentialsProtocolUnknown to
track usages of the Digital Credentials API with protocols that are not
explicitly recognized/counted. This helps in understanding the
prevalence of other protocols being used in the wild.

The feature is also added to UKM to allow for more detailed analysis if
needed, since DC API is very rarely (much less than 0.01%) used in the
moment, and for this specific bucket, it will be even more rare.

FWIW: All DC API calls are added to the UKM already
kIdentityDigitalCredentials.

Tests are added to ensure the counter works as expected.

Bug: 447566717

Change-Id: Icd59f04362fe50596265dff936c50b9fc10821bf

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7255144

Reviewed-by: Christian Biesinger <cbies...@chromium.org>

Reviewed-by: Robert Kaplow <rka...@chromium.org>

Commit-Queue: Mohamed Amir Yosef <ma...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1558750}

Files:

M components/page_load_metrics/browser/observers/use_counter/ukm_features.cc
M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
M third_party/blink/renderer/modules/credentialmanagement/digital_identity_credential.cc
M third_party/blink/renderer/modules/credentialmanagement/digital_identity_credential_protocol_test.cc
M tools/metrics/histograms/metadata/blink/enums.xml

Change size: S

Delta: 5 files changed, 48 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Robert Kaplow, +1 by Christian Biesinger

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[DC] Add UseCounter for unknown DC protocols [chromium/src : main]

Alexei Svitkine (Gerrit)

Alexei Svitkine added 1 comment

Related details

Mohamed Amir Yosef (Gerrit)

Mohamed Amir Yosef voted and added 1 comment

Votes added by Mohamed Amir Yosef

1 comment

Related details

Christian Biesinger (Gerrit)

Christian Biesinger voted Code-Review+1

Related details

Robert Kaplow (Gerrit)

Robert Kaplow voted Code-Review+1

Related details

Mohamed Amir Yosef (Gerrit)

Mohamed Amir Yosef voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information