Remove Topics API behind disable_privacy_sandbox_apis flag. [chromium/src : main]

0 views
Skip to first unread message

Josh Karlin (Gerrit)

unread,
2:59 PM (1 hour ago) 2:59 PM
to Xinan Lin, Josh Karlin, Yao Xiao, Nate Chapin, Yoav Weiss (@Shopify), android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, James Maclean, blink-re...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, loading...@chromium.org, navigation...@chromium.org, creis...@chromium.org, net-r...@chromium.org
Attention needed from Xinan Lin and Yao Xiao

Josh Karlin added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Josh Karlin . resolved

Drive by comment:

Let's not land this CL. It adds an arg with a lot of insertion points into the code for a feature that we're actively working on deprecating. If you'd like to remove it downstream that's fine, but let's not upstream it.

Open in Gerrit

Related details

Attention is currently required from:
  • Xinan Lin
  • Yao Xiao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I019a95be0d310540f83b5fffe684a1b4be233a18
Gerrit-Change-Number: 7801142
Gerrit-PatchSet: 10
Gerrit-Owner: Xinan Lin <linx...@chromium.org>
Gerrit-Reviewer: Xinan Lin <linx...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Xinan Lin <linx...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Apr 2026 18:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Xinan Lin (Gerrit)

unread,
3:34 PM (1 hour ago) 3:34 PM
to Josh Karlin, Yao Xiao, Nate Chapin, Yoav Weiss (@Shopify), android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, James Maclean, blink-re...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, loading...@chromium.org, navigation...@chromium.org, creis...@chromium.org, net-r...@chromium.org
Attention needed from Josh Karlin and Yao Xiao

Xinan Lin added 1 comment

Patchset-level comments
Josh Karlin . unresolved

Drive by comment:

Let's not land this CL. It adds an arg with a lot of insertion points into the code for a feature that we're actively working on deprecating. If you'd like to remove it downstream that's fine, but let's not upstream it.

Xinan Lin

So may I know what the plan to deprecate them? You still have to remove those lines in the future milestones, right? The build arg could isolate those changes from current release and allow people to remove them gradually. WDYT?

Open in Gerrit

Related details

Attention is currently required from:
  • Josh Karlin
  • Yao Xiao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I019a95be0d310540f83b5fffe684a1b4be233a18
    Gerrit-Change-Number: 7801142
    Gerrit-PatchSet: 10
    Gerrit-Owner: Xinan Lin <linx...@chromium.org>
    Gerrit-Reviewer: Xinan Lin <linx...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Josh Karlin <jka...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Josh Karlin <jka...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 19:33:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Josh Karlin <jka...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Xinan Lin (Gerrit)

    unread,
    3:34 PM (1 hour ago) 3:34 PM
    to Josh Karlin, Yao Xiao, Nate Chapin, Yoav Weiss (@Shopify), android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, James Maclean, blink-re...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, blink-rev...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, alexmo...@chromium.org, loading...@chromium.org, navigation...@chromium.org, creis...@chromium.org, net-r...@chromium.org
    Attention needed from Josh Karlin and Yao Xiao

    Xinan Lin voted Code-Review-1

    Code-Review-1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Josh Karlin
    • Yao Xiao
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is blockingCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I019a95be0d310540f83b5fffe684a1b4be233a18
      Gerrit-Change-Number: 7801142
      Gerrit-PatchSet: 10
      Gerrit-Owner: Xinan Lin <linx...@chromium.org>
      Gerrit-Reviewer: Xinan Lin <linx...@chromium.org>
      Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Josh Karlin <jka...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Attention: Yao Xiao <yao...@chromium.org>
      Gerrit-Attention: Josh Karlin <jka...@chromium.org>
      Gerrit-Comment-Date: Wed, 29 Apr 2026 19:34:11 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      blocking_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages