Cleanup remaining AsyncSetCookie artifacts [chromium/src : main]

0 views
Skip to first unread message

Gabriel Charette (Gerrit)

unread,
Aug 19, 2026, 2:45:10 PM (21 hours ago) Aug 19
to Nate Chapin, Bo Liu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, android-web...@chromium.org
Attention needed from Bo Liu and Nate Chapin

Gabriel Charette voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7be31be2f17d5d77226184923d078ae746c9349
Gerrit-Change-Number: 8262589
Gerrit-PatchSet: 7
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Bo Liu <bo...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 18:45:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
Aug 19, 2026, 2:46:04 PM (21 hours ago) Aug 19
to Gabriel Charette, Bo Liu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, android-web...@chromium.org
Attention needed from Bo Liu and Gabriel Charette

Nate Chapin voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
  • Gabriel Charette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7be31be2f17d5d77226184923d078ae746c9349
Gerrit-Change-Number: 8262589
Gerrit-PatchSet: 7
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Gabriel Charette <g...@chromium.org>
Gerrit-Attention: Bo Liu <bo...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 18:45:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Gabriel Charette (Gerrit)

unread,
Aug 19, 2026, 2:47:24 PM (21 hours ago) Aug 19
to Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, android-web...@chromium.org

Gabriel Charette voted and added 1 comment

Votes added by Gabriel Charette

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Gabriel Charette . resolved

-Bo, not sure why Gerrit thought I needed them but the flags are approved by anyone, including self, turns out.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7be31be2f17d5d77226184923d078ae746c9349
Gerrit-Change-Number: 8262589
Gerrit-PatchSet: 7
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 18:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 19, 2026, 2:53:36 PM (21 hours ago) Aug 19
to Gabriel Charette, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, android-web...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Cleanup remaining AsyncSetCookie artifacts

AsyncSetCookie has launched and its feature gate was removed in
crrev.com/c/7819154 (crbug.com/497723649). This CL cleans up the
remaining artifacts:
1. Removes the leftover duplicate entry in ProductionSupportedFlagList.java.
2. Updates a stale comment in cookie_jar.cc referencing the disabled state.

Bug: b/483482004
Change-Id: Ib7be31be2f17d5d77226184923d078ae746c9349
Commit-Queue: Gabriel Charette <g...@chromium.org>
Auto-Submit: Gabriel Charette <g...@chromium.org>
Commit-Queue: Nate Chapin <jap...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1682518}
Files:
  • M third_party/blink/renderer/core/loader/cookie_jar.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Chapin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib7be31be2f17d5d77226184923d078ae746c9349
Gerrit-Change-Number: 8262589
Gerrit-PatchSet: 8
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages