CSP checks for `rel=modulepreload` without `as`. [chromium/src : main]
0 views
Skip to first unread message
Mike West (Gerrit)
Apr 1, 2026, 11:57:02 AM (2 days ago) Apr 1
to Antonio Sartori, Mike West, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Attention needed from Antonio Sartori
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Antonio Sartori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Sartori (Gerrit)
Apr 2, 2026, 2:41:20 AM (yesterday) Apr 2
to Mike West, Mike West, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Attention needed from Mike West
Antonio Sartori voted and added 2 comments![]( "Open in Gerrit")
Votes added by Antonio Sartori
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Antonio Sartori . unresolved
Thanks! LGTM, maybe follow up with a CL adding a WPT for this (I guess this is currently untested)?
Commit Message
Line 11, Patchset 1 (Latest):
Bug: 497207014Antonio Sartori . unresolved
Is this the right bug? I just quickly looked at it, maybe I am missing something :)
Related details
Attention is currently required from:
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Apr 2, 2026, 7:06:24 AM (yesterday) Apr 2
to Antonio Sartori, Mike West, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Mike West voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mike West
| Commit-Queue | +2 |
Thanks! LGTM, maybe follow up with a CL adding a WPT for this (I guess this is currently untested)?
Mike West
I think that would be a good idea! I am not sure when I'll get to it, but I agree that I should.
Commit Message
Is this the right bug? I just quickly looked at it, maybe I am missing something :)
Mike West
Indeed. We have too many bugs. :) This was supposed to be 497435665, I've updated the message accordingly.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Apr 2, 2026, 10:35:24 AM (yesterday) Apr 2
to Arthur Sonzogni, Antonio Sartori, Mike West, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Attention needed from Arthur Sonzogni
Mike West added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mike West . resolved
I misread the directory. Antonio doesn't own anything here. 😊
Arthur, perhaps you can stamp it?
Related details
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
4:22 AM (17 hours ago) 4:22 AM
to Mike West, Antonio Sartori, Mike West, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Attention needed from Mike West
Arthur Sonzogni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
11:43 AM (9 hours ago) 11:43 AM
to Arthur Sonzogni, Antonio Sartori, Mike West, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org
Mike West voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:57 PM (8 hours ago) 12:57 PM
to Mike West, Arthur Sonzogni, Antonio Sartori, Mike West, chromium...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CSP checks for `rel=modulepreload` without `as`.
We should be treating these as script.
Bug: 497435665
Change-Id: Iddc8781fa738dbdabd6c6aee0b157e26dbf4e6ae
Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
Reviewed-by: Antonio Sartori <antonio...@chromium.org>
Commit-Queue: Mike West <mk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609832}
Files:
- M content/browser/loader/navigation_early_hints_manager.cc
- M content/browser/loader/navigation_early_hints_manager_unittest.cc
Change size: M
Delta: 2 files changed, 63 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Antonio Sartori, +1 by Arthur Sonzogni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages