Migrates DetectedAsAd from ControllableHttpResponse to ExpectationHandler [chromium/src : main]

0 views
Skip to first unread message

Shunya Shishido (Gerrit)

unread,
Jun 10, 2026, 4:00:36 AM (yesterday) Jun 10
to Jatin Mittal, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Jatin Mittal and Nicolás Peña

Shunya Shishido voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jatin Mittal
  • Nicolás Peña
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I044af3d934ef17c0e454a7a3d1a463757e7d4c78
Gerrit-Change-Number: 7915966
Gerrit-PatchSet: 1
Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>
Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>
Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-CC: Josh Karlin <jka...@chromium.org>
Gerrit-CC: Yao Xiao <yao...@chromium.org>
Gerrit-Attention: Nicolás Peña <n...@chromium.org>
Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>
Gerrit-Comment-Date: Wed, 10 Jun 2026 07:59:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicolás Peña (Gerrit)

unread,
Jun 10, 2026, 11:14:38 AM (20 hours ago) Jun 10
to Jatin Mittal, Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Jatin Mittal

Nicolás Peña voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jatin Mittal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I044af3d934ef17c0e454a7a3d1a463757e7d4c78
    Gerrit-Change-Number: 7915966
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>
    Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>
    Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Josh Karlin <jka...@chromium.org>
    Gerrit-CC: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Jatin Mittal <jatin...@microsoft.com>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 15:14:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jatin Mittal (Gerrit)

    unread,
    5:01 AM (2 hours ago) 5:01 AM
    to Nicolás Peña, Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

    Jatin Mittal voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I044af3d934ef17c0e454a7a3d1a463757e7d4c78
    Gerrit-Change-Number: 7915966
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>
    Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>
    Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-CC: Josh Karlin <jka...@chromium.org>
    Gerrit-CC: Yao Xiao <yao...@chromium.org>
    Gerrit-Comment-Date: Thu, 11 Jun 2026 09:01:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    5:44 AM (1 hour ago) 5:44 AM
    to Jatin Mittal, Nicolás Peña, Shunya Shishido, chromium...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Migrates DetectedAsAd from ControllableHttpResponse to ExpectationHandler

    The test only validates request/response behavior using a static response
    and does not require dynamic response generation, delayed completion, or
    request-dependent handling. Refactoring to `ExpectationHandler`
    simplifies the embedded test server setup while preserving existing test
    coverage and behavior.
    Bug: 511876973
    Change-Id: I044af3d934ef17c0e454a7a3d1a463757e7d4c78
    Reviewed-by: Shunya Shishido <sisid...@chromium.org>
    Reviewed-by: Nicolás Peña <n...@chromium.org>
    Commit-Queue: Jatin Mittal <jatin...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1645227}
    Files:
    • M chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc
    Change size: M
    Delta: 1 file changed, 23 insertions(+), 37 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nicolás Peña, +1 by Shunya Shishido
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I044af3d934ef17c0e454a7a3d1a463757e7d4c78
    Gerrit-Change-Number: 7915966
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jatin Mittal <jatin...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jatin Mittal <jatin...@microsoft.com>
    Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages