Migrates DetectedAsAd from ControllableHttpResponse to ExpectationHandler [chromium/src : main]
0 views
Skip to first unread message
Shunya Shishido (Gerrit)
Jun 10, 2026, 4:00:36 AM (yesterday) Jun 10
to Jatin Mittal, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Jatin Mittal and Nicolás Peña
Shunya Shishido voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jatin Mittal
- Nicolás Peña
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Jun 10, 2026, 11:14:38 AM (20 hours ago) Jun 10
to Jatin Mittal, Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Jatin Mittal
Nicolás Peña voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jatin Mittal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jatin Mittal (Gerrit)
5:01 AM (2 hours ago) 5:01 AM
to Nicolás Peña, Shunya Shishido, Chromium LUCI CQ, chromium...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Jatin Mittal voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:44 AM (1 hour ago) 5:44 AM
to Jatin Mittal, Nicolás Peña, Shunya Shishido, chromium...@chromium.org, Josh Karlin, Yao Xiao, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrates DetectedAsAd from ControllableHttpResponse to ExpectationHandler
The test only validates request/response behavior using a static response
and does not require dynamic response generation, delayed completion, or
request-dependent handling. Refactoring to `ExpectationHandler`
simplifies the embedded test server setup while preserving existing test
coverage and behavior.
Bug: 511876973
Change-Id: I044af3d934ef17c0e454a7a3d1a463757e7d4c78
Reviewed-by: Shunya Shishido <sisid...@chromium.org>
Reviewed-by: Nicolás Peña <n...@chromium.org>
Commit-Queue: Jatin Mittal <jatin...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1645227}
Files:
- M chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc
Change size: M
Delta: 1 file changed, 23 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nicolás Peña, +1 by Shunya Shishido
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages