[CSS Modules] Support JSON and CSS in <link type=modulepreload> [chromium/src : main]

0 views
Skip to first unread message

Kurt Catti-Schmidt (Gerrit)

unread,
Jan 23, 2026, 3:51:17 PM (7 days ago) Jan 23
to Noam Rosenthal, Dan Clark, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Dan Clark, Kurt Catti-Schmidt and Noam Rosenthal

Kurt Catti-Schmidt voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Kurt Catti-Schmidt
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
Gerrit-Change-Number: 7216960
Gerrit-PatchSet: 12
Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Mason Freed <mas...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Fri, 23 Jan 2026 20:51:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kurt Catti-Schmidt (Gerrit)

unread,
Jan 23, 2026, 4:16:42 PM (7 days ago) Jan 23
to Yoav Weiss (@Shopify), Noam Rosenthal, Dan Clark, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Dan Clark, Noam Rosenthal and Yoav Weiss (@Shopify)

Kurt Catti-Schmidt voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Noam Rosenthal
  • Yoav Weiss (@Shopify)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
Gerrit-Change-Number: 7216960
Gerrit-PatchSet: 13
Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Mason Freed <mas...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Dan Clark <dan...@microsoft.com>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Fri, 23 Jan 2026 21:16:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kurt Catti-Schmidt (Gerrit)

unread,
Jan 23, 2026, 4:21:42 PM (7 days ago) Jan 23
to Yoav Weiss (@Shopify), Noam Rosenthal, Dan Clark, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Dan Clark, Noam Rosenthal and Yoav Weiss (@Shopify)

Kurt Catti-Schmidt added 1 comment

File third_party/blink/renderer/core/loader/preload_helper.cc
Line 633, Patchset 13 (Latest): // as="script". The `kModulePreloadStyleJson` feature flag enables as="style"
Kurt Catti-Schmidt . unresolved

Need to update this to `ModulePreloadStyleJsonEnabled`

Open in Gerrit

Related details

Attention is currently required from:
  • Dan Clark
  • Noam Rosenthal
  • Yoav Weiss (@Shopify)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
    Gerrit-Change-Number: 7216960
    Gerrit-PatchSet: 13
    Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-CC: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Dan Clark <dan...@microsoft.com>
    Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Fri, 23 Jan 2026 21:21:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dan Clark (Gerrit)

    unread,
    Jan 23, 2026, 4:38:01 PM (7 days ago) Jan 23
    to Kurt Catti-Schmidt, Yoav Weiss (@Shopify), Noam Rosenthal, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
    Attention needed from Kurt Catti-Schmidt, Noam Rosenthal and Yoav Weiss (@Shopify)

    Dan Clark voted and added 2 comments

    Votes added by Dan Clark

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 13 (Latest):
    Dan Clark . resolved

    LGTM, thanks for getting this done.

    File third_party/blink/renderer/core/loader/preload_helper.cc
    Line 686, Patchset 13 (Latest): DCHECK_NE(context_type, mojom::blink::RequestContextType::UNSPECIFIED);
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kurt Catti-Schmidt
    • Noam Rosenthal
    • Yoav Weiss (@Shopify)
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
        Gerrit-Change-Number: 7216960
        Gerrit-PatchSet: 13
        Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
        Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
        Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-CC: Mason Freed <mas...@chromium.org>
        Gerrit-CC: Nate Chapin <jap...@chromium.org>
        Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
        Gerrit-Comment-Date: Fri, 23 Jan 2026 21:37:52 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Kurt Catti-Schmidt (Gerrit)

        unread,
        Jan 26, 2026, 11:21:06 AM (5 days ago) Jan 26
        to Mirko Bonadei, Jerome Jiang, Dan Clark, Yoav Weiss (@Shopify), Noam Rosenthal, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, chrome-intelligence-te...@google.com, devtools...@chromium.org, eme-r...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, fgal...@chromium.org, net-r...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
        Attention needed from Dan Clark, Noam Rosenthal and Yoav Weiss (@Shopify)

        Kurt Catti-Schmidt voted and added 2 comments

        Votes added by Kurt Catti-Schmidt

        Commit-Queue+1

        2 comments

        File third_party/blink/renderer/core/loader/preload_helper.cc
        Line 633, Patchset 13: // as="script". The `kModulePreloadStyleJson` feature flag enables as="style"
        Kurt Catti-Schmidt . resolved

        Need to update this to `ModulePreloadStyleJsonEnabled`

        Kurt Catti-Schmidt

        Done

        Line 686, Patchset 13: DCHECK_NE(context_type, mojom::blink::RequestContextType::UNSPECIFIED);
        Dan Clark . resolved
        Kurt Catti-Schmidt

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Dan Clark
        • Noam Rosenthal
        • Yoav Weiss (@Shopify)
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
            Gerrit-Change-Number: 7216960
            Gerrit-PatchSet: 15
            Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
            Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
            Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
            Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
            Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
            Gerrit-CC: Jerome Jiang <ji...@chromium.org>
            Gerrit-CC: Mason Freed <mas...@chromium.org>
            Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
            Gerrit-CC: Nate Chapin <jap...@chromium.org>
            Gerrit-Attention: Dan Clark <dan...@microsoft.com>
            Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
            Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
            Gerrit-Comment-Date: Mon, 26 Jan 2026 16:20:57 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Comment-In-Reply-To: Kurt Catti-Schmidt <ksc...@microsoft.com>
            Comment-In-Reply-To: Dan Clark <dan...@microsoft.com>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Dan Clark (Gerrit)

            unread,
            Jan 26, 2026, 2:49:58 PM (4 days ago) Jan 26
            to Kurt Catti-Schmidt, Mirko Bonadei, Jerome Jiang, Yoav Weiss (@Shopify), Noam Rosenthal, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, chrome-intelligence-te...@google.com, devtools...@chromium.org, eme-r...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, fgal...@chromium.org, net-r...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
            Attention needed from Kurt Catti-Schmidt, Noam Rosenthal and Yoav Weiss (@Shopify)

            Dan Clark voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Kurt Catti-Schmidt
            • Noam Rosenthal
            • Yoav Weiss (@Shopify)
              Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement is not satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
                Gerrit-Change-Number: 7216960
                Gerrit-PatchSet: 15
                Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
                Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
                Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
                Gerrit-CC: Jerome Jiang <ji...@chromium.org>
                Gerrit-CC: Mason Freed <mas...@chromium.org>
                Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
                Gerrit-CC: Nate Chapin <jap...@chromium.org>
                Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
                Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
                Gerrit-Comment-Date: Mon, 26 Jan 2026 19:49:49 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                unsatisfied_requirement
                open
                diffy

                Yoav Weiss (@Shopify) (Gerrit)

                unread,
                1:49 AM (22 hours ago) 1:49 AM
                to Kurt Catti-Schmidt, Dan Clark, Mirko Bonadei, Jerome Jiang, Noam Rosenthal, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, chrome-intelligence-te...@google.com, devtools...@chromium.org, eme-r...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, fgal...@chromium.org, net-r...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
                Attention needed from Kurt Catti-Schmidt and Noam Rosenthal

                Yoav Weiss (@Shopify) voted and added 1 comment

                Votes added by Yoav Weiss (@Shopify)

                Code-Review+1

                1 comment

                Patchset-level comments
                File-level comment, Patchset 15 (Latest):
                Yoav Weiss (@Shopify) . resolved

                LGTM! Apologies for the delay..

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Kurt Catti-Schmidt
                • Noam Rosenthal
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
                Gerrit-Change-Number: 7216960
                Gerrit-PatchSet: 15
                Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
                Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
                Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
                Gerrit-CC: Jerome Jiang <ji...@chromium.org>
                Gerrit-CC: Mason Freed <mas...@chromium.org>
                Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
                Gerrit-CC: Nate Chapin <jap...@chromium.org>
                Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
                Gerrit-Comment-Date: Fri, 30 Jan 2026 06:49:38 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy

                Blink W3C Test Autoroller (Gerrit)

                unread,
                1:58 AM (22 hours ago) 1:58 AM
                to Kurt Catti-Schmidt, Yoav Weiss (@Shopify), Dan Clark, Mirko Bonadei, Jerome Jiang, Noam Rosenthal, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, chrome-intelligence-te...@google.com, devtools...@chromium.org, eme-r...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, fgal...@chromium.org, net-r...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
                Attention needed from Kurt Catti-Schmidt and Noam Rosenthal

                Message from Blink W3C Test Autoroller

                Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57436.

                When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

                WPT Export docs:
                https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Kurt Catti-Schmidt
                • Noam Rosenthal
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
                Gerrit-Change-Number: 7216960
                Gerrit-PatchSet: 15
                Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
                Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
                Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
                Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
                Gerrit-CC: Jerome Jiang <ji...@chromium.org>
                Gerrit-CC: Mason Freed <mas...@chromium.org>
                Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
                Gerrit-CC: Nate Chapin <jap...@chromium.org>
                Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
                Gerrit-Comment-Date: Fri, 30 Jan 2026 06:58:05 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: No
                satisfied_requirement
                open
                diffy

                Kurt Catti-Schmidt (Gerrit)

                unread,
                12:45 PM (11 hours ago) 12:45 PM
                to Blink W3C Test Autoroller, Yoav Weiss (@Shopify), Dan Clark, Mirko Bonadei, Jerome Jiang, Noam Rosenthal, Mason Freed, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, chrome-intelligence-te...@google.com, devtools...@chromium.org, eme-r...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, fgal...@chromium.org, net-r...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
                Attention needed from Noam Rosenthal

                Kurt Catti-Schmidt voted Commit-Queue+2

                Commit-Queue+2
                Open in Gerrit

                Related details

                Attention is currently required from:
                • Noam Rosenthal
                Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
                Gerrit-Comment-Date: Fri, 30 Jan 2026 17:45:43 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy

                Chromium LUCI CQ (Gerrit)

                unread,
                2:02 PM (10 hours ago) 2:02 PM
                to Kurt Catti-Schmidt, Blink W3C Test Autoroller, Yoav Weiss (@Shopify), Dan Clark, Mirko Bonadei, Jerome Jiang, Noam Rosenthal, Mason Freed, AyeAye, chromium...@chromium.org, Nate Chapin, chrome-intelligence-te...@google.com, devtools...@chromium.org, eme-r...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, fgal...@chromium.org, net-r...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org

                Chromium LUCI CQ submitted the change

                Change information

                Commit message:
                [CSS Modules] Support JSON and CSS in <link type=modulepreload>

                Adds support for preloading JSON and CSS modules via the "as" parameter
                using the same fetching mechanism that script module preloads use.

                Basic tests are added in this CL, and more detailed tests are coming
                straight to WPT via
                https://github.com/web-platform-tests/wpt/pull/56617.
                Bug: 466888680
                Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
                Reviewed-by: Dan Clark <dan...@microsoft.com>
                Commit-Queue: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Reviewed-by: Yoav Weiss (@Shopify) <yoav...@chromium.org>
                Cr-Commit-Position: refs/heads/main@{#1577402}
                Files:
                • M third_party/blink/renderer/core/loader/preload_helper.cc
                • M third_party/blink/renderer/platform/runtime_enabled_features.json5
                • A third_party/blink/web_tests/external/wpt/preload/modulepreload-json.html
                • A third_party/blink/web_tests/external/wpt/preload/modulepreload-style.html
                • A third_party/blink/web_tests/external/wpt/preload/resources/dummy.json
                Change size: M
                Delta: 5 files changed, 98 insertions(+), 8 deletions(-)
                Branch: refs/heads/main
                Submit Requirements:
                • requirement satisfiedCode-Review: +1 by Dan Clark, +1 by Yoav Weiss (@Shopify)
                Open in Gerrit
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: merged
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
                Gerrit-Change-Number: 7216960
                Gerrit-PatchSet: 16
                Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
                Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
                Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
                Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
                open
                diffy
                satisfied_requirement

                Blink W3C Test Autoroller (Gerrit)

                unread,
                4:20 PM (7 hours ago) 4:20 PM
                to Chromium LUCI CQ, Kurt Catti-Schmidt, Yoav Weiss (@Shopify), Dan Clark, Mirko Bonadei, Jerome Jiang, Noam Rosenthal, Mason Freed, AyeAye, chromium...@chromium.org, Nate Chapin, chrome-intelligence-te...@google.com, devtools...@chromium.org, eme-r...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, fgal...@chromium.org, net-r...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org

                Message from Blink W3C Test Autoroller

                The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57436

                Open in Gerrit

                Related details

                Attention set is empty
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I3f08d7a1c48d4e46e500538b5fab32f2b4f41b02
                Gerrit-Change-Number: 7216960
                Gerrit-PatchSet: 16
                Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>
                Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
                Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
                Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
                Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
                Gerrit-CC: Jerome Jiang <ji...@chromium.org>
                Gerrit-CC: Mason Freed <mas...@chromium.org>
                Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
                Gerrit-CC: Nate Chapin <jap...@chromium.org>
                Gerrit-Comment-Date: Fri, 30 Jan 2026 21:20:51 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: No
                satisfied_requirement
                open
                diffy
                Reply all
                Reply to author
                Forward
                0 new messages