Migrate LiveDocumentSet to DCHECK_IS_ON() macro guard. [chromium/src : main]

0 views
Skip to first unread message

Jiacheng Guo (Gerrit)

unread,
1:21 AM (6 hours ago) 1:21 AM
to chromium...@chromium.org, Nate Chapin, Chromium Metrics Reviews, Daniel Cheng, asvitkine...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, blink-rev...@chromium.org, jmedle...@chromium.org, schedule...@chromium.org, gavinp...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, blink-...@chromium.org, android-web...@chromium.org

Jiacheng Guo has uploaded the change for review

Commit message

Migrate LiveDocumentSet to DCHECK_IS_ON() macro guard.

Migrate the debug-only LiveDocumentSet from NDEBUG to
DCHECK_IS_ON() macro guard in document.cc, document.h, and
blink_leak_detector.cc.
Bug: 522516536
Change-Id: I2da45da37a17d8a138d6ee08f1e2e1133c055e35

Change diff


Change information

Files:
  • M third_party/blink/renderer/controller/blink_leak_detector.cc
  • M third_party/blink/renderer/core/dom/document.cc
  • M third_party/blink/renderer/core/dom/document.h
Change size: S
Delta: 3 files changed, 7 insertions(+), 5 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2da45da37a17d8a138d6ee08f1e2e1133c055e35
Gerrit-Change-Number: 7924686
Gerrit-PatchSet: 1
Gerrit-Owner: Jiacheng Guo <g...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages