[bedrock] Remove remaining BrowserList::GetLastActive() calls from product code [chromium/src : main]
0 views
Skip to first unread message
Alex Carutasu (Gerrit)
Sep 8, 2025, 7:57:44 PM (10 days ago) Sep 8
to Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Tom Lukaszewicz
Alex Carutasu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Carutasu
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Sep 8, 2025, 9:13:16 PM (10 days ago) Sep 8
to Alex Carutasu, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Tom Lukaszewicz added 4 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/browser/ash/browser_delegate/browser_controller_impl.h
Line 32, Patchset 2:
BrowserDelegate* GetDelegate(BrowserWindowInterface* bwi) override;Tom Lukaszewicz . unresolved
To fix ChromeOS it looks like we need to update the virtual method [here](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ash/browser_delegate/browser_controller.h;l=84;drc=4128411589187a396829a827f59a655bed876aa7)
File chrome/browser/chromeos/extensions/telemetry/api/common/util.cc
Line 85, Patchset 2:
GetAllBrowserWindowInterfaces()) {Tom Lukaszewicz . unresolved
I think in general we should move away from using this method and towards
[`ForEachCurrentBrowserWindowInterfaceOrderedByActivation()`](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/browser_window/public/browser_window_interface_iterator.h;l=40;drc=46e9f2e7d765e84a77f330301a6eb6233de84d0d) which is the safe way to iterate over the BWIs.
I'll mark this as deprecated in a separate change.
File chrome/browser/safe_browsing/chrome_password_protection_service.cc
Line 122, Patchset 2:
#include "chrome/browser/ui/browser_window/public/browser_window_interface_iterator.h"Tom Lukaszewicz . unresolved
To fix the android compile failures you might need to append `nogncheck` to this include also.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Carutasu (Gerrit)
Sep 8, 2025, 10:30:31 PM (10 days ago) Sep 8
to AyeAye, Chromium LUCI CQ, Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Tom Lukaszewicz
Alex Carutasu voted and added 4 comments![]( "Open in Gerrit")
Votes added by Alex Carutasu
| Commit-Queue | +1 |
4 comments
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Alex Carutasu . resolved
Thanks for the review, addressed the comments.
File chrome/browser/ash/browser_delegate/browser_controller_impl.h
Line 32, Patchset 2:
BrowserDelegate* GetDelegate(BrowserWindowInterface* bwi) override;Tom Lukaszewicz . resolved
To fix ChromeOS it looks like we need to update the virtual method [here](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ash/browser_delegate/browser_controller.h;l=84;drc=4128411589187a396829a827f59a655bed876aa7)
Alex Carutasu
Done
File chrome/browser/chromeos/extensions/telemetry/api/common/util.cc
Line 85, Patchset 2:
GetAllBrowserWindowInterfaces()) {Tom Lukaszewicz . resolved
I think in general we should move away from using this method and towards
[`ForEachCurrentBrowserWindowInterfaceOrderedByActivation()`](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/browser_window/public/browser_window_interface_iterator.h;l=40;drc=46e9f2e7d765e84a77f330301a6eb6233de84d0d) which is the safe way to iterate over the BWIs.I'll mark this as deprecated in a separate change.
Alex Carutasu
Thanks for the tip, I changed it to use the other function.
File chrome/browser/safe_browsing/chrome_password_protection_service.cc
Line 122, Patchset 2:
#include "chrome/browser/ui/browser_window/public/browser_window_interface_iterator.h"Tom Lukaszewicz . resolved
To fix the android compile failures you might need to append `nogncheck` to this include also.
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chandranath Bhattacharyya (Gerrit)
Sep 8, 2025, 10:57:59 PM (10 days ago) Sep 8
to Alex Carutasu, AyeAye, Chromium LUCI CQ, Tom Lukaszewicz, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu and Tom Lukaszewicz
Chandranath Bhattacharyya added 14 comments![]( "Open in Gerrit")
Patchset-level comments
Chandranath Bhattacharyya . resolved
Looks good! Added some nits.
File chrome/browser/ash/browser_delegate/browser_controller_impl.cc
Line 68, Patchset 4 (Latest):
.insert({bwi, std::make_unique<BrowserDelegateImpl>(
bwi->GetBrowserForMigrationOnly())})Chandranath Bhattacharyya . unresolved
(Not related to your PR), consider using `emplace`:
```cpp
.emplace(bwi, std::make_unique<BrowserDelegateImpl>(
bwi->GetBrowserForMigrationOnly()))
```
File chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
Line 110, Patchset 4 (Latest):
#include "chrome/browser/ui/browser_window/public/browser_window_interface.h" // nogncheckChandranath Bhattacharyya . unresolved
Consider logging a bug to fix this later and add a TODO comment here.
File chrome/browser/chromeos/extensions/telemetry/api/common/util.cc
Line 71, Patchset 4 (Latest):
BrowserWindowInterface* const bwi =Chandranath Bhattacharyya . unresolved
Consider rename to `last_active_bwi`.
File chrome/browser/enterprise/idle/action.cc
Line 36, Patchset 4 (Latest):
#include "chrome/browser/ui/browser_window/public/browser_window_interface.h" // nogncheckChandranath Bhattacharyya . unresolved
Consider logging a bug to fix this nogncheck and added a TODO comment with the bug number.
File chrome/browser/enterprise/idle/dialog_manager.cc
Line 61, Patchset 4 (Latest):
BrowserWindowInterface* const bwi =Chandranath Bhattacharyya . unresolved
Consider rename to `active_bwi`.
File chrome/browser/extensions/api/tabs/tabs_api_non_android.cc
Line 280, Patchset 4 (Latest):
old_z_order_level_ = bwi_->GetWindow()->GetZOrderLevel();Chandranath Bhattacharyya . unresolved
Consider using `bwi` directly instead of the `WeakPtr` deref. Same comment for the next line.
Line 647, Patchset 4 (Latest):
BrowserWindowInterface* const bwi =Chandranath Bhattacharyya . unresolved
Consider rename to `last_active_bwi`.
File chrome/browser/glic/widget/glic_window_controller_impl.cc
Line 1166, Patchset 4 (Latest):
if (auto* const bwi = GetLastActiveBrowserWindowInterfaceWithAnyProfile()) {Chandranath Bhattacharyya . unresolved
Consider renaming to `last_active_bwi`.
Line 1183, Patchset 4 (Latest):
BrowserWindowInterface* const bwi =Chandranath Bhattacharyya . unresolved
Consider renaming to `last_active_bwi`.
Line 1584, Patchset 4 (Latest):
BrowserWindowInterface* const bwi =Chandranath Bhattacharyya . unresolved
Consider renaming to `last_active_bwi`.
File chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
Line 48, Patchset 4 (Latest):
const auto* const bwi = GetLastActiveBrowserWindowInterfaceWithAnyProfile();Chandranath Bhattacharyya . unresolved
Consider renaming to `last_active_bwi`.
File chrome/browser/safe_browsing/chrome_password_protection_service.cc
Line 122, Patchset 4 (Latest):
#include "chrome/browser/ui/browser_window/public/browser_window_interface_iterator.h" // nogncheckChandranath Bhattacharyya . unresolved
Consider logging a bug and adding a TODO item.
File chrome/browser/ui/browser_list.cc
Line 330, Patchset 4 (Latest):
new_last_active->GetBrowserForMigrationOnly());Chandranath Bhattacharyya . unresolved
nit: Consider caching the `Browser*` out of the for loop and using it here.
Related details
Attention is currently required from:
- Alex Carutasu
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Sep 8, 2025, 11:15:25 PM (10 days ago) Sep 8
to Alex Carutasu, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu
Tom Lukaszewicz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Code-Review | +1 |
2 comments
Patchset-level comments
Tom Lukaszewicz . resolved
Still lgtm, I'll re-stamp after comments are resolved (since the update will reset votes)
File chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
Line 110, Patchset 4 (Latest):
#include "chrome/browser/ui/browser_window/public/browser_window_interface.h" // nogncheckChandranath Bhattacharyya . unresolved
Consider logging a bug to fix this later and add a TODO comment here.
Tom Lukaszewicz
If you wanted to tag a bug feel free to use crbug.com/40147906
Related details
Attention is currently required from:
- Alex Carutasu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Carutasu (Gerrit)
Sep 9, 2025, 12:43:20 AM (10 days ago) Sep 9
to Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Chandranath Bhattacharyya and Tom Lukaszewicz
Alex Carutasu voted and added 14 comments![]( "Open in Gerrit")
Votes added by Alex Carutasu
| Commit-Queue | +1 |
14 comments
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Alex Carutasu . resolved
Thanks for the review, resolved the comments.
File chrome/browser/ash/browser_delegate/browser_controller_impl.cc
Line 68, Patchset 4:
.insert({bwi, std::make_unique<BrowserDelegateImpl>(
bwi->GetBrowserForMigrationOnly())})Chandranath Bhattacharyya . resolved
(Not related to your PR), consider using `emplace`:
```cpp
.emplace(bwi, std::make_unique<BrowserDelegateImpl>(
bwi->GetBrowserForMigrationOnly()))
```
Alex Carutasu
Done
File chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
Line 110, Patchset 4:
#include "chrome/browser/ui/browser_window/public/browser_window_interface.h" // nogncheckChandranath Bhattacharyya . resolved
Tom LukaszewiczConsider logging a bug to fix this later and add a TODO comment here.
If you wanted to tag a bug feel free to use crbug.com/40147906
Alex Carutasu
I saw some other refs to that crbug just add the link after the nogncheck so I followed that example.
File chrome/browser/chromeos/extensions/telemetry/api/common/util.cc
Consider rename to `last_active_bwi`.
Alex Carutasu
Done
File chrome/browser/enterprise/idle/action.cc
Line 36, Patchset 4:
#include "chrome/browser/ui/browser_window/public/browser_window_interface.h" // nogncheckChandranath Bhattacharyya . resolved
Consider logging a bug to fix this nogncheck and added a TODO comment with the bug number.
Alex Carutasu
Done
File chrome/browser/enterprise/idle/dialog_manager.cc
Consider rename to `active_bwi`.
Alex Carutasu
Done
File chrome/browser/extensions/api/tabs/tabs_api_non_android.cc
Line 280, Patchset 4:
old_z_order_level_ = bwi_->GetWindow()->GetZOrderLevel();Chandranath Bhattacharyya . resolved
Consider using `bwi` directly instead of the `WeakPtr` deref. Same comment for the next line.
Alex Carutasu
Done
Consider rename to `last_active_bwi`.
Alex Carutasu
Done
File chrome/browser/glic/widget/glic_window_controller_impl.cc
Line 1166, Patchset 4:
if (auto* const bwi = GetLastActiveBrowserWindowInterfaceWithAnyProfile()) {Chandranath Bhattacharyya . resolved
Consider renaming to `last_active_bwi`.
Alex Carutasu
Done
Consider renaming to `last_active_bwi`.
Alex Carutasu
Done
Consider renaming to `last_active_bwi`.
Alex Carutasu
Done
File chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
Line 48, Patchset 4:
const auto* const bwi = GetLastActiveBrowserWindowInterfaceWithAnyProfile();Chandranath Bhattacharyya . resolved
Consider renaming to `last_active_bwi`.
Alex Carutasu
Done
File chrome/browser/safe_browsing/chrome_password_protection_service.cc
Line 122, Patchset 4:
#include "chrome/browser/ui/browser_window/public/browser_window_interface_iterator.h" // nogncheckChandranath Bhattacharyya . resolved
Consider logging a bug and adding a TODO item.
Alex Carutasu
Done
File chrome/browser/ui/browser_list.cc
Line 330, Patchset 4:
new_last_active->GetBrowserForMigrationOnly());Chandranath Bhattacharyya . resolved
nit: Consider caching the `Browser*` out of the for loop and using it here.
Attention is currently required from:
- Chandranath Bhattacharyya
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Sep 9, 2025, 2:10:30 AM (10 days ago) Sep 9
to Alex Carutasu, Darryl James, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu, Chandranath Bhattacharyya and Darryl James
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Code-Review | +1 |
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Darryl James
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Sep 9, 2025, 12:30:17 PM (10 days ago) Sep 9
to Alex Carutasu, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu and Chandranath Bhattacharyya
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
1 comment
Patchset-level comments
Darryl James . resolved
lgtm! Thanks for the cleanup!
Related details
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Sep 9, 2025, 12:32:37 PM (10 days ago) Sep 9
to Alex Carutasu, Kyle Horimoto, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu, Chandranath Bhattacharyya and Kyle Horimoto
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +0 |
1 comment
Patchset-level comments
Darryl James . resolved
@khorimoto - Please review remaining ash/chromeos files, thanks!
Related details
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Kyle Horimoto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Sep 9, 2025, 12:32:53 PM (10 days ago) Sep 9
to Alex Carutasu, Kyle Horimoto, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu, Chandranath Bhattacharyya and Kyle Horimoto
Darryl James voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Kyle Horimoto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyle Horimoto (Gerrit)
Sep 10, 2025, 11:58:41 AM (9 days ago) Sep 10
to Alex Carutasu, Georg Neis, Darryl James, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, Kyle Horimoto
Attention needed from Alex Carutasu, Chandranath Bhattacharyya and Georg Neis
Kyle Horimoto added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kyle Horimoto . resolved
Reassigning to @ne...@chromium.org to take a look at the DEPS changes. I'm not working on this anymore, but I don't think we want to add new browser.h dependencies.
Related details
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Carutasu (Gerrit)
Sep 10, 2025, 1:23:39 PM (9 days ago) Sep 10
to Georg Neis, Darryl James, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Chandranath Bhattacharyya and Georg Neis
Alex Carutasu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kyle Horimoto . resolved
Reassigning to @ne...@chromium.org to take a look at the DEPS changes. I'm not working on this anymore, but I don't think we want to add new browser.h dependencies.
Alex Carutasu
The related files were already handling Browser pointers and passing them into calls to other functions, but they didn't need the browser.h include.
However, once I changed some functions to take a BrowserWindowInterface instead of Browser, now those files need the browser.h include to be aware that Browser inherits from BWI.
Related details
Attention is currently required from:
- Chandranath Bhattacharyya
- Georg Neis
Darryl James (Gerrit)
Sep 10, 2025, 1:37:56 PM (9 days ago) Sep 10
to Alex Carutasu, Georg Neis, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu, Chandranath Bhattacharyya and Georg Neis
Darryl James added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kyle Horimoto . unresolved
Alex CarutasuReassigning to @ne...@chromium.org to take a look at the DEPS changes. I'm not working on this anymore, but I don't think we want to add new browser.h dependencies.
The related files were already handling Browser pointers and passing them into calls to other functions, but they didn't need the browser.h include.
However, once I changed some functions to take a BrowserWindowInterface instead of Browser, now those files need the browser.h include to be aware that Browser inherits from BWI.
Darryl James
For reference the file that needs the Browser include is:
chrome/browser/ash/file_system_provider/operation_request_manager.cc
around line 78 we are passing the browser into a call to retrieve a BrowserDelegate.
However, I don't see any usage off of the browser object explicitly. I believe we can forward declare at the top of the cc file removing the need for the include 👍
Related details
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Carutasu (Gerrit)
Sep 10, 2025, 1:45:47 PM (9 days ago) Sep 10
to Georg Neis, Darryl James, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Chandranath Bhattacharyya, Darryl James and Georg Neis
Alex Carutasu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kyle Horimoto . unresolved
Alex CarutasuReassigning to @ne...@chromium.org to take a look at the DEPS changes. I'm not working on this anymore, but I don't think we want to add new browser.h dependencies.
Darryl JamesThe related files were already handling Browser pointers and passing them into calls to other functions, but they didn't need the browser.h include.
However, once I changed some functions to take a BrowserWindowInterface instead of Browser, now those files need the browser.h include to be aware that Browser inherits from BWI.
For reference the file that needs the Browser include is:
chrome/browser/ash/file_system_provider/operation_request_manager.ccaround line 78 we are passing the browser into a call to retrieve a BrowserDelegate.
However, I don't see any usage off of the browser object explicitly. I believe we can forward declare at the top of the cc file removing the need for the include 👍
Alex Carutasu
A browser pointer is passed into a call to `BrowserController::GetDelegate()` in that file, which I modified to take a BWI pointer.
Without the include, `operation_request_manager.cc` is not aware that Browser inherits from BWI and that generates a build break.
Related details
Attention is currently required from:
- Chandranath Bhattacharyya
- Darryl James
- Georg Neis
Darryl James (Gerrit)
Sep 10, 2025, 1:48:05 PM (9 days ago) Sep 10
to Alex Carutasu, Georg Neis, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu, Chandranath Bhattacharyya and Georg Neis
Darryl James added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kyle Horimoto . unresolved
Alex CarutasuReassigning to @ne...@chromium.org to take a look at the DEPS changes. I'm not working on this anymore, but I don't think we want to add new browser.h dependencies.
Darryl JamesThe related files were already handling Browser pointers and passing them into calls to other functions, but they didn't need the browser.h include.
However, once I changed some functions to take a BrowserWindowInterface instead of Browser, now those files need the browser.h include to be aware that Browser inherits from BWI.
Alex CarutasuFor reference the file that needs the Browser include is:
chrome/browser/ash/file_system_provider/operation_request_manager.ccaround line 78 we are passing the browser into a call to retrieve a BrowserDelegate.
However, I don't see any usage off of the browser object explicitly. I believe we can forward declare at the top of the cc file removing the need for the include 👍
A browser pointer is passed into a call to `BrowserController::GetDelegate()` in that file, which I modified to take a BWI pointer.
Without the include, `operation_request_manager.cc` is not aware that Browser inherits from BWI and that generates a build break.
Darryl James
Ahh got it - thanks for reminding me!
In that case can we use `WindowController::GetBrowserWindowInterface()` instead?
Related details
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Georg Neis
Alex Carutasu (Gerrit)
Sep 10, 2025, 2:23:38 PM (9 days ago) Sep 10
to Georg Neis, Darryl James, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Chandranath Bhattacharyya, Darryl James, Georg Neis and Tom Lukaszewicz
Alex Carutasu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Carutasu
| Commit-Queue | +1 |
Alex CarutasuReassigning to @ne...@chromium.org to take a look at the DEPS changes. I'm not working on this anymore, but I don't think we want to add new browser.h dependencies.
Darryl JamesThe related files were already handling Browser pointers and passing them into calls to other functions, but they didn't need the browser.h include.
However, once I changed some functions to take a BrowserWindowInterface instead of Browser, now those files need the browser.h include to be aware that Browser inherits from BWI.
Alex CarutasuFor reference the file that needs the Browser include is:
chrome/browser/ash/file_system_provider/operation_request_manager.ccaround line 78 we are passing the browser into a call to retrieve a BrowserDelegate.
However, I don't see any usage off of the browser object explicitly. I believe we can forward declare at the top of the cc file removing the need for the include 👍
Darryl JamesA browser pointer is passed into a call to `BrowserController::GetDelegate()` in that file, which I modified to take a BWI pointer.
Without the include, `operation_request_manager.cc` is not aware that Browser inherits from BWI and that generates a build break.
Ahh got it - thanks for reminding me!
In that case can we use `WindowController::GetBrowserWindowInterface()` instead?
Alex Carutasu
Thanks for the tip, wasn't aware of that alternative.
Trying it out.
Related details
Attention is currently required from:
- Chandranath Bhattacharyya
- Darryl James
- Georg Neis
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Sep 10, 2025, 2:23:43 PM (9 days ago) Sep 10
to Alex Carutasu, Georg Neis, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Chandranath Bhattacharyya, Georg Neis and Tom Lukaszewicz
Darryl James voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Chandranath Bhattacharyya
- Georg Neis
- Tom Lukaszewicz
Tom Lukaszewicz (Gerrit)
Sep 10, 2025, 3:04:18 PM (9 days ago) Sep 10
to Alex Carutasu, Darryl James, Georg Neis, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu, Chandranath Bhattacharyya and Georg Neis
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
Sep 10, 2025, 8:05:58 PM (8 days ago) Sep 10
to Alex Carutasu, Tom Lukaszewicz, Darryl James, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu and Chandranath Bhattacharyya
Georg Neis voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Carutasu (Gerrit)
Sep 10, 2025, 8:31:20 PM (8 days ago) Sep 10
to Georg Neis, Tom Lukaszewicz, Darryl James, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Chandranath Bhattacharyya
Alex Carutasu voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Chandranath Bhattacharyya
Alex Carutasu (Gerrit)
Sep 11, 2025, 12:31:17 AM (8 days ago) Sep 11
to Georg Neis, Tom Lukaszewicz, Darryl James, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Alex Carutasu (Gerrit)
Sep 11, 2025, 1:19:47 AM (8 days ago) Sep 11
to Georg Neis, Tom Lukaszewicz, Darryl James, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Tom Lukaszewicz (Gerrit)
Sep 11, 2025, 2:56:36 PM (8 days ago) Sep 11
to Alex Carutasu, Georg Neis, Darryl James, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu, Chandranath Bhattacharyya, Darryl James and Georg Neis
Tom Lukaszewicz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Darryl James
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Sep 11, 2025, 3:50:32 PM (8 days ago) Sep 11
to Alex Carutasu, Tom Lukaszewicz, Georg Neis, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Alex Carutasu, Chandranath Bhattacharyya and Georg Neis
Darryl James voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alex Carutasu
- Chandranath Bhattacharyya
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Carutasu (Gerrit)
Sep 11, 2025, 3:56:54 PM (8 days ago) Sep 11
to Darryl James, Tom Lukaszewicz, Georg Neis, AyeAye, Chromium LUCI CQ, Chandranath Bhattacharyya, Kevin DiClemente, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Chandranath Bhattacharyya and Georg Neis
Alex Carutasu voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Chandranath Bhattacharyya
- Georg Neis
Chromium LUCI CQ (Gerrit)
Sep 11, 2025, 5:53:15 PM (8 days ago) Sep 11
to Alex Carutasu, Darryl James, Tom Lukaszewicz, Georg Neis, AyeAye, Chandranath Bhattacharyya, Kevin DiClemente, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, cros-enterpris...@chromium.org, filesapp...@chromium.org, mtomas...@chromium.org, abigailbk...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chungshe...@google.com, csharris...@chromium.org, dennyh...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jdonnel...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, menghua...@google.com, mfoltz...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, weiluanw...@google.com, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[bedrock] Remove remaining BrowserList::GetLastActive() calls from product code
This CL migrates the remaining product code (non-test) callsites of
BrowserList::GetLastActive() to
GetLastActiveBrowserWindowInterfaceWithAnyProfile().
Notes:
- Refactored related utilities where necessary and possible to use
BrowserWindowInterface over Browser to support migrating the
GetLastActive() callsites.
- Used GetBrowserForMigrationOnly() in a few spots where refactoring the
related code to use BrowserWindowInterface was non-trivial.
- Added a couple GN and DEPS file exceptions to enable using
browser_window_interface*.h includes.
Bug: 431671448
Change-Id: I83dac06e0564e8579df348a6051bbb4a672a1d80
Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Alex Carutasu <alca...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1514537}
Files:
- M chrome/browser/accessibility/ax_main_node_annotator_controller.cc
- M chrome/browser/ash/browser_delegate/browser_controller.h
- M chrome/browser/ash/browser_delegate/browser_controller_impl.cc
- M chrome/browser/ash/browser_delegate/browser_controller_impl.h
- M chrome/browser/ash/file_system_provider/operation_request_manager.cc
- M chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
- M chrome/browser/autocomplete/tab_matcher_desktop.cc
- M chrome/browser/chromeos/extensions/telemetry/api/common/BUILD.gn
- M chrome/browser/chromeos/extensions/telemetry/api/common/DEPS
- M chrome/browser/chromeos/extensions/telemetry/api/common/util.cc
- M chrome/browser/devtools/protocol/browser_handler.cc
- M chrome/browser/download/download_file_picker.cc
- M chrome/browser/enterprise/idle/action.cc
- M chrome/browser/enterprise/idle/dialog_manager.cc
- M chrome/browser/enterprise/idle/idle_service.cc
- M chrome/browser/extensions/api/tabs/tabs_api_non_android.cc
- M chrome/browser/glic/host/context/glic_focused_browser_manager.cc
- M chrome/browser/glic/widget/browser_conditions.cc
- M chrome/browser/glic/widget/browser_conditions.h
- M chrome/browser/glic/widget/glic_window_controller_impl.cc
- M chrome/browser/lifetime/browser_close_manager.cc
- M chrome/browser/media/offscreen_tab.cc
- M chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
- M chrome/browser/page_load_metrics/observers/ash_session_restore_page_load_metrics_observer.cc
- M chrome/browser/safe_browsing/chrome_password_protection_service.cc
- M chrome/browser/ui/BUILD.gn
- M chrome/browser/ui/browser_commands.cc
- M chrome/browser/ui/browser_commands.h
- M chrome/browser/ui/browser_list.cc
- M chrome/browser/ui/idle_bubble.h
- M chrome/browser/ui/idle_dialog.h
- M chrome/browser/ui/views/idle_bubble.cc
- M chrome/browser/ui/views/policy/idle_dialog_view.cc
- M chrome/browser/ui/views/policy/idle_dialog_view.h
- M chrome/browser/ui/views/storage/storage_pressure_bubble_view.cc
- M chrome/browser/ui/views/storage/storage_pressure_bubble_view.h
- M chrome/browser/win/installer_downloader/installer_downloader_active_browser_window_tracker.cc
- M chrome/browser/win/installer_downloader/installer_downloader_active_browser_window_tracker.h
Change size: L
Delta: 38 files changed, 269 insertions(+), 205 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tom Lukaszewicz, +1 by Darryl James
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages