[AdTracker] Switch to CurrentScriptIdsAndContexts to get stack frames [chromium/src : main]
0 views
Skip to first unread message
Josh Karlin (Gerrit)
Jan 30, 2026, 1:36:00 PM (13 hours ago) Jan 30
to Josh Karlin, Nate Chapin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Nate Chapin
Josh Karlin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Jan 30, 2026, 2:34:29 PM (12 hours ago) Jan 30
to Josh Karlin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Josh Karlin
Nate Chapin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Josh Karlin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Josh Karlin (Gerrit)
Jan 30, 2026, 2:37:44 PM (12 hours ago) Jan 30
to Josh Karlin, Nate Chapin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Josh Karlin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 30, 2026, 2:41:40 PM (12 hours ago) Jan 30
to Josh Karlin, Nate Chapin, AyeAye, chromium...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[AdTracker] Switch to CurrentScriptIdsAndContexts to get stack frames
The new v8::StackTrace::CurrentScriptIdsAndContexts will drill down into
evals and return the script that triggered the eval, fixing a bug in the
AdTracker. So use that instead of CurrentScriptId.
Bug: 473760917
Change-Id: I363bdc9abd130b25c78f1c371aae57af81683f95
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Josh Karlin <jka...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1577438}
Files:
- M chrome/browser/page_load_metrics/observers/ad_metrics/ads_page_load_metrics_observer_browsertest.cc
- M third_party/blink/renderer/core/frame/ad_tracker.cc
- M third_party/blink/renderer/core/frame/ad_tracker_test.cc
Change size: M
Delta: 3 files changed, 59 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages