Add GWS metrics based on UserInteraction, ActualNavigationStart, and ParseStart [chromium/src : main]
Minoru Chikamune (Gerrit)
Message from Minoru Chikamune![]( "Open in Gerrit")
Set Ready For Review
Related details
- Minoru Chikamune
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
Takashi Toyoshima voted and added 3 comments![]( "Open in Gerrit")
Votes added by Takashi Toyoshima
| Code-Review | +1 |
3 comments
hum... these are listed in a bit chaotic order?
When I see only variable names, I can see some clusters and looks organized, but when I see the metrics name, FooTiming and BarTiming are mixed, for instance.
So, this is not an optional request, but if you can find a better organization, it's nice to reorder them in a reasonable way.
delegate.GetNavigationStart())) {Can we have a short comment to explain why you exclude the reversed order case, e.g. just for unexpected races?
Related details
- Minoru Chikamune
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minoru Chikamune (Gerrit)
Minoru Chikamune added 2 comments![]( "Open in Gerrit")
hum... these are listed in a bit chaotic order?
When I see only variable names, I can see some clusters and looks organized, but when I see the metrics name, FooTiming and BarTiming are mixed, for instance.So, this is not an optional request, but if you can find a better organization, it's nice to reorder them in a reasonable way.
I ordered these metrics in the following way.
1. InteractionTo*
2. ActualNavigationStartTo*
3. ParseStartTo* (but also includes NavigationStartTo* and NavigationCommit*)
The category name such as `NavigationTiming`, `PaintTiming`, `DocumentTiming`, etc come from historical reason. Perhaps it's better to remove these category names..
delegate.GetNavigationStart())) {Can we have a short comment to explain why you exclude the reversed order case, e.g. just for unexpected races?
This is just for unexpected cases, but it actually happen unfortunately. Probably there are two main reasons for this to happen.
1. Some of the actual_navigation_start time comes from renderer process, and the timestamp is different from the browser process.
2. Probably `blink::InterProcessTimeTicksConverter` makes things even worse.
Related details
- Takashi Toyoshima
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |