[LNA] fix LNA permission denied console error message [chromium/src : main]
0 views
Skip to first unread message
Hubert Chao (Gerrit)
Nov 4, 2025, 8:33:48 PM (2 days ago) Nov 4
to Yoshisato Yanagisawa, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Chris Thompson and Yoshisato Yanagisawa
Hubert Chao added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Chris Thompson
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
Nov 5, 2025, 2:19:44 AM (yesterday) Nov 5
to Hubert Chao, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Chris Thompson and Hubert Chao
Yoshisato Yanagisawa voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Chris Thompson
- Hubert Chao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Nov 5, 2025, 1:03:45 PM (20 hours ago) Nov 5
to Hubert Chao, Yoshisato Yanagisawa, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Attention needed from Hubert Chao
Chris Thompson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Chris Thompson
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Chris Thompson . resolved
LGTM % a typo fix in the cl description
Commit Message
Line 14, Patchset 2 (Latest):
have ot change as well, but that will be handled by the largerChris Thompson . unresolved
```suggestion
have to change as well, but that will be handled by the larger
```
Related details
Attention is currently required from:
- Hubert Chao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hubert Chao (Gerrit)
Nov 5, 2025, 1:17:55 PM (19 hours ago) Nov 5
to Chris Thompson, Yoshisato Yanagisawa, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Hubert Chao added 1 comment![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 2:
have ot change as well, but that will be handled by the largerChris Thompson . resolved
```suggestion
have to change as well, but that will be handled by the larger
```
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hubert Chao (Gerrit)
Nov 5, 2025, 1:17:59 PM (19 hours ago) Nov 5
to Chris Thompson, Yoshisato Yanagisawa, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Hubert Chao voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 5, 2025, 1:21:47 PM (19 hours ago) Nov 5
to Hubert Chao, Chris Thompson, Yoshisato Yanagisawa, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[LNA] fix LNA permission denied console error message
Change the LNA permission denied console error message to show the
resource address space; target address space turns out to only have
to do with preflights.
The error message for CorsError::kInvalidPrivateNetworkAccess will
have to change as well, but that will be handled by the larger
cleanup that removes the target_address_space concept from the
services/network layer.
Bug: 394636065, 457793934
Change-Id: If6e05dc022cff3e28ec614441349a28a6e0b244c
Commit-Queue: Hubert Chao <hc...@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
Reviewed-by: Chris Thompson <cth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540725}
Files:
- M third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Thompson, +1 by Yoshisato Yanagisawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages