Worker: Use WeakDocumentPtr in worker connectors [chromium/src : main]

0 views
Skip to first unread message

gwsq (Gerrit)

unread,
Jul 8, 2026, 12:21:28 AM (yesterday) Jul 8
to Yoshisato Yanagisawa, Chromium IPC Reviews, Hidehiko Abe, Rakina Zata Amni, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, alexmo...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Hidehiko Abe and Rakina Zata Amni

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: hide...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): hide...@chromium.org


Reviewer source(s):
hide...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idbfa5a47d7960c87828db44d464d3a20a2fa160b
Gerrit-Change-Number: 8051710
Gerrit-PatchSet: 5
Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 04:21:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rakina Zata Amni (Gerrit)

unread,
Jul 8, 2026, 3:35:42 AM (yesterday) Jul 8
to Yoshisato Yanagisawa, Chromium IPC Reviews, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, alexmo...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Hidehiko Abe and Yoshisato Yanagisawa

Rakina Zata Amni voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Yoshisato Yanagisawa
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idbfa5a47d7960c87828db44d464d3a20a2fa160b
    Gerrit-Change-Number: 8051710
    Gerrit-PatchSet: 5
    Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 07:35:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    Jul 8, 2026, 7:52:40 AM (21 hours ago) Jul 8
    to Yoshisato Yanagisawa, Rakina Zata Amni, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, alexmo...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
    Attention needed from Yoshisato Yanagisawa

    Hidehiko Abe voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yoshisato Yanagisawa
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idbfa5a47d7960c87828db44d464d3a20a2fa160b
    Gerrit-Change-Number: 8051710
    Gerrit-PatchSet: 5
    Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 11:52:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yoshisato Yanagisawa (Gerrit)

    unread,
    3:33 AM (1 hour ago) 3:33 AM
    to Hidehiko Abe, Rakina Zata Amni, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, alexmo...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org

    Yoshisato Yanagisawa voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idbfa5a47d7960c87828db44d464d3a20a2fa160b
    Gerrit-Change-Number: 8051710
    Gerrit-PatchSet: 5
    Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Comment-Date: Thu, 09 Jul 2026 07:33:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages