Revert "Preserve lazy loading behavior when an image is side-loaded" [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Dec 15, 2025, 2:34:17 PM (yesterday) Dec 15
to Stefan Zager, Chromium LUCI CQ, Philip Rogers, AyeAye, Dominic Farolino, chromium...@chromium.org, Nate Chapin, Menard, Alexis, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, loading...@chromium.org, apavlo...@chromium.org
Attention needed from Philip Rogers

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I936b60dacebffcce23c636abebbb22755efadc7f
Gerrit-Change-Number: 7262831
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Dominic Farolino <d...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 19:34:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Stefan Zager (Gerrit)

unread,
Dec 15, 2025, 2:34:23 PM (yesterday) Dec 15
to Philip Rogers, AyeAye, Dominic Farolino, chromium...@chromium.org, Nate Chapin, Menard, Alexis, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, loading...@chromium.org, apavlo...@chromium.org
Attention needed from Philip Rogers

Stefan Zager voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I936b60dacebffcce23c636abebbb22755efadc7f
    Gerrit-Change-Number: 7262831
    Gerrit-PatchSet: 1
    Gerrit-Owner: Stefan Zager <sza...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
    Gerrit-CC: Dominic Farolino <d...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 19:34:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Philip Rogers (Gerrit)

    unread,
    Dec 15, 2025, 2:35:03 PM (yesterday) Dec 15
    to Stefan Zager, Chromium LUCI CQ, AyeAye, Dominic Farolino, chromium...@chromium.org, Nate Chapin, Menard, Alexis, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, loading...@chromium.org, apavlo...@chromium.org
    Attention needed from Stefan Zager

    Philip Rogers voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Stefan Zager
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I936b60dacebffcce23c636abebbb22755efadc7f
      Gerrit-Change-Number: 7262831
      Gerrit-PatchSet: 1
      Gerrit-Owner: Stefan Zager <sza...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
      Gerrit-CC: Dominic Farolino <d...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-Attention: Stefan Zager <sza...@chromium.org>
      Gerrit-Comment-Date: Mon, 15 Dec 2025 19:34:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Philip Rogers (Gerrit)

      unread,
      Dec 15, 2025, 2:35:08 PM (yesterday) Dec 15
      to Stefan Zager, Chromium LUCI CQ, AyeAye, Dominic Farolino, chromium...@chromium.org, Nate Chapin, Menard, Alexis, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, loading...@chromium.org, apavlo...@chromium.org
      Attention needed from Stefan Zager

      Philip Rogers voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Mon, 15 Dec 2025 19:35:00 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 15, 2025, 3:31:44 PM (yesterday) Dec 15
      to Stefan Zager, Philip Rogers, AyeAye, Dominic Farolino, chromium...@chromium.org, Nate Chapin, Menard, Alexis, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, loading...@chromium.org, apavlo...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Revert "Preserve lazy loading behavior when an image is side-loaded"

      This reverts commit c1c615c18e73562fe26d19bd745e3057e8910da9.

      Reason for revert: see bug

      Original change's description:
      > Preserve lazy loading behavior when an image is side-loaded
      >
      > According to the spec, if the resource for an <img loading="lazy"> is
      > loaded via other means (e.g. fetch()), then the <img> should not
      > fire its load event until it enters the viewport.
      >
      > Putting this behind a flag in case sites are relying on the legacy
      > broken behavior.
      >
      > Bug: 375209498
      > Change-Id: I58f47ae1efdb953cdffc642eb68264484d1d20b3
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7240346
      > Commit-Queue: Stefan Zager <sza...@chromium.org>
      > Reviewed-by: Philip Rogers <p...@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#1558440}
      Bug: 469002488
      Bug: 375209498
      Change-Id: I936b60dacebffcce23c636abebbb22755efadc7f
      Commit-Queue: Stefan Zager <sza...@chromium.org>
      Commit-Queue: Philip Rogers <p...@chromium.org>
      Reviewed-by: Philip Rogers <p...@chromium.org>
      Auto-Submit: Stefan Zager <sza...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1558931}
      Files:
      • M third_party/blink/renderer/core/css/resolver/element_style_resources.cc
      • M third_party/blink/renderer/core/loader/image_loader.cc
      • M third_party/blink/renderer/platform/runtime_enabled_features.json5
      • A third_party/blink/web_tests/external/wpt/html/semantics/embedded-content/the-img-element/update-the-image-data/lazy-out-of-band-load-expected.txt
      Change size: M
      Delta: 4 files changed, 18 insertions(+), 33 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Philip Rogers
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I936b60dacebffcce23c636abebbb22755efadc7f
      Gerrit-Change-Number: 7262831
      Gerrit-PatchSet: 2
      Gerrit-Owner: Stefan Zager <sza...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages