Move patching to own file in html/parser [chromium/src : main]
Noam Rosenthal (Gerrit)
Noam Rosenthal added 2 comments![]( "Open in Gerrit")
ParserPatch* CurrentParserPatch() const { return parser_patch_; }Noam Rosenthalnit: Blink Style Guide: Precede setters with the word “Set”; use bare words for getters. Setter and getter names should match the names of the variable being accessed/mutated. Since the getter name would collide with the type name `ParserPatch`, consider naming it `GetParserPatch()` instead of `CurrentParserPatch()`.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Done
ParserPatch(ContainerNode* host,Noam RosenthalBlink Style Guide: Don't mix Create () factory methods and public constructors in one class. Since `ParserPatch` has a factory method (`MaybeCreate`), its constructor should not be public. Consider using the `base::PassKey` pattern to restrict access to the constructor while still allowing `MakeGarbageCollected` to work.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Done
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Jägenstedt (Gerrit)
Philip Jägenstedt voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Noam Rosenthal
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
Noam Rosenthal voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Move patching to own file in html/parser
- M third_party/blink/renderer/core/html/build.gni
- M third_party/blink/renderer/core/html/html_template_element.cc
- M third_party/blink/renderer/core/html/html_template_element.h
- M third_party/blink/renderer/core/html/parser/html_construction_site.cc
- A third_party/blink/renderer/core/html/parser/patch.cc
- A third_party/blink/renderer/core/html/parser/patch.h
Code-Review: +1 by Philip Jägenstedt
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |