AWC remove API from unsupported platforms part II [chromium/src : main]

0 views
Skip to first unread message

Andrew Rayskiy (Gerrit)

unread,
Nov 3, 2025, 5:27:22 AM (3 days ago) Nov 3
to Patryk Chodur, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, pwa-com...@google.com
Attention needed from Patryk Chodur

Andrew Rayskiy voted and added 1 comment

Votes added by Andrew Rayskiy

Code-Review+1

1 comment

File chrome/browser/ui/browser.h
Line 973, Patchset 1 (Latest):#if !BUILDFLAG(IS_ANDROID)
Andrew Rayskiy . unresolved

`!BUILDFLAG(IS_IOS)`?

Open in Gerrit

Related details

Attention is currently required from:
  • Patryk Chodur
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
Gerrit-Change-Number: 7106319
Gerrit-PatchSet: 1
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Patryk Chodur <pch...@google.com>
Gerrit-Comment-Date: Mon, 03 Nov 2025 10:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Nov 3, 2025, 5:33:17 AM (3 days ago) Nov 3
to Patryk Chodur, Chromium IPC Reviews, Arthur Sonzogni, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, pwa-com...@google.com
Attention needed from Arthur Sonzogni

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: arthurs...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): arthurs...@chromium.org


Reviewer source(s):
arthurs...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
Gerrit-Change-Number: 7106319
Gerrit-PatchSet: 1
Gerrit-Owner: Patryk Chodur <pch...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Nov 2025 10:33:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Patryk Chodur (Gerrit)

unread,
Nov 3, 2025, 5:41:30 AM (3 days ago) Nov 3
to Chromium IPC Reviews, Arthur Sonzogni, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, pwa-com...@google.com
Attention needed from Arthur Sonzogni

Patryk Chodur added 1 comment

File chrome/browser/ui/browser.h
Line 973, Patchset 1 (Latest):#if !BUILDFLAG(IS_ANDROID)
Andrew Rayskiy . resolved

`!BUILDFLAG(IS_IOS)`?

Patryk Chodur
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
    Gerrit-Change-Number: 7106319
    Gerrit-PatchSet: 1
    Gerrit-Owner: Patryk Chodur <pch...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Comment-Date: Mon, 03 Nov 2025 10:41:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Andrew Rayskiy <green...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Arthur Sonzogni (Gerrit)

    unread,
    Nov 3, 2025, 8:13:42 AM (3 days ago) Nov 3
    to Patryk Chodur, Chromium IPC Reviews, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, pwa-com...@google.com
    Attention needed from Patryk Chodur

    Arthur Sonzogni voted and added 1 comment

    Votes added by Arthur Sonzogni

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Arthur Sonzogni . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Patryk Chodur
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
    Gerrit-Change-Number: 7106319
    Gerrit-PatchSet: 1
    Gerrit-Owner: Patryk Chodur <pch...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Patryk Chodur <pch...@google.com>
    Gerrit-Comment-Date: Mon, 03 Nov 2025 13:13:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nate Chapin (Gerrit)

    unread,
    Nov 3, 2025, 1:03:11 PM (3 days ago) Nov 3
    to Patryk Chodur, Daniel Cheng, Mike Wasserman, Arthur Sonzogni, Chromium IPC Reviews, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, pwa-com...@google.com
    Attention needed from Mike Wasserman and Patryk Chodur

    Nate Chapin voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mike Wasserman
    • Patryk Chodur
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
    Gerrit-Change-Number: 7106319
    Gerrit-PatchSet: 1
    Gerrit-Owner: Patryk Chodur <pch...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Mike Wasserman <m...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Mike Wasserman <m...@chromium.org>
    Gerrit-Attention: Patryk Chodur <pch...@google.com>
    Gerrit-Comment-Date: Mon, 03 Nov 2025 18:03:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mike Wasserman (Gerrit)

    unread,
    Nov 3, 2025, 3:17:37 PM (3 days ago) Nov 3
    to Patryk Chodur, Nate Chapin, Daniel Cheng, Arthur Sonzogni, Chromium IPC Reviews, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, pwa-com...@google.com
    Attention needed from Patryk Chodur

    Mike Wasserman voted and added 1 comment

    Votes added by Mike Wasserman

    Code-Review+1

    1 comment

    Patchset-level comments
    Mike Wasserman . resolved

    browser.h|cc lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Patryk Chodur
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
    Gerrit-Change-Number: 7106319
    Gerrit-PatchSet: 1
    Gerrit-Owner: Patryk Chodur <pch...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Mike Wasserman <m...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Patryk Chodur <pch...@google.com>
    Gerrit-Comment-Date: Mon, 03 Nov 2025 20:17:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Patryk Chodur (Gerrit)

    unread,
    Nov 3, 2025, 4:23:07 PM (3 days ago) Nov 3
    to Mike Wasserman, Nate Chapin, Daniel Cheng, Arthur Sonzogni, Chromium IPC Reviews, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, pwa-com...@google.com

    Patryk Chodur voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
    Gerrit-Change-Number: 7106319
    Gerrit-PatchSet: 2
    Gerrit-Owner: Patryk Chodur <pch...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Mike Wasserman <m...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Comment-Date: Mon, 03 Nov 2025 21:22:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 3, 2025, 5:25:52 PM (3 days ago) Nov 3
    to Patryk Chodur, Mike Wasserman, Nate Chapin, Daniel Cheng, Arthur Sonzogni, Chromium IPC Reviews, Andrew Rayskiy, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, pwa-com...@google.com

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    AWC remove API from unsupported platforms part II

    This commit removes the Additional Windowing Controls API from Android
    and iOS.
    Bug: 40946306
    Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
    Low-Coverage-Reason: COVERAGE_UNDERREPORTED
    Reviewed-by: Nate Chapin <jap...@chromium.org>
    Commit-Queue: Patryk Chodur <pch...@google.com>
    Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
    Reviewed-by: Mike Wasserman <m...@chromium.org>
    Reviewed-by: Andrew Rayskiy <green...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1539622}
    Files:
    • M chrome/browser/ui/browser.cc
    • M chrome/browser/ui/browser.h
    • M content/browser/renderer_host/render_frame_host_delegate.cc
    • M content/browser/renderer_host/render_frame_host_delegate.h
    • M content/browser/renderer_host/render_frame_host_impl.cc
    • M content/browser/renderer_host/render_frame_host_impl.h
    • M content/browser/web_contents/web_contents_impl.cc
    • M content/browser/web_contents/web_contents_impl.h
    • M content/public/browser/web_contents_delegate.cc
    • M content/public/browser/web_contents_delegate.h
    • M third_party/blink/public/mojom/frame/frame.mojom
    • M third_party/blink/renderer/core/exported/web_view_impl.cc
    • M third_party/blink/renderer/core/exported/web_view_impl.h
    • M third_party/blink/renderer/core/frame/web_frame_test.cc
    • M third_party/blink/renderer/core/loader/empty_clients.h
    • M third_party/blink/renderer/core/page/chrome_client.h
    • M third_party/blink/renderer/core/page/chrome_client_impl.cc
    • M third_party/blink/renderer/core/page/chrome_client_impl.h
    Change size: M
    Delta: 18 files changed, 58 insertions(+), 34 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nate Chapin, +1 by Andrew Rayskiy, +1 by Arthur Sonzogni, +1 by Mike Wasserman
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I11773637192dba35875b8a3cf6aa46bd62d42d86
    Gerrit-Change-Number: 7106319
    Gerrit-PatchSet: 3
    Gerrit-Owner: Patryk Chodur <pch...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mike Wasserman <m...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Patryk Chodur <pch...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages