Add API to create origins from nonces for sandboxed frames [chromium/src : main]

[Monica Chintala (Gerrit)]

Attention needed from Daniel Cheng, Dave Risney, Liang Zhao and Rakina Zata Amni

Monica Chintala added 2 comments

File content/common/sandboxed_opaque_origin_creator.h

Line 42, Patchset 24: SandboxedOpaqueOriginCreator() = delete;

Rakina Zata Amni . resolved

Please fix this WARNING reported by ClangTidy: check: modernize-use-equals-delete

deleted member function should be public (ht...

check: modernize-use-equals-delete

deleted member function should be public (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-delete.html)

(Note: You can add `Skip-Clang-Tidy-Checks: modernize-use-equals-delete` footer to the CL description to skip the check)

(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel` or `mac-clang-tidy-rel`)

Monica Chintala

Done

File third_party/blink/renderer/platform/weborigin/sandboxed_opaque_security_origin_creator.h

Line 20, Patchset 24:// with specified nonces for sandboxed iframes. This class should NOT be used

Rakina Zata Amni . resolved

Since we are expanding this to top-level frames as well, let's update mentions of "iframes" to just "frames"

Monica Chintala

Done

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng
• Dave Risney
• Liang Zhao
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0acceb30370940fecf16d8f027b0d78e34af5b8d

Gerrit-Change-Number: 7146577

Gerrit-PatchSet: 29

Gerrit-Owner: Monica Chintala <moni...@microsoft.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Liang Zhao <lz...@microsoft.com>

Gerrit-Reviewer: Monica Chintala <moni...@microsoft.com>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dave Risney <david....@microsoft.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Dave Risney <david....@microsoft.com>

Gerrit-Attention: Liang Zhao <lz...@microsoft.com>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Tue, 27 Jan 2026 21:47:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rakina Zata Amni <rak...@chromium.org>

[Rakina Zata Amni (Gerrit)]

Attention needed from Daniel Cheng, Dave Risney, Liang Zhao and Monica Chintala

Rakina Zata Amni added 2 comments

File content/common/sandboxed_opaque_origin_creator.h

Line 5, Patchset 29 (Latest):#ifndef CONTENT_COMMON_SANDBOXED_OPAQUE_ORIGIN_CREATOR_H_

Rakina Zata Amni . unresolved

This doesn't seem to be used in the renderer, can this be in content/browser/ instead?

File url/origin.h

Line 184, Patchset 19: // Creates an origin with the given nonce and tuple.

Rakina Zata Amni . unresolved

Let's add a comment on what the intended use case is (about:blank sandboxed iframes), and how we don't plan to add any more use cases here.

Rakina Zata Amni

Probably still needed, at least like the comment in the SecurityOrigin version.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng
• Dave Risney
• Liang Zhao

• Monica Chintala

Gerrit-Attention: Monica Chintala <moni...@microsoft.com>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Thu, 29 Jan 2026 15:24:09 +0000