[Topics] Remove browsing_topics.mojom and ResourceRequest field [chromium/src : main]
0 views
Skip to first unread message
Yao Xiao (Gerrit)
Jul 29, 2026, 8:11:37 PM (2 days ago) Jul 29
to Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Chromium IPC Reviews
Yao Xiao added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Yao Xiao . resolved
chrome-ipc-reviews@: PTAL at mojom changes. Thanks!
Related details
Attention is currently required from:
- Chromium IPC Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jul 29, 2026, 8:13:36 PM (2 days ago) Jul 29
to Yao Xiao, Chromium IPC Reviews, Ken Buchanan, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Ken Buchanan
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ke...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ke...@chromium.org
Reviewer source(s):
ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Ken Buchanan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yao Xiao (Gerrit)
Jul 29, 2026, 8:21:47 PM (2 days ago) Jul 29
to Daniel Cheng, Andrew Paseltiner, Chromium IPC Reviews, Ken Buchanan, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Andrew Paseltiner, Daniel Cheng, Ken Buchanan and mmenke
Yao Xiao added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yao Xiao . resolved
mmenke@: PTAL at services/network and subresource_proxying_url_loader_service.cc. Thanks!
dcheng@: PTAL at blink. Thanks!
apaseltiner@: PTAL at privacy_sandbox_ads_apis_browsertest.cc. Thanks!
Related details
Attention is currently required from:
- Andrew Paseltiner
- Daniel Cheng
- Ken Buchanan
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Jul 30, 2026, 8:41:08 AM (21 hours ago) Jul 30
to Yao Xiao, Daniel Cheng, Chromium IPC Reviews, Ken Buchanan, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng, Ken Buchanan, Yao Xiao and mmenke
Andrew Paseltiner voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
- Ken Buchanan
- Yao Xiao
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Jul 30, 2026, 11:31:18 AM (18 hours ago) Jul 30
to Yao Xiao, Andrew Paseltiner, Daniel Cheng, Chromium IPC Reviews, Ken Buchanan, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng, Ken Buchanan and Yao Xiao
mmenke added 1 comment![]( "Open in Gerrit")
File content/browser/loader/subresource_proxying_url_loader_service.cc
Line 116, Patchset 2 (Parent):
if (PrefetchURLLoaderServiceContext::IsPrefetchRequest(resource_request_in)) {mmenke . unresolved
Why remove this check? It looks like this CL doesn't remove PrefetchURLLoaderServiceContext::IsPrefetchRequest(), at least, so I assume it can still return false.
Related details
Attention is currently required from:
- Daniel Cheng
- Ken Buchanan
- Yao Xiao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yao Xiao (Gerrit)
Jul 30, 2026, 11:46:13 AM (18 hours ago) Jul 30
to Andrew Paseltiner, Daniel Cheng, Chromium IPC Reviews, Ken Buchanan, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng, Ken Buchanan and mmenke
Yao Xiao added 1 comment![]( "Open in Gerrit")
File content/browser/loader/subresource_proxying_url_loader_service.cc
Line 116, Patchset 2 (Parent):
if (PrefetchURLLoaderServiceContext::IsPrefetchRequest(resource_request_in)) {mmenke . unresolved
Why remove this check? It looks like this CL doesn't remove PrefetchURLLoaderServiceContext::IsPrefetchRequest(), at least, so I assume it can still return false.
Yao Xiao
We already have an `if (!PrefetchURLLoaderServiceContext::IsPrefetchRequest(resource_request_in))` check that triggers a `ReportBadMessage` and early return above this, so there is no need for an additional check. (i.e., now that `browsing_topics` and `ad_auction_headers` have been removed, prefetch is the only remaining allowed request type.)
Related details
Attention is currently required from:
- Daniel Cheng
- Ken Buchanan
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Jul 30, 2026, 12:00:56 PM (18 hours ago) Jul 30
to Yao Xiao, Andrew Paseltiner, Daniel Cheng, Chromium IPC Reviews, Ken Buchanan, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng, Ken Buchanan and Yao Xiao
mmenke voted and added 2 comments![]( "Open in Gerrit")
Votes added by mmenke
| Code-Review | +1 |
2 comments
Patchset-level comments
mmenke . resolved
LGTM!
File content/browser/loader/subresource_proxying_url_loader_service.cc
Line 116, Patchset 2 (Parent):
if (PrefetchURLLoaderServiceContext::IsPrefetchRequest(resource_request_in)) {mmenke . resolved
Yao XiaoWhy remove this check? It looks like this CL doesn't remove PrefetchURLLoaderServiceContext::IsPrefetchRequest(), at least, so I assume it can still return false.
We already have an `if (!PrefetchURLLoaderServiceContext::IsPrefetchRequest(resource_request_in))` check that triggers a `ReportBadMessage` and early return above this, so there is no need for an additional check. (i.e., now that `browsing_topics` and `ad_auction_headers` have been removed, prefetch is the only remaining allowed request type.)
Attention is currently required from:
- Daniel Cheng
- Ken Buchanan
- Yao Xiao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yao Xiao (Gerrit)
Jul 30, 2026, 12:05:48 PM (18 hours ago) Jul 30
to Andrew Paseltiner, Daniel Cheng, Chromium IPC Reviews, Ken Buchanan, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Daniel Cheng and Ken Buchanan
Yao Xiao added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yao Xiao . resolved
(Removing kenrb@, as dcheng@ has coverage for both the blink and mojom changes.)
dcheng@: PTAL at blink and mojom. Thanks!
Related details
Attention is currently required from:
- Daniel Cheng
- Ken Buchanan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jul 30, 2026, 2:23:31 PM (15 hours ago) Jul 30
to Yao Xiao, Daniel Cheng, Andrew Paseltiner, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Yao Xiao
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Yao Xiao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yao Xiao (Gerrit)
Jul 30, 2026, 2:24:25 PM (15 hours ago) Jul 30
to Daniel Cheng, Andrew Paseltiner, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Yao Xiao voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 30, 2026, 2:32:21 PM (15 hours ago) Jul 30
to Yao Xiao, Daniel Cheng, Andrew Paseltiner, Chromium IPC Reviews, chromium...@chromium.org, apaselti...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Topics] Remove browsing_topics.mojom and ResourceRequest field
The Topics API is being deprecated and was effectively disabled in prior
cleanup work.
This CL continues the removal of dead code by deleting
browsing_topics.mojom and its containing directory. It also removes the
browsing_topics boolean field from network::ResourceRequest and
network::mojom::URLRequest.
Bug: 461709147
Change-Id: I86b3fcb566701ba6d3da41b4279fa80c4a608697
Reviewed-by: mmenke <mme...@chromium.org>
Commit-Queue: Yao Xiao <yao...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Andrew Paseltiner <apase...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1671264}
Files:
- M chrome/browser/chrome_content_browser_client.cc
- M content/browser/attribution_reporting/privacy_sandbox_ads_apis_browsertest.cc
- M content/browser/loader/subresource_proxying_url_loader_service.cc
- M services/network/prefetch_matches.cc
- M services/network/public/cpp/resource_request.h
- M services/network/public/cpp/url_request_mojom_traits.cc
- M services/network/public/cpp/url_request_mojom_traits.h
- M services/network/public/cpp/url_request_mojom_traits_perftest.cc
- M services/network/public/cpp/url_request_mojom_traits_unittest.cc
- M services/network/public/mojom/url_request.mojom
- M third_party/blink/public/mojom/BUILD.gn
- D third_party/blink/public/mojom/browsing_topics/OWNERS
- D third_party/blink/public/mojom/browsing_topics/browsing_topics.mojom
Change size: M
Delta: 13 files changed, 3 insertions(+), 76 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng, +1 by mmenke, +1 by Andrew Paseltiner
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages