Add navigation throttle to send the X-Geo header on all platforms [chromium/src : main]

[Aviv Kiss (Gerrit)]

Attention needed from Andy Paicu

Aviv Kiss added 2 comments

File chrome/browser/omnibox/geolocation_navigation_throttle.h

Line 12, Patchset 8 (Latest):namespace content {}

Aviv Kiss . unresolved

Please fix this WARNING reported by autoreview issue finding: This empty namespace declaration seems to be a leftover and can be removed.

File chrome/browser/omnibox/geolocation_navigation_throttle.cc

Line 67, Patchset 8 (Latest): }

Aviv Kiss . unresolved

Please fix this WARNING reported by autoreview issue finding: If the redirect is to a URL that is NOT a search provider, the 'X-Geo' header added in a previous hop will still be sent because SetRequestHeader persists across redirects. You should call navigation_handle()->RemoveRequestHeader(\"X-Geo\") here to prevent leaking location data to non-search URLs during redirects.

Is there anything to this autoreview finding?

Open in Gerrit

Related details

Attention is currently required from:

• Andy Paicu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Gerrit-Change-Number: 7772695

Gerrit-PatchSet: 8

Gerrit-Owner: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>

Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hans Wennborg <ha...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andy Paicu <andy...@chromium.org>

Gerrit-Comment-Date: Thu, 23 Apr 2026 14:22:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andy Paicu (Gerrit)]

Attention needed from Aviv Kiss

Andy Paicu added 2 comments

File chrome/browser/omnibox/geolocation_navigation_throttle.h

Line 12, Patchset 8:namespace content {}

Aviv Kiss . resolved

Please fix this WARNING reported by autoreview issue finding: This empty namespace declaration seems to be a leftover and can be removed.

Andy Paicu

Done

File chrome/browser/omnibox/geolocation_navigation_throttle.cc

Line 67, Patchset 8: }

Aviv Kiss . resolved

Please fix this WARNING reported by autoreview issue finding: If the redirect is to a URL that is NOT a search provider, the 'X-Geo' header added in a previous hop will still be sent because SetRequestHeader persists across redirects. You should call navigation_handle()->RemoveRequestHeader(\"X-Geo\") here to prevent leaking location data to non-search URLs during redirects.

Is there anything to this autoreview finding?

Andy Paicu

Yeah this is a good catch. I added logic to remove the header if it redirects to a non-DSE origin and added some tests.

Open in Gerrit

Related details

Attention is currently required from:

• Aviv Kiss

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Gerrit-Change-Number: 7772695

Gerrit-PatchSet: 9

Gerrit-Owner: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>

Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hans Wennborg <ha...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Aviv Kiss <aviv...@google.com>

Gerrit-Comment-Date: Thu, 23 Apr 2026 16:41:03 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Aviv Kiss <aviv...@google.com>

[Aviv Kiss (Gerrit)]

Attention needed from Andy Paicu

Aviv Kiss voted and added 1 comment

Votes added by Aviv Kiss

Code-Review

+1

1 comment

File chrome/browser/omnibox/geolocation_navigation_throttle.cc

Line 65, Patchset 9 (Latest): navigation_handle()->SetRequestHeader("X-Geo", *geo_header);

Aviv Kiss . unresolved

nit: pull this out into a named constant

Open in Gerrit

Related details

Attention is currently required from:

• Andy Paicu

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Gerrit-Change-Number: 7772695

Gerrit-PatchSet: 9

Gerrit-Owner: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>

Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hans Wennborg <ha...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andy Paicu <andy...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Apr 2026 01:38:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Lei Zhang (Gerrit)]

Attention needed from Andy Paicu

Lei Zhang added 7 comments

File chrome/browser/omnibox/BUILD.gn

Line 56, Patchset 9 (Latest): if (!is_android) {

Lei Zhang . unresolved

Entire source set should be !is_android? Maybe for now? The long term question is whether android_browsertests and browser_tests will share this source set.

File chrome/browser/omnibox/geolocation_header_browsertest.cc

Line 78, Patchset 9 (Latest): if (request.relative_url.find("/search?q=redirect-non-dse") == 0) {

Lei Zhang . unresolved

In C++20, there's std::string::starts_with(), which is more readable and probably also faster. Other parts of this CL is using that already.

Line 95, Patchset 9 (Latest): if (request.headers.find("X-Geo") != request.headers.end()) {

Lei Zhang . unresolved

Reuse the iterator find() returns instead of doing the same lookup twice.

Line 108, Patchset 9 (Latest): void WaitForSearchRequest() {

Lei Zhang . unresolved

This is dead code.

Line 114, Patchset 9 (Latest): std::string GetXGeoHeader() const { return xgeo_header_; }

Lei Zhang . unresolved

Since `xgeo_header_` is only `protected`, all the test cases can actually access it directly. So this isn't needed?

As-is: Return a const-ref, and don't bother making a copy in the callers when not needed.

File chrome/browser/omnibox/geolocation_navigation_throttle_unittest.cc

Line 38, Patchset 9 (Latest): TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(

Lei Zhang . unresolved

Unit tests should clean up after themselves in TearDown(), and not leave global resources in a modified state.

File components/omnibox/browser/search_provider.cc

Line 44, Patchset 9 (Latest):#if !BUILDFLAG(IS_IOS)

Lei Zhang . unresolved

Put this after all the non-conditional includes.

Gerrit-CC: Lei Zhang <the...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andy Paicu <andy...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Apr 2026 02:02:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andy Paicu (Gerrit)]

Attention needed from Lei Zhang

Andy Paicu added 8 comments

File chrome/browser/omnibox/BUILD.gn

Line 56, Patchset 9: if (!is_android) {

Lei Zhang . resolved

Entire source set should be !is_android? Maybe for now? The long term question is whether android_browsertests and browser_tests will share this source set.

Andy Paicu

I don't think this source set will ever be on Android since interactive tests use a different framework on Android (in Java). So I put the whole source set in the condition, and slightly reworked the chrome/test/BUILD.gn DEPS include to make sure it's only included on !Android.

File chrome/browser/omnibox/geolocation_header_browsertest.cc

Line 78, Patchset 9: if (request.relative_url.find("/search?q=redirect-non-dse") == 0) {

Lei Zhang . resolved

In C++20, there's std::string::starts_with(), which is more readable and probably also faster. Other parts of this CL is using that already.

Andy Paicu

Done

Line 95, Patchset 9: if (request.headers.find("X-Geo") != request.headers.end()) {

Lei Zhang . resolved

Reuse the iterator find() returns instead of doing the same lookup twice.

Andy Paicu

Done

Line 108, Patchset 9: void WaitForSearchRequest() {

Lei Zhang . resolved

This is dead code.

Andy Paicu

Done

Line 114, Patchset 9: std::string GetXGeoHeader() const { return xgeo_header_; }

Lei Zhang . resolved

Since `xgeo_header_` is only `protected`, all the test cases can actually access it directly. So this isn't needed?

As-is: Return a const-ref, and don't bother making a copy in the callers when not needed.

Andy Paicu

Done

File chrome/browser/omnibox/geolocation_navigation_throttle.cc

Line 65, Patchset 9: navigation_handle()->SetRequestHeader("X-Geo", *geo_header);

Aviv Kiss . resolved

nit: pull this out into a named constant

Andy Paicu

Done

File chrome/browser/omnibox/geolocation_navigation_throttle_unittest.cc

Line 38, Patchset 9: TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(

Lei Zhang . resolved

Unit tests should clean up after themselves in TearDown(), and not leave global resources in a modified state.

Andy Paicu

Done

File components/omnibox/browser/search_provider.cc

Line 44, Patchset 9:#if !BUILDFLAG(IS_IOS)

Lei Zhang . resolved

Put this after all the non-conditional includes.

Andy Paicu

Done

Open in Gerrit

Related details

Attention is currently required from:

• Lei Zhang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Gerrit-Change-Number: 7772695

Gerrit-PatchSet: 11

Gerrit-Owner: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>

Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hans Wennborg <ha...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Lei Zhang <the...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Apr 2026 09:18:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Lei Zhang <the...@chromium.org>

Comment-In-Reply-To: Aviv Kiss <aviv...@google.com>

[Moe Ahmadi (Gerrit)]

Attention needed from Andy Paicu and Lei Zhang

Moe Ahmadi voted and added 4 comments

Votes added by Moe Ahmadi

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Moe Ahmadi . resolved

LGTM

File chrome/browser/omnibox/geolocation_navigation_throttle.cc

Line 48, Patchset 11 (Latest): if (!(navigation_handle()->GetPageTransition() &

Moe Ahmadi . unresolved

optional: probably worth explicitly checking for the validity of the URL and HTTPS scheme

Line 59, Patchset 11 (Latest):

Moe Ahmadi . unresolved

should we also check if the URL is a search URL from the DSE?

`TURLService::IsSearchResultsPageFromDefaultSearchProvider()`

Line 79, Patchset 11 (Latest): return WillStartRequest();

Moe Ahmadi . unresolved

optional: prefer a `ProcessNavigation()` helper method that both WillStartRequest and WillRedirectRequest call.

Open in Gerrit

Related details

Attention is currently required from:

• Andy Paicu
• Lei Zhang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Attention: Andy Paicu <andy...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Apr 2026 11:28:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Andy Paicu (Gerrit)]

Attention needed from Lei Zhang

Andy Paicu added 3 comments

File chrome/browser/omnibox/geolocation_navigation_throttle.cc

Line 48, Patchset 11: if (!(navigation_handle()->GetPageTransition() &

Moe Ahmadi . resolved

optional: probably worth explicitly checking for the validity of the URL and HTTPS scheme

Andy Paicu

All of these checks are done in the GeolocationHeaderService, because it's more robust than to rely on multiple different call sites to be diligent about doing the same checks.

Line 59, Patchset 11:

Moe Ahmadi . resolved

should we also check if the URL is a search URL from the DSE?

`TURLService::IsSearchResultsPageFromDefaultSearchProvider()`

Andy Paicu

The GeolocationHeaderService checks that the URL is part of the DSE

Line 79, Patchset 11: return WillStartRequest();

Moe Ahmadi . resolved

optional: prefer a `ProcessNavigation()` helper method that both WillStartRequest and WillRedirectRequest call.

Andy Paicu

Done

Open in Gerrit

Related details

Attention is currently required from:

• Lei Zhang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Gerrit-Change-Number: 7772695

Gerrit-PatchSet: 16

Gerrit-Owner: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>

Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hans Wennborg <ha...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Lei Zhang <the...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Apr 2026 14:25:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Moe Ahmadi <mah...@chromium.org>

[Lei Zhang (Gerrit)]

Attention needed from Andy Paicu

Lei Zhang added 2 comments

File chrome/browser/omnibox/geolocation_header_browsertest.cc

Line 127, Patchset 16 (Latest): base::test::ScopedFeatureList feature_list_;

Lei Zhang . unresolved

It's generally better to put this at the top, so it gets destroyed last. If the ScopedFeatureList gets destroyed first, the destructors for other members may behave incorrectly since the feature state changed out from under them.

File components/omnibox/browser/search_provider.cc

Line 74, Patchset 16 (Latest):#if !BUILDFLAG(IS_IOS)

Lei Zhang . unresolved

Still need to move down a bit further.

Open in Gerrit

Related details

Attention is currently required from:

• Andy Paicu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Gerrit-Change-Number: 7772695

Gerrit-PatchSet: 16

Gerrit-Owner: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>

Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hans Wennborg <ha...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Lei Zhang <the...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andy Paicu <andy...@chromium.org>

Gerrit-Comment-Date: Fri, 24 Apr 2026 16:33:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andy Paicu (Gerrit)]

Attention needed from Lei Zhang

Andy Paicu voted and added 3 comments

Votes added by Andy Paicu

Commit-Queue

+2

3 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Andy Paicu . resolved

Thank you all

File chrome/browser/omnibox/geolocation_header_browsertest.cc

Line 127, Patchset 16: base::test::ScopedFeatureList feature_list_;

Lei Zhang . resolved

It's generally better to put this at the top, so it gets destroyed last. If the ScopedFeatureList gets destroyed first, the destructors for other members may behave incorrectly since the feature state changed out from under them.

Andy Paicu

Done

File components/omnibox/browser/search_provider.cc

Line 74, Patchset 16:#if !BUILDFLAG(IS_IOS)

Lei Zhang . resolved

Still need to move down a bit further.

Andy Paicu

Done

Open in Gerrit

Related details

Attention is currently required from:

• Lei Zhang

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Gerrit-Change-Number: 7772695

Gerrit-PatchSet: 17

Gerrit-Owner: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>

Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hans Wennborg <ha...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Lei Zhang <the...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Tue, 28 Apr 2026 07:40:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Lei Zhang <the...@chromium.org>

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

11 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/omnibox/geolocation_navigation_throttle.h
Insertions: 3, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/omnibox/geolocation_navigation_throttle.cc
Insertions: 15, Deletions: 10.

The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/omnibox/geolocation_header_browsertest.cc
Insertions: 87, Deletions: 2.

The diff is too large to show. Please review the diff.
```
```
The name of the file: components/omnibox/browser/search_provider.cc
Insertions: 1, Deletions: 2.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Add navigation throttle to send the X-Geo header on all platforms

As part of the work to port the X-Geo header on all platforms, this CL
will make use of the previously added GeolocationHeaderService to
retrieve and attach the X-Geo HTTP header to appropriate navigation
HTTP requests.

Fixed: 494149299

Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7772695

Reviewed-by: Aviv Kiss <aviv...@google.com>

Commit-Queue: Andy Paicu <andy...@chromium.org>

Reviewed-by: Moe Ahmadi <mah...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1621605}

Files:

• M chrome/browser/autocomplete/BUILD.gn
• M chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
• M chrome/browser/autocomplete/chrome_autocomplete_provider_client.h
• M chrome/browser/chrome_content_browser_client_navigation_throttles.cc
• M chrome/browser/omnibox/BUILD.gn
• A chrome/browser/omnibox/geolocation_header_browsertest.cc
• A chrome/browser/omnibox/geolocation_navigation_throttle.cc
• A chrome/browser/omnibox/geolocation_navigation_throttle.h
• A chrome/browser/omnibox/geolocation_navigation_throttle_unittest.cc
• M chrome/test/BUILD.gn
• M components/omnibox/browser/autocomplete_provider_client.cc
• M components/omnibox/browser/autocomplete_provider_client.h
• M components/omnibox/browser/geolocation_header_service.cc
• M components/omnibox/browser/search_provider.cc

Change size: L

Delta: 14 files changed, 836 insertions(+), 6 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Moe Ahmadi, +1 by Aviv Kiss

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3b2dddd5953be63351d3a0cc45c53d95d9064659

Gerrit-Change-Number: 7772695

Gerrit-PatchSet: 18

Gerrit-Owner: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Andy Paicu <andy...@chromium.org>

Gerrit-Reviewer: Aviv Kiss <aviv...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Moe Ahmadi <mah...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>