gardener: fix flaky browser test [chromium/src : main]

0 views
Skip to first unread message

Elly (Gerrit)

unread,
Apr 28, 2026, 12:10:36 PM (yesterday) Apr 28
to Elly, Annie Sullivan, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan

Elly voted and added 1 comment

Votes added by Elly

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Elly . resolved

sullivan: please have a look? :)

Open in Gerrit

Related details

Attention is currently required from:
  • Annie Sullivan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53a3196b93d02e46c502733a2ab3337d31434943
Gerrit-Change-Number: 7799896
Gerrit-PatchSet: 1
Gerrit-Owner: Elly <elly...@chromium.org>
Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
Gerrit-Reviewer: Elly <elly...@chromium.org>
Gerrit-Attention: Annie Sullivan <sull...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 16:10:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Annie Sullivan (Gerrit)

unread,
Apr 28, 2026, 12:16:28 PM (yesterday) Apr 28
to Elly, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Elly

Annie Sullivan voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Elly
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53a3196b93d02e46c502733a2ab3337d31434943
Gerrit-Change-Number: 7799896
Gerrit-PatchSet: 1
Gerrit-Owner: Elly <elly...@chromium.org>
Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
Gerrit-Reviewer: Elly <elly...@chromium.org>
Gerrit-Attention: Elly <elly...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 16:16:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 28, 2026, 1:01:10 PM (yesterday) Apr 28
to Elly, Annie Sullivan, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
gardener: fix flaky browser test

This test has a typo in it, which causes it not to wait for one of the
metrics it expects to have been logged. This change fixes the typo and
deflakes the test.
Bug: None
Change-Id: I53a3196b93d02e46c502733a2ab3337d31434943
Commit-Queue: Elly <elly...@chromium.org>
Reviewed-by: Annie Sullivan <sull...@chromium.org>
Auto-Submit: Elly <elly...@chromium.org>
Commit-Queue: Annie Sullivan <sull...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1621851}
Files:
  • M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Annie Sullivan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I53a3196b93d02e46c502733a2ab3337d31434943
Gerrit-Change-Number: 7799896
Gerrit-PatchSet: 2
Gerrit-Owner: Elly <elly...@chromium.org>
Gerrit-Reviewer: Annie Sullivan <sull...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Elly <elly...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages