LinkPreview: Clean up stale LinkPreview leftovers [chromium/src : main]
0 views
Skip to first unread message
Avi Drissman (Gerrit)
May 19, 2026, 10:55:03 AM (16 hours ago) May 19
to Yue Liu, Avi Drissman, Chromium LUCI CQ, Jeremy Roman, Scott Haseley, Chang Liu, chromium...@chromium.org, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Chang Liu, Jeremy Roman, Scott Haseley and Yue Liu
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Chang Liu
- Jeremy Roman
- Scott Haseley
- Yue Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
May 19, 2026, 11:40:28 AM (16 hours ago) May 19
to Yue Liu, Avi Drissman, Chromium LUCI CQ, Jeremy Roman, Chang Liu, chromium...@chromium.org, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Chang Liu, Jeremy Roman and Yue Liu
Scott Haseley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Haseley
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Chang Liu
- Jeremy Roman
- Yue Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yue Liu (Gerrit)
May 19, 2026, 1:21:01 PM (14 hours ago) May 19
to Scott Haseley, Avi Drissman, Chromium LUCI CQ, Jeremy Roman, Chang Liu, chromium...@chromium.org, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Chang Liu and Jeremy Roman
Yue Liu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Chang Liu
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yue Liu (Gerrit)
May 19, 2026, 10:16:34 PM (5 hours ago) May 19
to Scott Haseley, Avi Drissman, Chromium LUCI CQ, Jeremy Roman, Chang Liu, chromium...@chromium.org, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Chromium LUCI CQ (Gerrit)
May 19, 2026, 10:48:00 PM (4 hours ago) May 19
to Yue Liu, Scott Haseley, Avi Drissman, Jeremy Roman, Chang Liu, chromium...@chromium.org, Nate Chapin, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
LinkPreview: Clean up stale LinkPreview leftovers
Follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/7727990 which
removed the Desktop Link Preview feature but left a few orphans behind:
- Remove the EnsureLinkPreviewTriggererInitialized() declaration in
LocalFrame; its definition was already deleted from local_frame.cc.
- Remove WebDocument::InitiatePreview(); the implementation is now an
empty no-op and there are no remaining callers in the tree.
- Drop the stale kNavigationPolicyLinkPreview reference from the
FormSubmission::Create comment.
- Delete ContextMenuBrowserTest.LinkPreviewInvisibleForIWALinks; the
body lost all its EXPECT/ASSERTs in the removal CL and no longer
verifies anything.
Change-Id: Ic5e27d40f7a9d35f481c261bcdce555c457a7d3b
Reviewed-by: Avi Drissman <a...@chromium.org>
Reviewed-by: Scott Haseley <shas...@chromium.org>
Commit-Queue: Yue Liu <yue...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1633304}
Files:
- M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
- M third_party/blink/public/web/web_document.h
- M third_party/blink/renderer/core/exported/web_document.cc
- M third_party/blink/renderer/core/frame/local_frame.h
- M third_party/blink/renderer/core/loader/form_submission.h
Change size: S
Delta: 5 files changed, 1 insertion(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Scott Haseley, +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages