[tracing] Migrate legacy TRACE_EVENT_SCOPE_THREAD instant events [chromium/src : main]

0 views
Skip to first unread message

Gabriel Charette (Gerrit)

unread,
Apr 28, 2026, 11:13:32 AM (yesterday) Apr 28
to Etienne Pierre-Doray, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Nate Chapin, Kenneth Rohde Christiansen, Raphael Kubo da Costa, CJ DiMeglio, Hiroki Nakagawa, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, Ian Vollick, alexmo...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dmurph+watching...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtapuska+ch...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, jasonrobe...@google.com, jbauma...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, jshin...@chromium.org, kainin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, olka+...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, schedule...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org, zol...@webkit.org
Attention needed from Etienne Pierre-Doray

Gabriel Charette voted and added 2 comments

Votes added by Gabriel Charette

Code-Review+1
Owners-Override+1

2 comments

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Gabriel Charette . resolved

LGTM+OO w/ comment

File ui/gl/delegated_ink_point_renderer_gpu.cc
Line 34, Patchset 13 (Latest):bool TraceEventOnFailure(HRESULT hr, perfetto::StaticString name) {
Gabriel Charette . unresolved

Isn't it safer to continue to require a const char* as arg and only cast it to perfetto::StaticString inline below? How do we ensure that caller is safely passing a static string otherwise?

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0ce101008fb9b76ceddea31d01faf5fe5d1a173e
Gerrit-Change-Number: 7795300
Gerrit-PatchSet: 13
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-CC: CJ DiMeglio <lethala...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Frank Liberato <libe...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 15:13:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Apr 28, 2026, 11:18:42 AM (yesterday) Apr 28
to Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Nate Chapin, Kenneth Rohde Christiansen, Raphael Kubo da Costa, CJ DiMeglio, Hiroki Nakagawa, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, Ian Vollick, alexmo...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dmurph+watching...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtapuska+ch...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, jasonrobe...@google.com, jbauma...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, jshin...@chromium.org, kainin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, olka+...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, schedule...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org, zol...@webkit.org
Attention needed from Gabriel Charette

Etienne Pierre-Doray added 1 comment

File ui/gl/delegated_ink_point_renderer_gpu.cc
Line 34, Patchset 13 (Latest):bool TraceEventOnFailure(HRESULT hr, perfetto::StaticString name) {
Gabriel Charette . unresolved

Isn't it safer to continue to require a const char* as arg and only cast it to perfetto::StaticString inline below? How do we ensure that caller is safely passing a static string otherwise?

Etienne Pierre-Doray

If TraceEventOnFailure() takes a const char*, one can do:
```
std::string str = ...
TraceEventOnFailure(..., str.c_str());
```

Whereas taking a StaticString requires explicit conversion which forces the caller to think about it. Either way we can't really enforce the string to be compile time
(we could improve StaticString to be consteval but this is done by changing perfetto).

Open in Gerrit

Related details

Attention is currently required from:
  • Gabriel Charette
Gerrit-Attention: Gabriel Charette <g...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 15:18:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gabriel Charette <g...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Gabriel Charette (Gerrit)

unread,
Apr 28, 2026, 11:20:40 AM (yesterday) Apr 28
to Etienne Pierre-Doray, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Nate Chapin, Kenneth Rohde Christiansen, Raphael Kubo da Costa, CJ DiMeglio, Hiroki Nakagawa, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, Ian Vollick, alexmo...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dmurph+watching...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtapuska+ch...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, jasonrobe...@google.com, jbauma...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, jshin...@chromium.org, kainin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, olka+...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, schedule...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org, zol...@webkit.org
Attention needed from Etienne Pierre-Doray

Gabriel Charette added 1 comment

File ui/gl/delegated_ink_point_renderer_gpu.cc
Line 34, Patchset 13 (Latest):bool TraceEventOnFailure(HRESULT hr, perfetto::StaticString name) {
Gabriel Charette . resolved

Isn't it safer to continue to require a const char* as arg and only cast it to perfetto::StaticString inline below? How do we ensure that caller is safely passing a static string otherwise?

Etienne Pierre-Doray

If TraceEventOnFailure() takes a const char*, one can do:
```
std::string str = ...
TraceEventOnFailure(..., str.c_str());
```

Whereas taking a StaticString requires explicit conversion which forces the caller to think about it. Either way we can't really enforce the string to be compile time
(we could improve StaticString to be consteval but this is done by changing perfetto).

Gabriel Charette

Ack, SG.

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 15:20:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Gabriel Charette <g...@chromium.org>
    Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
    satisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Apr 28, 2026, 11:35:52 AM (yesterday) Apr 28
    to Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Nate Chapin, Kenneth Rohde Christiansen, Raphael Kubo da Costa, CJ DiMeglio, Hiroki Nakagawa, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, Ian Vollick, alexmo...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dmurph+watching...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtapuska+ch...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, jasonrobe...@google.com, jbauma...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, jshin...@chromium.org, kainin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, olka+...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, schedule...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org, zol...@webkit.org

    Etienne Pierre-Doray voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Tue, 28 Apr 2026 15:35:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 28, 2026, 11:40:09 AM (yesterday) Apr 28
    to Etienne Pierre-Doray, Gabriel Charette, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Hongchan Choi, Nate Chapin, Kenneth Rohde Christiansen, Raphael Kubo da Costa, CJ DiMeglio, Hiroki Nakagawa, Rijubrata Bhaumik, Sadrul Chowdhury, Stephen Chenney, Ian Vollick, alexmo...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, csharris...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, dmurph+watching...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtapuska+ch...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, halliwe...@chromium.org, hayato...@chromium.org, horo+...@chromium.org, jasonrobe...@google.com, jbauma...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, jshin...@chromium.org, kainin...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, olka+...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, schedule...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, wfh+...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Migrate legacy TRACE_EVENT_SCOPE_THREAD instant events

    This change is functionally equivalent and mechanical:

    TRACE_EVENT_INSTANT[0-3](..., TRACE_EVENT_SCOPE_THREAD) ->
    TRACE_EVENT_INSTANT(...)

    This main motivation is to isolate remaining legacy TRACE_EVENT_INSTANT
    that are emitted outside of the current thread.
    Bug: 432427382
    Change-Id: I0ce101008fb9b76ceddea31d01faf5fe5d1a173e
    Owners-Override: Gabriel Charette <g...@chromium.org>
    Reviewed-by: Gabriel Charette <g...@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1621794}
    Files:
    • M android_webview/browser/aw_contents.cc
    • M android_webview/browser/gfx/browser_view_renderer.cc
    • M android_webview/browser/gfx/display_scheduler_webview.cc
    • M android_webview/browser/gfx/root_frame_sink.cc
    • M base/message_loop/message_pump_win.cc
    • M base/task/sequence_manager/sequence_manager_impl.cc
    • M base/task/thread_pool/worker_thread.cc
    • M base/test/trace_event_analyzer_unittest.cc
    • M cc/animation/animation_host.cc
    • M cc/animation/keyframe_model.cc
    • M cc/animation/scroll_offset_animations_impl.cc
    • M cc/base/devtools_instrumentation.h
    • M cc/benchmarks/benchmark_instrumentation.cc
    • M cc/input/browser_controls_offset_manager.cc
    • M cc/input/input_handler.cc
    • M cc/layers/tile_based_layer_impl.h
    • M cc/scheduler/scheduler.cc
    • M cc/scheduler/scheduler_state_machine.cc
    • M cc/slim/layer_tree_impl.cc
    • M cc/tiles/gpu_image_decode_cache.cc
    • M cc/tiles/tile_manager.cc
    • M cc/trees/draw_property_utils.cc
    • M cc/trees/image_animation_controller.cc
    • M cc/trees/layer_tree_host_impl.cc
    • M cc/trees/property_tree.cc
    • M cc/trees/property_tree_layer_list_delegate.cc
    • M cc/trees/property_tree_layer_tree_delegate.cc
    • M cc/trees/proxy_impl.cc
    • M cc/trees/proxy_main.cc
    • M cc/trees/single_thread_proxy.cc
    • M chrome/browser/bad_message.cc
    • M chrome/browser/chrome_browser_application_mac.mm
    • M chrome/browser/first_run/upgrade_util_win.cc
    • M chrome/browser/page_load_metrics/observers/core/ukm_page_load_metrics_observer.cc
    • M chrome/browser/predictors/lcp_critical_path_predictor/prewarm_http_disk_cache_manager.cc
    • M chrome/browser/ui/browser.cc
    • M chrome/browser/ui/thumbnails/background_thumbnail_video_capturer.cc
    • M chromecast/external_mojo/public/cpp/external_mojo_broker.cc
    • M components/download/internal/common/download_file_impl.cc
    • M components/download/internal/common/download_item_impl.cc
    • M components/input/child_frame_input_helper.cc
    • M components/input/fling_controller.cc
    • M components/input/input_router_impl.cc
    • M components/input/mouse_wheel_event_queue.cc
    • M components/input/render_widget_host_input_event_router.cc
    • M components/input/timeout_monitor.cc
    • M components/input/touch_action_filter.cc
    • M components/input/touchpad_pinch_event_queue.cc
    • M components/mirroring/service/remoting_sender.cc
    • M components/mirroring/service/rtp_stream.cc
    • M components/mirroring/service/video_capture_client.cc
    • M components/openscreen_platform/event_trace_logging_platform.cc
    • M components/remote_cocoa/app_shim/native_widget_mac_nswindow.mm
    • M components/services/storage/service_worker/service_worker_storage.cc
    • M components/startup_metric_utils/common/startup_metric_utils.cc
    • M components/tracing/test/trace_event_perftest.cc
    • M components/ui_devtools/tracing_agent.cc
    • M components/viz/service/debugger/viz_debugger.h
    • M components/viz/service/display/delegated_ink_point_renderer_base.cc
    • M components/viz/service/display/delegated_ink_point_renderer_skia.cc
    • M components/viz/service/display/display.cc
    • M components/viz/service/display/display_damage_tracker.cc
    • M components/viz/service/display/display_scheduler.cc
    • M components/viz/service/display/overlay_processor_delegated_support.cc
    • M components/viz/service/display/surface_aggregator.cc
    • M components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • M components/viz/service/frame_sinks/external_begin_frame_source_mac.cc
    • M components/viz/service/frame_sinks/external_begin_frame_source_win.cc
    • M components/viz/service/surfaces/surface.cc
    • M components/viz/service/surfaces/surface_manager.cc
    • M content/app/content_main_runner_impl.cc
    • M content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
    • M content/browser/android/synchronous_compositor_host.cc
    • M content/browser/bad_message.cc
    • M content/browser/browser_main.cc
    • M content/browser/browser_main_loop.cc
    • M content/browser/devtools/protocol/tracing_handler.cc
    • M content/browser/gpu/gpu_process_host.cc
    • M content/browser/interest_group/debuggable_auction_worklet.cc
    • M content/browser/media/capture/web_contents_auto_scaler.cc
    • M content/browser/media/capture/web_contents_frame_tracker.cc
    • M content/browser/media/forwarding_audio_stream_factory.cc
    • M content/browser/renderer_host/input/mouse_wheel_phase_handler.cc
    • M content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
    • M content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc
    • M content/browser/renderer_host/render_widget_host_impl.cc
    • M content/browser/service_worker/service_worker_version.cc
    • M content/browser/web_contents/web_contents_impl.cc
    • M content/browser/web_package/signed_exchange_utils.cc
    • M content/browser/xr/service/vr_service_impl.cc
    • M content/browser/xr/service/xr_runtime_manager_impl.cc
    • M content/renderer/renderer_main.cc
    • M content/services/auction_worklet/public/cpp/auction_downloader.cc
    • M content/services/isolated_xr_device/xr_runtime_provider.cc
    • M device/vr/openxr/openxr_api_wrapper.cc
    • M device/vr/openxr/openxr_render_loop.cc
    • M device/vr/windows/d3d11_texture_helper.cc
    • M media/audio/apple/audio_low_latency_input.cc
    • M media/audio/system_glitch_reporter.cc
    • M media/audio/win/audio_low_latency_input_win.cc
    • M media/audio/win/audio_low_latency_output_win.cc
    • M media/base/silent_sink_suspender.cc
    • M media/cast/encoding/audio_encoder.cc
    • M media/cast/sender/audio_sender.cc
    • M media/cast/sender/openscreen_frame_sender.cc
    • M media/cast/sender/video_sender.cc
    • M media/gpu/v4l2/v4l2_queue.cc
    • M media/mojo/services/mojo_demuxer_stream_adapter.cc
    • M media/renderers/video_renderer_impl.cc
    • M media/renderers/video_resource_updater.cc
    • M services/audio/delay_buffer.cc
    • M services/audio/input_sync_writer.cc
    • M services/audio/loopback_signal_provider.cc
    • M services/audio/loopback_stream.cc
    • M services/audio/processing_audio_fifo.cc
    • M services/audio/snooper_node.cc
    • M services/audio/sync_reader.cc
    • M services/service_manager/service_manager.cc
    • M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
    • M third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
    • M third_party/blink/renderer/core/content_capture/content_capture_task.cc
    • M third_party/blink/renderer/core/events/pointer_event_factory.cc
    • M third_party/blink/renderer/core/fragment_directive/text_fragment_anchor_metrics.cc
    • M third_party/blink/renderer/core/frame/frame.cc
    • M third_party/blink/renderer/core/frame/local_frame_mojo_handler.cc
    • M third_party/blink/renderer/core/frame/visual_viewport.cc
    • M third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
    • M third_party/blink/renderer/core/frame/web_local_frame_impl.cc
    • M third_party/blink/renderer/core/inspector/console_message_storage.cc
    • M third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • M third_party/blink/renderer/core/inspector/inspector_trace_events.h
    • M third_party/blink/renderer/core/layout/layout_image.cc
    • M third_party/blink/renderer/core/layout/layout_shift_tracker.cc
    • M third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • M third_party/blink/renderer/core/loader/resource_load_observer_for_frame.cc
    • M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • M third_party/blink/renderer/core/paint/timing/paint_timing_visualizer.cc
    • M third_party/blink/renderer/core/scroll/scrollable_area.cc
    • M third_party/blink/renderer/modules/media/audio/audio_renderer_sink_cache.cc
    • M third_party/blink/renderer/modules/mediastream/media_stream_video_renderer_sink.cc
    • M third_party/blink/renderer/modules/mediastream/web_media_player_ms_compositor.cc
    • M third_party/blink/renderer/modules/webaudio/script_processor_handler.cc
    • M third_party/blink/renderer/modules/webgpu/external_texture_helper.cc
    • M third_party/blink/renderer/platform/audio/audio_destination.cc
    • M third_party/blink/renderer/platform/audio/push_pull_fifo.cc
    • M third_party/blink/renderer/platform/graphics/bitmap_image.cc
    • M third_party/blink/renderer/platform/graphics/image.cc
    • M third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • M third_party/blink/renderer/platform/p2p/ipc_socket_factory.cc
    • M third_party/blink/renderer/platform/video_capture/video_capture_impl.cc
    • M third_party/blink/renderer/platform/widget/input/compositor_thread_event_queue.cc
    • M third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc
    • M third_party/blink/renderer/platform/widget/input/main_thread_event_queue.cc
    • M third_party/blink/renderer/platform/widget/input/widget_input_handler_manager.cc
    • M ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
    • M ui/base/cocoa/command_dispatcher.mm
    • M ui/compositor/compositor_property_tree_delegate.cc
    • M ui/events/blink/fling_booster.cc
    • M ui/gfx/android/android_surface_control_compat.cc
    • M ui/gfx/delegated_ink_point.cc
    • M ui/gfx/render_text_harfbuzz.cc
    • M ui/gl/delegated_ink_point_renderer_gpu.cc
    • M ui/gl/gl_surface_egl.cc
    • M ui/gl/gl_surface_egl_surface_control.cc
    • M ui/gl/swap_chain_presenter.cc
    • M ui/ozone/platform/drm/gpu/drm_device.cc
    • M ui/views/win/pen_id_handler.cc
    • M ui/wm/core/compound_event_filter.cc
    Change size: XL
    Delta: 169 files changed, 942 insertions(+), 1254 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Gabriel Charette
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0ce101008fb9b76ceddea31d01faf5fe5d1a173e
    Gerrit-Change-Number: 7795300
    Gerrit-PatchSet: 14
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
    Gerrit-CC: CJ DiMeglio <lethala...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages