[WaaP] Introduce namespace `waap` for util functions [chromium/src : main]
0 views
Skip to first unread message
Ming-Ying Chung (Gerrit)
Nov 4, 2025, 1:56:49 AM (2 days ago) Nov 4
to Shunya Shishido, Chromium LUCI CQ, AyeAye, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org
Attention needed from Shunya Shishido
Ming-Ying Chung voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shunya Shishido (Gerrit)
Nov 4, 2025, 4:05:01 AM (2 days ago) Nov 4
to Ming-Ying Chung, Chromium LUCI CQ, AyeAye, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org
Attention needed from Ming-Ying Chung
Shunya Shishido voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ming-Ying Chung
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ming-Ying Chung (Gerrit)
Nov 4, 2025, 4:12:46 AM (2 days ago) Nov 4
to Shunya Shishido, Chromium LUCI CQ, AyeAye, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org
Ming-Ying Chung voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 4, 2025, 4:15:19 AM (2 days ago) Nov 4
to Ming-Ying Chung, Shunya Shishido, AyeAye, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[WaaP] Introduce namespace `waap` for util functions
To address this [comment][1].
[1]: https://chromium-review.googlesource.com/c/chromium/src/+/7104121/comment/fa265a41_bab8c96f/
Bug: 448794588
Change-Id: I78c929acf6e42bed8f7015b9582af455f2b81779
Reviewed-by: Shunya Shishido <sisid...@chromium.org>
Commit-Queue: Ming-Ying Chung <my...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1539849}
Files:
- M chrome/browser/chrome_content_browser_client.cc
- M chrome/browser/page_load_metrics/observers/initial_webui_page_load_metrics_observer.cc
- M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
- M chrome/browser/ui/waap/waap_utils.cc
- M chrome/browser/ui/waap/waap_utils.h
- M chrome/browser/ui/waap/waap_utils_unittest.cc
Change size: S
Delta: 6 files changed, 18 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Shunya Shishido
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages