[WaaP] Introduce namespace `waap` for util functions [chromium/src : main]

0 views
Skip to first unread message

Ming-Ying Chung (Gerrit)

unread,
Nov 4, 2025, 1:56:49 AM (2 days ago) Nov 4
to Shunya Shishido, Chromium LUCI CQ, AyeAye, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org
Attention needed from Shunya Shishido

Ming-Ying Chung voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shunya Shishido
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I78c929acf6e42bed8f7015b9582af455f2b81779
Gerrit-Change-Number: 7115405
Gerrit-PatchSet: 1
Gerrit-Owner: Ming-Ying Chung <my...@chromium.org>
Gerrit-Reviewer: Ming-Ying Chung <my...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 06:56:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shunya Shishido (Gerrit)

unread,
Nov 4, 2025, 4:05:01 AM (2 days ago) Nov 4
to Ming-Ying Chung, Chromium LUCI CQ, AyeAye, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org
Attention needed from Ming-Ying Chung

Shunya Shishido voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ming-Ying Chung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I78c929acf6e42bed8f7015b9582af455f2b81779
Gerrit-Change-Number: 7115405
Gerrit-PatchSet: 1
Gerrit-Owner: Ming-Ying Chung <my...@chromium.org>
Gerrit-Reviewer: Ming-Ying Chung <my...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Attention: Ming-Ying Chung <my...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 09:04:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ming-Ying Chung (Gerrit)

unread,
Nov 4, 2025, 4:12:46 AM (2 days ago) Nov 4
to Shunya Shishido, Chromium LUCI CQ, AyeAye, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org

Ming-Ying Chung voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I78c929acf6e42bed8f7015b9582af455f2b81779
Gerrit-Change-Number: 7115405
Gerrit-PatchSet: 1
Gerrit-Owner: Ming-Ying Chung <my...@chromium.org>
Gerrit-Reviewer: Ming-Ying Chung <my...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 09:12:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 4, 2025, 4:15:19 AM (2 days ago) Nov 4
to Ming-Ying Chung, Shunya Shishido, AyeAye, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, bmcquad...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[WaaP] Introduce namespace `waap` for util functions

To address this [comment][1].

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/7104121/comment/fa265a41_bab8c96f/
Bug: 448794588
Change-Id: I78c929acf6e42bed8f7015b9582af455f2b81779
Reviewed-by: Shunya Shishido <sisid...@chromium.org>
Commit-Queue: Ming-Ying Chung <my...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1539849}
Files:
  • M chrome/browser/chrome_content_browser_client.cc
  • M chrome/browser/page_load_metrics/observers/initial_webui_page_load_metrics_observer.cc
  • M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
  • M chrome/browser/ui/waap/waap_utils.cc
  • M chrome/browser/ui/waap/waap_utils.h
  • M chrome/browser/ui/waap/waap_utils_unittest.cc
Change size: S
Delta: 6 files changed, 18 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Shunya Shishido
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I78c929acf6e42bed8f7015b9582af455f2b81779
Gerrit-Change-Number: 7115405
Gerrit-PatchSet: 2
Gerrit-Owner: Ming-Ying Chung <my...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages