[soft navs] Use gmock matchers in SoftNavigationPrerenderTest [chromium/src : main]
0 views
Skip to first unread message
Johannes Henkel (Gerrit)
Apr 2, 2026, 2:20:14 PM (yesterday) Apr 2
to Annie Sullivan, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Annie Sullivan and Michal Mocny
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Annie Sullivan
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Annie Sullivan (Gerrit)
Apr 2, 2026, 3:01:37 PM (yesterday) Apr 2
to Johannes Henkel, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Johannes Henkel and Michal Mocny
Annie Sullivan voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Johannes Henkel
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
Apr 2, 2026, 11:03:16 PM (22 hours ago) Apr 2
to Michal Mocny, Annie Sullivan, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 11:33:36 PM (21 hours ago) Apr 2
to Johannes Henkel, Michal Mocny, Annie Sullivan, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[soft navs] Use gmock matchers in SoftNavigationPrerenderTest
Motivation is to make the test easier to read and to make
test failures easier to understand.
Bug: 496664486
Change-Id: I2a9ff0e2a24b7e6e3877b57c6510b250337f04c2
Commit-Queue: Johannes Henkel <joha...@chromium.org>
Reviewed-by: Annie Sullivan <sull...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609640}
Files:
- M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
Change size: S
Delta: 1 file changed, 15 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Annie Sullivan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages