WTF: Remove LowerASCII() methods of String and AtomicString [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Mar 11, 2026, 10:00:49 PM (22 hours ago) Mar 11
to Kent Tamura, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, Olga Gerchikov, David Bokan, Kenneth Rohde Christiansen, Menard, Alexis, Fredrik Söderquist, AyeAye, ipc-securi...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org, dominicc+...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org, eric.c...@apple.com, blink-revi...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, webap...@microsoft.com, dmurph+watch...@chromium.org
Attention needed from Chromium IPC Reviews

Kent Tamura voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chromium IPC Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28ccfc28722922c86e1410b2dad167d7b6e222c9
Gerrit-Change-Number: 7657126
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 02:00:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Mar 11, 2026, 10:03:27 PM (22 hours ago) Mar 11
to Kent Tamura, Chromium IPC Reviews, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, Olga Gerchikov, David Bokan, Kenneth Rohde Christiansen, Menard, Alexis, Fredrik Söderquist, AyeAye, ipc-securi...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org, dominicc+...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org, eric.c...@apple.com, blink-revi...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, webap...@microsoft.com, dmurph+watch...@chromium.org
Attention needed from Takashi Toyoshima

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: toyo...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): toyo...@chromium.org


Reviewer source(s):
toyo...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28ccfc28722922c86e1410b2dad167d7b6e222c9
Gerrit-Change-Number: 7657126
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: gwsq
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 02:03:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Mar 11, 2026, 10:07:07 PM (22 hours ago) Mar 11
to Kent Tamura, Chromium IPC Reviews, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, Olga Gerchikov, David Bokan, Kenneth Rohde Christiansen, Menard, Alexis, Fredrik Söderquist, AyeAye, ipc-securi...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org, dominicc+...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org, eric.c...@apple.com, blink-revi...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, webap...@microsoft.com, dmurph+watch...@chromium.org
Attention needed from Takashi Toyoshima

Kent Tamura added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kent Tamura . resolved

chrome-ipc-reviews@, would you stamp a mechanical change in third_party/blink/renderer/modules/manifest/image_resource_type_converters.cc please?

Gerrit-Comment-Date: Thu, 12 Mar 2026 02:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
3:30 AM (17 hours ago) 3:30 AM
to Kent Tamura, Fredrik Söderquist, Chromium IPC Reviews, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, Olga Gerchikov, David Bokan, Kenneth Rohde Christiansen, Menard, Alexis, AyeAye, ipc-securi...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org, dominicc+...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org, eric.c...@apple.com, blink-revi...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, webap...@microsoft.com, dmurph+watch...@chromium.org
Attention needed from Fredrik Söderquist and Takashi Toyoshima

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Commit-Queue+1

1 comment

Patchset-level comments
Kent Tamura . resolved

fs@, would you stamp the whole CL please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28ccfc28722922c86e1410b2dad167d7b6e222c9
Gerrit-Change-Number: 7657126
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: gwsq
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 07:29:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
5:57 AM (15 hours ago) 5:57 AM
to Kent Tamura, Chromium IPC Reviews, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, Olga Gerchikov, David Bokan, Kenneth Rohde Christiansen, Menard, Alexis, AyeAye, ipc-securi...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org, dominicc+...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org, eric.c...@apple.com, blink-revi...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, webap...@microsoft.com, dmurph+watch...@chromium.org
Attention needed from Kent Tamura and Takashi Toyoshima

Fredrik Söderquist voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
  • Takashi Toyoshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I28ccfc28722922c86e1410b2dad167d7b6e222c9
    Gerrit-Change-Number: 7657126
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: gwsq
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 09:56:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    1:47 PM (7 hours ago) 1:47 PM
    to Kent Tamura, Fredrik Söderquist, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, Olga Gerchikov, David Bokan, Kenneth Rohde Christiansen, Menard, Alexis, AyeAye, ipc-securi...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org, dominicc+...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org, eric.c...@apple.com, blink-revi...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, webap...@microsoft.com, dmurph+watch...@chromium.org
    Attention needed from Kent Tamura

    Takashi Toyoshima voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kent Tamura
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I28ccfc28722922c86e1410b2dad167d7b6e222c9
    Gerrit-Change-Number: 7657126
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: gwsq
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 17:46:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kent Tamura (Gerrit)

    unread,
    6:21 PM (2 hours ago) 6:21 PM
    to Kent Tamura, Takashi Toyoshima, Fredrik Söderquist, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, Olga Gerchikov, David Bokan, Kenneth Rohde Christiansen, Menard, Alexis, AyeAye, ipc-securi...@chromium.org, blink-...@chromium.org, kinuko+...@chromium.org, dominicc+...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, gl...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org, eric.c...@apple.com, blink-revi...@chromium.org, silv...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, feature-me...@chromium.org, webap...@microsoft.com, dmurph+watch...@chromium.org
    Attention needed from Fredrik Söderquist and Takashi Toyoshima

    Kent Tamura added 1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Kent Tamura . resolved

    toyoshim@, fs@, would you stamp CR+1 again please?
    This CL dropped html_template_element.cc due to a rebase. Other files are unchanged.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fredrik Söderquist
    • Takashi Toyoshima
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I28ccfc28722922c86e1410b2dad167d7b6e222c9
      Gerrit-Change-Number: 7657126
      Gerrit-PatchSet: 4
      Gerrit-Owner: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: David Bokan <bo...@chromium.org>
      Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: gwsq
      Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
      Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 22:21:13 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages